René's URL Explorer Experiment


Title: fix(realtime): stop read-only members persisting block positions by waleedlatif1 · Pull Request #6174 · simstudioai/sim · GitHub

Open Graph Title: fix(realtime): stop read-only members persisting block positions by waleedlatif1 · Pull Request #6174 · simstudioai/sim

X Title: fix(realtime): stop read-only members persisting block positions by waleedlatif1 · Pull Request #6174 · simstudioai/sim

Description: Summary The socket operation ACL granted the read role block.updatePosition and blocks.batchUpdatePositions, on the premise (stated in the comment) that they were ephemeral cursor sync. They are not — both are followed by persistWorkflowOperation, which UPDATEs workflow_blocks.positionX/positionY and bumps workflow.updatedAt. So a member holding only read on a workspace could permanently rewrite the on-canvas coordinates of every block of every workflow in it: a write across the read/write boundary, with no UI affordance to undo beyond manual re-layout. The batch form does it for every block in one call and does not even require the commit flag. The premise was wrong twice over: live cursors ride their own cursor-update event (handlers/presence.ts), and the smooth-drag broadcast is the uncommitted position path, which returns before persisting and never consults the role table at all. So read needs no grant — it is now []. Client-side this changes nothing for legitimate users: nodesDraggable and onNodeDrag/onNodeDragStop are already gated on canEdit, so a read-only member never emits these through the UI. Reaching the hole required a hand-crafted socket frame. Type of Change Bug fix (security — privilege escalation / integrity) Testing New handlers/operations.test.ts drives the real handler and the real permission middleware (only the DB and the workspace authorizer are mocked) and asserts on persistWorkflowOperation, since that is what actually writes the row: a read member is refused for both the committed single and the batch form, and a write member still persists both (positive control). A third case pins the no-regression edge: an uncommitted position update from a read member still relays and still does not persist, so tightening the ACL did not turn the ungated smooth-drag broadcast into an error. Existing permissions.test.ts cases that encoded the vulnerable behaviour ("should allow batch-update-positions operation for read role") are inverted, and the blanket case now asserts the read role holds no operation at all. Verified the suite actually catches this: restoring the two grants fails 8 tests, including the two that assert the database write is blocked. 273 tests pass; tsc, lint, and all 12 CI audit scripts green locally. Notes for review Considered and deliberately not done: gating persistWorkflowOperation itself on permissionSatisfies(role, 'write') as belt-and-braces. Every persist call in operations.ts is already downstream of the single permission gate (the only bypass, the uncommitted position path, returns before persisting), and subblocks.ts / variables.ts carry their own gates — so the runtime check would be pure redundancy, at the cost of an extra failure mode that surfaces to clients as a retryable persistence error. The invariant is instead pinned by the test asserting read grants nothing. Residual, out of scope and lower severity: a read-only member can still broadcast uncommitted position frames (phantom moves other collaborators see, which nothing persists and a refresh clears). That path is intentionally ungated for drag latency. Happy to close it in a follow-up if you'd like — it needs a synchronous check on the hot path rather than the existing async one. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The socket operation ACL granted the read role block.updatePosition and blocks.batchUpdatePositions, on the premise (stated in the comment) that they were ephemeral cursor sync. They are n...

X Description: Summary The socket operation ACL granted the read role block.updatePosition and blocks.batchUpdatePositions, on the premise (stated in the comment) that they were ephemeral cursor sync. They are n...

Opengraph URL: https://github.com/simstudioai/sim/pull/6174

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f772abd4-16bc-6a4a-a8fd-662a89d90b9c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD3E6:283A10:57DEEA:7D5F9F:6AFB4313
html-safe-nonce726b093b64671acb666915187fcd304da0a166264350816710d941a8fc653cb3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEM0U2OjI4M0ExMDo1N0RFRUE6N0Q1RjlGOjZBRkI0MzEzIiwidmlzaXRvcl9pZCI6IjM5OTUwODA2MTIzMzAwMjk4NDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac01ce93bdf8d69a9935f0bc0bf0c6cf1536e397653bc1a393983832f775b3a4ab
hovercard-subject-tagpull_request:4186061157
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6174/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The socket operation ACL granted the read role block.updatePosition and blocks.batchUpdatePositions, on the premise (stated in the comment) that they were ephemeral cursor sync. They are n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6174/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6174%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6174%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6174/files
Reloadhttps://github.com/simstudioai/sim/pull/6174/files
Reloadhttps://github.com/simstudioai/sim/pull/6174/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/realtime-read-role-position-writeshttps://github.com/simstudioai/sim/tree/fix/realtime-read-role-position-writes
Conversation 9 https://github.com/simstudioai/sim/pull/6174
Commits 2 https://github.com/simstudioai/sim/pull/6174/commits
Checks 27 https://github.com/simstudioai/sim/pull/6174/checks
Files changed https://github.com/simstudioai/sim/pull/6174/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6174/files
fix(realtime): stop read-only members persisting block positions https://github.com/simstudioai/sim/pull/6174/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6174/files
4642715 fix(realtime): stop read-only members persisting block positions waleedlatif1 Aug 2, 2026 https://github.com/simstudioai/sim/pull/6174/commits/4642715993c4edf67e4a8ae1a929b1373cfde9be
0fd8b1f test(realtime): assert the role ACL against production, not a fixture waleedlatif1 Aug 2, 2026 https://github.com/simstudioai/sim/pull/6174/commits/0fd8b1f1943866af58cd6f71cce8feb0e50ac056
Clear filters https://github.com/simstudioai/sim/pull/6174/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6174/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6174/files
operations.test.ts https://github.com/simstudioai/sim/pull/6174/files#diff-f6edae6d2295dd723f942192148d7362f73d7fe4c9a31693b6f1bc411b9af45e
permissions.test.ts https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
permissions.ts https://github.com/simstudioai/sim/pull/6174/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
permission.factory.ts https://github.com/simstudioai/sim/pull/6174/files#diff-c2c1f0da900cfe1f92291475d94409045dccba0ffa4228f3d046a9c0eba31d81
apps/realtime/src/handlers/operations.test.tshttps://github.com/simstudioai/sim/pull/6174/files#diff-f6edae6d2295dd723f942192148d7362f73d7fe4c9a31693b6f1bc411b9af45e
View file https://github.com/simstudioai/sim/blob/0fd8b1f1943866af58cd6f71cce8feb0e50ac056/apps/realtime/src/handlers/operations.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6174/{{ revealButtonHref }}
apps/realtime/src/middleware/permissions.test.tshttps://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
View file https://github.com/simstudioai/sim/blob/0fd8b1f1943866af58cd6f71cce8feb0e50ac056/apps/realtime/src/middleware/permissions.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6174/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
Please reload this pagehttps://github.com/simstudioai/sim/pull/6174/files
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
https://github.com/simstudioai/sim/pull/6174/files#diff-df8569942debacaacf33092a1ceb70e82fe44eea791fdbf8ed591ad32c9776ac
apps/realtime/src/middleware/permissions.tshttps://github.com/simstudioai/sim/pull/6174/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
View file https://github.com/simstudioai/sim/blob/0fd8b1f1943866af58cd6f71cce8feb0e50ac056/apps/realtime/src/middleware/permissions.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6174/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6174/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
https://github.com/simstudioai/sim/pull/6174/files#diff-fe5f280efeac435d7aad7d310560421ad87b21af62233547c3ec3ca19a5967d8
Please reload this pagehttps://github.com/simstudioai/sim/pull/6174/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6174/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.