René's URL Explorer Experiment


Title: fix(ssh/sftp): cap remote file reads on received bytes, not stat() size by waleedlatif1 · Pull Request #6168 · simstudioai/sim · GitHub

Open Graph Title: fix(ssh/sftp): cap remote file reads on received bytes, not stat() size by waleedlatif1 · Pull Request #6168 · simstudioai/sim

X Title: fix(ssh/sftp): cap remote file reads on received bytes, not stat() size by waleedlatif1 · Pull Request #6168 · simstudioai/sim

Description: Summary The SFTP/SSH download routes buffered a remote file into memory with the only size guard being sftp.stat().size — a value the caller-supplied SSH server controls. A server that reports a tiny size and then streams endlessly drove unbounded heap growth until OOM. Read through the existing readNodeStreamToBufferWithLimit limiter (the same one the S3/GCS/Blob providers use), which enforces the cap on bytes actually received and destroys the stream on breach, via a small readSftpFileCapped wrapper in sftp/utils. All four SFTP-reading tool routes now share it — sftp/download, ssh/download-file, ssh/read-file-content, and the append path of ssh/write-file-content, which had no cap at all. The wrapper keeps a no-op error listener on the stream for its whole life: ssh2 rejects still-pending SFTP requests when the channel closes, which arrives as a late error event after the limiter has detached its own handlers, and an error event with no listener would take the process down. Too-large responses now return 413, matching how onedrive/download, latex, and v1/files surface PayloadSizeLimitError, and responses report the actual byte count rather than the server-reported stat size. Type of Change Bug fix Testing Unit tests in app/api/tools/sftp/utils.test.ts, including a regression test for the late-error-after-abort crash. Verified each goes red when the corresponding guard is removed. Proven end to end against a real ssh2 SFTP server that reports size: 1 for /bomb and then streams forever: the read aborts at ~50MB in ~120ms instead of never terminating, and the process exits cleanly. A legitimate file reads correctly, and a file exactly at the cap still succeeds. 158 tests across app/api/tools, tools/ssh, tools/sftp, lib/core/utils/stream-limits pass; tsc --noEmit clean; check:api-validation:strict, check:boundaries, check:client-boundary, check:utils, check:tool-registry-boundary all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The SFTP/SSH download routes buffered a remote file into memory with the only size guard being sftp.stat().size — a value the caller-supplied SSH server controls. A server that reports a t...

X Description: Summary The SFTP/SSH download routes buffered a remote file into memory with the only size guard being sftp.stat().size — a value the caller-supplied SSH server controls. A server that reports a t...

Opengraph URL: https://github.com/simstudioai/sim/pull/6168

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a1b18a3f-f375-105c-3ede-6e84176014b6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C80:327CBE:692AF3:956584:6AFB46A6
html-safe-nonce6ee9a941f0ab83ad87c66c34b3f4182a41ac8f2a5f0bd2d518643a0bdb05a3d0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzgwOjMyN0NCRTo2OTJBRjM6OTU2NTg0OjZBRkI0NkE2IiwidmlzaXRvcl9pZCI6IjgwMTI3OTQ0ODA3NDQ0MTY5MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0824d6c5e20588608460bee5203202ce2f24095cce17c3c961e1515c2b3f7c4a
hovercard-subject-tagpull_request:4185096413
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6168/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The SFTP/SSH download routes buffered a remote file into memory with the only size guard being sftp.stat().size — a value the caller-supplied SSH server controls. A server that reports a t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6168/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6168%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6168%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6168/files
Reloadhttps://github.com/simstudioai/sim/pull/6168/files
Reloadhttps://github.com/simstudioai/sim/pull/6168/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-fix-sftp-ssh-download-read-caphttps://github.com/simstudioai/sim/tree/worktree-fix-sftp-ssh-download-read-cap
Conversation 9 https://github.com/simstudioai/sim/pull/6168
Commits 1 https://github.com/simstudioai/sim/pull/6168/commits
Checks 28 https://github.com/simstudioai/sim/pull/6168/checks
Files changed https://github.com/simstudioai/sim/pull/6168/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6168/files
fix(ssh/sftp): cap remote file reads on received bytes, not stat() size https://github.com/simstudioai/sim/pull/6168/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6168/files
fb510d1 fix(ssh/sftp): cap remote file reads on received bytes, not stat() size waleedlatif1 Aug 1, 2026 https://github.com/simstudioai/sim/pull/6168/commits/fb510d11a2f985785bd86b575b2ce97bbd55536d
Clear filters https://github.com/simstudioai/sim/pull/6168/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6168/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6168/files
route.ts https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
utils.test.ts https://github.com/simstudioai/sim/pull/6168/files#diff-f6667b50e4ef566eb700a413fb2659da124ac1fc470545fe3f2df19634b6c8b6
utils.ts https://github.com/simstudioai/sim/pull/6168/files#diff-89c2a54af7b8350e9ed7f25195e696f575fc6ee475d795c5efc2e06427348d90
route.ts https://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
route.ts https://github.com/simstudioai/sim/pull/6168/files#diff-19ddee2f8347daaea935519b540a482b19498683f37e184e897f02316d32f583
route.ts https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
apps/sim/app/api/tools/sftp/download/route.tshttps://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
View file https://github.com/simstudioai/sim/blob/fb510d11a2f985785bd86b575b2ce97bbd55536d/apps/sim/app/api/tools/sftp/download/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6168/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
https://github.com/simstudioai/sim/pull/6168/files#diff-7b43161286bd70102fb159897ba8b2c2fe753d41497bd5371c35330e3fe4f6ef
apps/sim/app/api/tools/sftp/utils.test.tshttps://github.com/simstudioai/sim/pull/6168/files#diff-f6667b50e4ef566eb700a413fb2659da124ac1fc470545fe3f2df19634b6c8b6
View file https://github.com/simstudioai/sim/blob/fb510d11a2f985785bd86b575b2ce97bbd55536d/apps/sim/app/api/tools/sftp/utils.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6168/{{ revealButtonHref }}
apps/sim/app/api/tools/sftp/utils.tshttps://github.com/simstudioai/sim/pull/6168/files#diff-89c2a54af7b8350e9ed7f25195e696f575fc6ee475d795c5efc2e06427348d90
View file https://github.com/simstudioai/sim/blob/fb510d11a2f985785bd86b575b2ce97bbd55536d/apps/sim/app/api/tools/sftp/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6168/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6168/files#diff-89c2a54af7b8350e9ed7f25195e696f575fc6ee475d795c5efc2e06427348d90
https://github.com/simstudioai/sim/pull/6168/files#diff-89c2a54af7b8350e9ed7f25195e696f575fc6ee475d795c5efc2e06427348d90
https://github.com/simstudioai/sim/pull/6168/files#diff-89c2a54af7b8350e9ed7f25195e696f575fc6ee475d795c5efc2e06427348d90
apps/sim/app/api/tools/ssh/download-file/route.tshttps://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
View file https://github.com/simstudioai/sim/blob/fb510d11a2f985785bd86b575b2ce97bbd55536d/apps/sim/app/api/tools/ssh/download-file/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6168/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
https://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
https://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
https://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
https://github.com/simstudioai/sim/pull/6168/files#diff-a3f4bacaf2cf09c18ce1193c2230ef5251248d8c981e9c1ace66919b96ebac09
apps/sim/app/api/tools/ssh/read-file-content/route.tshttps://github.com/simstudioai/sim/pull/6168/files#diff-19ddee2f8347daaea935519b540a482b19498683f37e184e897f02316d32f583
View file https://github.com/simstudioai/sim/blob/fb510d11a2f985785bd86b575b2ce97bbd55536d/apps/sim/app/api/tools/ssh/read-file-content/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6168/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6168/files#diff-19ddee2f8347daaea935519b540a482b19498683f37e184e897f02316d32f583
https://github.com/simstudioai/sim/pull/6168/files#diff-19ddee2f8347daaea935519b540a482b19498683f37e184e897f02316d32f583
https://github.com/simstudioai/sim/pull/6168/files#diff-19ddee2f8347daaea935519b540a482b19498683f37e184e897f02316d32f583
https://github.com/simstudioai/sim/pull/6168/files#diff-19ddee2f8347daaea935519b540a482b19498683f37e184e897f02316d32f583
apps/sim/app/api/tools/ssh/write-file-content/route.tshttps://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
View file https://github.com/simstudioai/sim/blob/fb510d11a2f985785bd86b575b2ce97bbd55536d/apps/sim/app/api/tools/ssh/write-file-content/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6168/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
https://github.com/simstudioai/sim/pull/6168/files#diff-b77b1c4e0fa25bc45c4dd07b3a336d29c2e6097686b9e6ae55bba26a3bd1b4e2
Please reload this pagehttps://github.com/simstudioai/sim/pull/6168/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.