René's URL Explorer Experiment


Title: perf(tools): move mergeToolParameters into a registry-free leaf module by waleedlatif1 · Pull Request #6152 · simstudioai/sim · GitHub

Open Graph Title: perf(tools): move mergeToolParameters into a registry-free leaf module by waleedlatif1 · Pull Request #6152 · simstudioai/sim

X Title: perf(tools): move mergeToolParameters into a registry-free leaf module by waleedlatif1 · Pull Request #6152 · simstudioai/sim

Description: Stacked on #6151. Review that first; base retargets to staging once it merges. Why providers/utils.ts imports exactly one symbol from @/tools/params — mergeToolParameters. That function does no tool lookup at all; it merges two plain param objects. But params.ts imports getTool from @/tools/utils, which statically imports the 4,300-entry @/tools/registry barrel. So that one-symbol import was dragging the entire tool registry — and every tool's HTTP closures, SDK clients and transitive deps — into every module graph that reached it. Measurement Module-graph walk from each entry (imports + re-exports, import type excluded): entry before after providers/utils.ts 4,926 (registry reachable) 22 (registry unreachable ✅) tools/params.ts 4,926 4,927 (unchanged — still owns getTool) tools/merge-params.ts — 2 (registry unreachable ✅) What moved mergeToolParameters, deepMergeInputMapping and isNonEmpty → @/tools/merge-params, copied verbatim. The new module is documented as forbidden from importing @/tools/utils, @/tools/registry or @/tools/params. params.ts now imports isNonEmpty from there; its isRecordLike and isEmptyTagValue imports became unused and are dropped. Both consumers (providers/utils.ts, executor/handlers/pi/sim-tools.ts) import the new module directly rather than through a re-export, per the no-re-exports rule. This is preparation, not the payoff The canvas route still reaches the registry through three other edges — block-outputs, serializer, and sanitization/validation. All four are redundant paths, so the route's module count does not move until all of them are cut. That happens in the metadata-manifest PRs stacked on top of this one. Test plan vitest run tools/ providers/ executor/handlers/pi/ — 3,262 passed tsc --noEmit exit 0 check:client-boundary, check:utils, check:boundaries pass biome clean One pre-existing failure, executor/handlers/pi/cloud-review-tools.test.ts, is environmental — it shells out to a rg binary that isn't installed on this machine. Verified it fails identically on the base commit with these changes stashed.

Open Graph Description: Stacked on #6151. Review that first; base retargets to staging once it merges. Why providers/utils.ts imports exactly one symbol from @/tools/params — mergeToolParameters. That function does no to...

X Description: Stacked on #6151. Review that first; base retargets to staging once it merges. Why providers/utils.ts imports exactly one symbol from @/tools/params — mergeToolParameters. That function does no to...

Opengraph URL: https://github.com/simstudioai/sim/pull/6152

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6c8b6edc-14ec-257f-879a-91e7e48627c5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF2A:15B52D:55BC8B:7B097E:6AFB3E62
html-safe-nonceab0afd72ee6ad604a1df0d5ad4cc818222625372a6f2121b550a39ef6a68bdca
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjJBOjE1QjUyRDo1NUJDOEI6N0IwOTdFOjZBRkIzRTYyIiwidmlzaXRvcl9pZCI6Ijc5MTk3OTE0MTc4MzA2MjA3NzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5ed05347fc5a06ed1e4dc279e084e33e2c73042ef12904271420ab4cef15bb00
hovercard-subject-tagpull_request:4182725193
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6152/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altStacked on #6151. Review that first; base retargets to staging once it merges. Why providers/utils.ts imports exactly one symbol from @/tools/params — mergeToolParameters. That function does no to...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6152/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6152%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6152%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6152/files
Reloadhttps://github.com/simstudioai/sim/pull/6152/files
Reloadhttps://github.com/simstudioai/sim/pull/6152/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests202 (202)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
perf/dev-fs-cachehttps://github.com/simstudioai/sim/tree/perf/dev-fs-cache
perf/tools-params-splithttps://github.com/simstudioai/sim/tree/perf/tools-params-split
Conversation 3 https://github.com/simstudioai/sim/pull/6152
Commits 2 https://github.com/simstudioai/sim/pull/6152/commits
Checks 25 https://github.com/simstudioai/sim/pull/6152/checks
Files changed https://github.com/simstudioai/sim/pull/6152/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6152/files
perf(tools): move mergeToolParameters into a registry-free leaf module https://github.com/simstudioai/sim/pull/6152/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6152/files
57a6765 perf(tools): move mergeToolParameters into a registry-free leaf module waleedlatif1 Aug 1, 2026 https://github.com/simstudioai/sim/pull/6152/commits/57a676538962725c714f50051a9fd08945fa4e10
41182a3 refactor(tools): make deepMergeInputMapping module-private waleedlatif1 Aug 1, 2026 https://github.com/simstudioai/sim/pull/6152/commits/41182a3d7d91e04d9546284e53656bb42d91e312
Clear filters https://github.com/simstudioai/sim/pull/6152/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6152/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6152/files
sim-tools.ts https://github.com/simstudioai/sim/pull/6152/files#diff-91b96d852412076af5f7482898a3583e12413ffffd7e227b1b3e955d4ccfd3e4
utils.ts https://github.com/simstudioai/sim/pull/6152/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
merge-params.ts https://github.com/simstudioai/sim/pull/6152/files#diff-59eea2548af4187c0c196bee779817060e8217160106e4b03e87a7fb1debe258
params.test.ts https://github.com/simstudioai/sim/pull/6152/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
params.ts https://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
apps/sim/executor/handlers/pi/sim-tools.tshttps://github.com/simstudioai/sim/pull/6152/files#diff-91b96d852412076af5f7482898a3583e12413ffffd7e227b1b3e955d4ccfd3e4
View file https://github.com/simstudioai/sim/blob/41182a3d7d91e04d9546284e53656bb42d91e312/apps/sim/executor/handlers/pi/sim-tools.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6152/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6152/files#diff-91b96d852412076af5f7482898a3583e12413ffffd7e227b1b3e955d4ccfd3e4
https://github.com/simstudioai/sim/pull/6152/files#diff-91b96d852412076af5f7482898a3583e12413ffffd7e227b1b3e955d4ccfd3e4
apps/sim/providers/utils.tshttps://github.com/simstudioai/sim/pull/6152/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
View file https://github.com/simstudioai/sim/blob/41182a3d7d91e04d9546284e53656bb42d91e312/apps/sim/providers/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6152/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6152/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
https://github.com/simstudioai/sim/pull/6152/files#diff-e5a8ed3fe51b6470c7acddd9beac4eecb4c915cacc23d40b68b566a998ac121e
apps/sim/tools/merge-params.tshttps://github.com/simstudioai/sim/pull/6152/files#diff-59eea2548af4187c0c196bee779817060e8217160106e4b03e87a7fb1debe258
View file https://github.com/simstudioai/sim/blob/41182a3d7d91e04d9546284e53656bb42d91e312/apps/sim/tools/merge-params.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6152/{{ revealButtonHref }}
apps/sim/tools/params.test.tshttps://github.com/simstudioai/sim/pull/6152/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
View file https://github.com/simstudioai/sim/blob/41182a3d7d91e04d9546284e53656bb42d91e312/apps/sim/tools/params.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6152/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6152/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
https://github.com/simstudioai/sim/pull/6152/files#diff-2a6b05a23c0402523d5acb6236fade89bec013d19315864b4b1fec0f4ad96996
apps/sim/tools/params.tshttps://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
View file https://github.com/simstudioai/sim/blob/41182a3d7d91e04d9546284e53656bb42d91e312/apps/sim/tools/params.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6152/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
https://github.com/simstudioai/sim/pull/6152/files#diff-e0607e3a0993ac21ca5f808e30e0c6cf25e9ce2f5cc9e09a02afd48243d6b420
Please reload this pagehttps://github.com/simstudioai/sim/pull/6152/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.