Title: fix(emcn): stop the tab strip scrolling vertically by a pixel by waleedlatif1 · Pull Request #6113 · simstudioai/sim · GitHub
Open Graph Title: fix(emcn): stop the tab strip scrolling vertically by a pixel by waleedlatif1 · Pull Request #6113 · simstudioai/sim
X Title: fix(emcn): stop the tab strip scrolling vertically by a pixel by waleedlatif1 · Pull Request #6113 · simstudioai/sim
Description: The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it covers the bottom border and reads as joined to the panel below. That pixel came from -mb-px on the tab button, which meant it overflowed the row containing it — and that row is a scroll container, because overflow-x: auto computes a visible overflow-y to auto as well. One pixel of scrollable overflow is all it takes. Fix Move the overlap onto the row instead of the tab. The tabs then sit flush inside the scroll container so there is nothing to scroll, while the row itself still hangs the pixel over the border. No visual change. Verification Measured in a real renderer using the component's own class strings: scrollHeight clientHeight y-overflow before 30 29 1px, scrollable after 30 30 0 Worth noting: a first attempt to reproduce this with hand-written inline styles showed no overflow. Only the real compiled classes surfaced it, which is why the numbers above come from the actual class output rather than a simplified repro. The guard asserts the overlap lives on the scrolling row and not on the tab, and was confirmed to fail when the original layout is restored. TabStrip is shared by the browser and terminal panels, so both stop scrolling. Not included The reported "can't open a new tab" is a separate issue and is deliberately left out of this PR. Diagnosed for whoever picks it up: at MAX_BROWSER_TABS (8) the new-tab button is disabled, and the shared button applies disabled:pointer-events-none — so the trigger cannot receive hover and the tooltip that would say "Maximum of 8 tabs" never opens. Separately, ipc.ts:578 does .catch(() => {}) around handlePanelAction, so the SessionError thrown by addTabInternal at the cap is discarded. Between the two, the button looks simply broken.
Open Graph Description: The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it cove...
X Description: The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it ...
Opengraph URL: https://github.com/simstudioai/sim/pull/6113
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:75e6b101-bdfc-ef18-128c-f2e33aca6713 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AB64:73CE1:AC56F8:EC66E6:6AFB5006 |
| html-safe-nonce | f12049a2a1a57ffee560533d5ba01ac6d12df5e52d86b9c1b72cd766cd7d84f0 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjY0OjczQ0UxOkFDNTZGODpFQzY2RTY6NkFGQjUwMDYiLCJ2aXNpdG9yX2lkIjoiMjQ5MTczMTUxMDU2NjgwMTQxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e49fe49dd3ed662a6e4cdb2083dd7b5f90d313393b3816708286a05580f45c49 |
| hovercard-subject-tag | pull_request:4174181180 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6113/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it cove... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width