René's URL Explorer Experiment


Title: fix(emcn): stop the tab strip scrolling vertically by a pixel by waleedlatif1 · Pull Request #6113 · simstudioai/sim · GitHub

Open Graph Title: fix(emcn): stop the tab strip scrolling vertically by a pixel by waleedlatif1 · Pull Request #6113 · simstudioai/sim

X Title: fix(emcn): stop the tab strip scrolling vertically by a pixel by waleedlatif1 · Pull Request #6113 · simstudioai/sim

Description: The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it covers the bottom border and reads as joined to the panel below. That pixel came from -mb-px on the tab button, which meant it overflowed the row containing it — and that row is a scroll container, because overflow-x: auto computes a visible overflow-y to auto as well. One pixel of scrollable overflow is all it takes. Fix Move the overlap onto the row instead of the tab. The tabs then sit flush inside the scroll container so there is nothing to scroll, while the row itself still hangs the pixel over the border. No visual change. Verification Measured in a real renderer using the component's own class strings: scrollHeight clientHeight y-overflow before 30 29 1px, scrollable after 30 30 0 Worth noting: a first attempt to reproduce this with hand-written inline styles showed no overflow. Only the real compiled classes surfaced it, which is why the numbers above come from the actual class output rather than a simplified repro. The guard asserts the overlap lives on the scrolling row and not on the tab, and was confirmed to fail when the original layout is restored. TabStrip is shared by the browser and terminal panels, so both stop scrolling. Not included The reported "can't open a new tab" is a separate issue and is deliberately left out of this PR. Diagnosed for whoever picks it up: at MAX_BROWSER_TABS (8) the new-tab button is disabled, and the shared button applies disabled:pointer-events-none — so the trigger cannot receive hover and the tooltip that would say "Maximum of 8 tabs" never opens. Separately, ipc.ts:578 does .catch(() => {}) around handlePanelAction, so the SessionError thrown by addTabInternal at the cap is discarded. Between the two, the button looks simply broken.

Open Graph Description: The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it cove...

X Description: The desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6113

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:75e6b101-bdfc-ef18-128c-f2e33aca6713
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAB64:73CE1:AC56F8:EC66E6:6AFB5006
html-safe-noncef12049a2a1a57ffee560533d5ba01ac6d12df5e52d86b9c1b72cd766cd7d84f0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQjY0OjczQ0UxOkFDNTZGODpFQzY2RTY6NkFGQjUwMDYiLCJ2aXNpdG9yX2lkIjoiMjQ5MTczMTUxMDU2NjgwMTQxNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace49fe49dd3ed662a6e4cdb2083dd7b5f90d313393b3816708286a05580f45c49
hovercard-subject-tagpull_request:4174181180
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6113/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altThe desktop browser's tab strip could be scrolled on the y axis — enough for a trackpad to nudge the tabs half out of view. Root cause The active tab extends one pixel past the strip so it cove...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6113/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6113%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6113%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6113/files
Reloadhttps://github.com/simstudioai/sim/pull/6113/files
Reloadhttps://github.com/simstudioai/sim/pull/6113/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix-desktop-browser-tabshttps://github.com/simstudioai/sim/tree/fix-desktop-browser-tabs
Conversation 11 https://github.com/simstudioai/sim/pull/6113
Commits 2 https://github.com/simstudioai/sim/pull/6113/commits
Checks 27 https://github.com/simstudioai/sim/pull/6113/checks
Files changed https://github.com/simstudioai/sim/pull/6113/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6113/files
fix(emcn): stop the tab strip scrolling vertically by a pixel https://github.com/simstudioai/sim/pull/6113/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/6113/files
93593c2 fix(emcn): stop the tab strip scrolling vertically by a pixel waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6113/commits/93593c2f53a1833fb80c5f5546ab302b1d80b87a
b0bd2f2 test(emcn): pin the invariant, not the class placement waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6113/commits/b0bd2f2feaa41b9a40260238b5ee23e9bceb8371
Clear filters https://github.com/simstudioai/sim/pull/6113/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6113/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6113/files
tab-strip.test.ts https://github.com/simstudioai/sim/pull/6113/files#diff-f07f0d5af0a60bea4671a95af8288217a19c772de903f2e95f702dc1203fa27d
tab-strip.tsx https://github.com/simstudioai/sim/pull/6113/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
packages/emcn/src/components/tab-strip/tab-strip.test.tshttps://github.com/simstudioai/sim/pull/6113/files#diff-f07f0d5af0a60bea4671a95af8288217a19c772de903f2e95f702dc1203fa27d
View file https://github.com/simstudioai/sim/blob/b0bd2f2feaa41b9a40260238b5ee23e9bceb8371/packages/emcn/src/components/tab-strip/tab-strip.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6113/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6113/files#diff-f07f0d5af0a60bea4671a95af8288217a19c772de903f2e95f702dc1203fa27d
https://github.com/simstudioai/sim/pull/6113/files#diff-f07f0d5af0a60bea4671a95af8288217a19c772de903f2e95f702dc1203fa27d
packages/emcn/src/components/tab-strip/tab-strip.tsxhttps://github.com/simstudioai/sim/pull/6113/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
View file https://github.com/simstudioai/sim/blob/b0bd2f2feaa41b9a40260238b5ee23e9bceb8371/packages/emcn/src/components/tab-strip/tab-strip.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6113/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6113/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
https://github.com/simstudioai/sim/pull/6113/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
https://github.com/simstudioai/sim/pull/6113/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
https://github.com/simstudioai/sim/pull/6113/files#diff-12c2ca8a3aafb86d7c16fe72d1a349d77ba3de13abfa331b9120bc10d64bd425
Please reload this pagehttps://github.com/simstudioai/sim/pull/6113/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.