René's URL Explorer Experiment


Title: fix(tables): refuse scale suffixes and resolve the lone-separator ambiguity by waleedlatif1 · Pull Request #6111 · simstudioai/sim · GitHub

Open Graph Title: fix(tables): refuse scale suffixes and resolve the lone-separator ambiguity by waleedlatif1 · Pull Request #6111 · simstudioai/sim

X Title: fix(tables): refuse scale suffixes and resolve the lone-separator ambiguity by waleedlatif1 · Pull Request #6111 · simstudioai/sim

Description: Follow-up to #6106, which merged before this landed. The first item below is live on staging now and destroys data. Summary 1.2 M parses as 1.2. A string column holding 1.2 M / 3.4 M — an ordinary spreadsheet paste — converts to currency with zero reported incompatibilities and rewrites every cell a millionfold too small. Same for 5 K, 3.4 bn, 10 B. Now refused. 1.235 ¥ (de-DE JPY) parses as 1.235 instead of 1235. A lone separator followed by three digits is now resolved by two signals: a marker means a formatter produced it and formatters group, while a currency carrying three decimals (KWD, TND) reads them as decimals. coerce passes the column's code so the parser can ask. Bare typed input keeps the decimal reading. The unchanged-type throw added in #6106 fell through to a 500 for every type except currency, whose message happened to contain the word. Now 400. Removes the last three comments describing the two-transaction architecture #6106 replaced. Why it wasn't in #6106 Widening the currency marker to 1–3 letters (to support kr, zł, R$, CHF) is what made one- and two-letter scale suffixes parse. The previous [A-Za-z]{3}$ required exactly three letters, so M and K were rejected and the data was safe. My fix opened a hole of exactly the class it closed — found by a verification pass that ran after the merge. kr still parses despite starting with the same letter as K; the suffix rule requires the whole trailing token to match. Deliberate limits, documented in the code Both fail closed — null, never a wrong number: Markers written flush against the digits (Rp12,00) stay rejected. A letter touching a digit is the only thing distinguishing a currency marker from a part number, and reading SKU400 as 400 invents a value where refusing merely inconveniences. Locales formatting with their own numeral systems (Arabic-Indic ١٢٣). Supporting them is wider than this type — it would also touch number, display, and sorting. Type of Change Bug fix Testing New cases for scale suffixes, the lone-separator resolution across JPY/KWD/TND, and the kr-vs-K distinction. The generated Intl locale sweep from #6106 still passes: 24 locale/currency pairs × 6 amounts round-trip. 3671 tests green in the touched areas; check:utils, check:api-validation:strict, check:client-boundary, check:react-query pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Follow-up to #6106, which merged before this landed. The first item below is live on staging now and destroys data. Summary 1.2 M parses as 1.2. A string column holding 1.2 M / 3.4 M — an ordinary...

X Description: Follow-up to #6106, which merged before this landed. The first item below is live on staging now and destroys data. Summary 1.2 M parses as 1.2. A string column holding 1.2 M / 3.4 M — an ordinary...

Opengraph URL: https://github.com/simstudioai/sim/pull/6111

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cd42ca1c-51fd-9cd5-35ad-f04cb03b7de6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9936:2FF5E0:AA6DA7:EA4F38:6AFB50C4
html-safe-noncee23daf26f41b3b3c159b0cb83088d98567a1f2b3b40b4af210d1c031e896e54c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OTM2OjJGRjVFMDpBQTZEQTc6RUE0RjM4OjZBRkI1MEM0IiwidmlzaXRvcl9pZCI6IjUzMTIxODMzNzUwMzk3NzkwMTIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccbafaff2e5881597f6b863a448c8c7cafffaef84ea44df61b415b45935962b60
hovercard-subject-tagpull_request:4174010968
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6111/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFollow-up to #6106, which merged before this landed. The first item below is live on staging now and destroys data. Summary 1.2 M parses as 1.2. A string column holding 1.2 M / 3.4 M — an ordinary...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6111/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6111%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6111%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6111/files
Reloadhttps://github.com/simstudioai/sim/pull/6111/files
Reloadhttps://github.com/simstudioai/sim/pull/6111/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/currency-scale-suffixhttps://github.com/simstudioai/sim/tree/fix/currency-scale-suffix
Conversation 29 https://github.com/simstudioai/sim/pull/6111
Commits 7 https://github.com/simstudioai/sim/pull/6111/commits
Checks 27 https://github.com/simstudioai/sim/pull/6111/checks
Files changed https://github.com/simstudioai/sim/pull/6111/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6111/files
fix(tables): refuse scale suffixes and resolve the lone-separator ambiguity https://github.com/simstudioai/sim/pull/6111/files#top
Show all changes 7 commits https://github.com/simstudioai/sim/pull/6111/files
6b12f7a fix(tables): refuse scale suffixes and resolve the lone-separator amb… waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/6b12f7a9f9663f5dcd744cba368f2505e6279546
d903900 fix(tables): fit the whole column-type list in the New column dropdown waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/d90390058d65520106df2a46f50c43b8e64a5747
5453662 fix(tables): read a lone separator against the column's currency waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/5453662043fec6f8fb3162ec5d445f037a1bf894
6a47267 fix(tables): let the separator decide a lone-separator amount, not th… waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/6a4726733570ea7aacc5007f1ae20b31ca523fb0
c64d42c fix(tables): check conversions against the target column, not a rebui… waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/c64d42c0e725f24ea3aed044d8e5fe6e0832a518
d4148d1 fix(tables): vet a currency marker against an allowlist, not a scale … waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/d4148d1f020131b0e347a825f02c463158b2f365
66d5479 fix(tables): group a lone dot only when a zero-decimal amount came fo… waleedlatif1 Jul 31, 2026 https://github.com/simstudioai/sim/pull/6111/commits/66d5479f8574dedeb2d16066b4ba94bbf536e788
Clear filters https://github.com/simstudioai/sim/pull/6111/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6111/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6111/files
route.ts https://github.com/simstudioai/sim/pull/6111/files#diff-058ce452846cca33dfbc1301fa472e0b7adccb0eced2c918e09c9aead8c2d6b5
route.ts https://github.com/simstudioai/sim/pull/6111/files#diff-c6bac2d3a6eadf8137191897c7cc8d9caff189a178cbdf7d95c9abb01d43d1e0
column-config-sidebar.tsx https://github.com/simstudioai/sim/pull/6111/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
new-column-dropdown.tsx https://github.com/simstudioai/sim/pull/6111/files#diff-6c88e7b9b12576ce6f5127346e7071b8ade9960a53964b258a3e60db0be8aec3
column-conversion.test.ts https://github.com/simstudioai/sim/pull/6111/files#diff-d8276dfb6cf23764fc6922c8744bac5f3c91d6d40e396849ebd32fe35eaf6d0f
currency.test.ts https://github.com/simstudioai/sim/pull/6111/files#diff-1c442d106a3a6e3b312f7d0ddfa4c2728cc13889c16d37ce6b98c5c807893aa7
currency.ts https://github.com/simstudioai/sim/pull/6111/files#diff-2fdc854be287d653af382088f1fdc88de44bb93c98b875794f29dcd68da52a18
service.ts https://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
currency.ts https://github.com/simstudioai/sim/pull/6111/files#diff-896d9ec91cefaef04481fd3f380460e30e5776f1a51d94b512f0a21dce53c9dc
import.test.ts https://github.com/simstudioai/sim/pull/6111/files#diff-0ee513c4fdfad36c9fddadd81bf3712e6f29da25c25687e9d69cc71361f5bcdd
import.ts https://github.com/simstudioai/sim/pull/6111/files#diff-cb562762d3e5bbf1b12771d80f70144c6aeaa65833c1d3f61872ffc948506f43
apps/sim/app/api/table/[tableId]/columns/route.tshttps://github.com/simstudioai/sim/pull/6111/files#diff-058ce452846cca33dfbc1301fa472e0b7adccb0eced2c918e09c9aead8c2d6b5
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/app/api/table/%5BtableId%5D/columns/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-058ce452846cca33dfbc1301fa472e0b7adccb0eced2c918e09c9aead8c2d6b5
https://github.com/simstudioai/sim/pull/6111/files#diff-058ce452846cca33dfbc1301fa472e0b7adccb0eced2c918e09c9aead8c2d6b5
apps/sim/app/api/v1/tables/[tableId]/columns/route.tshttps://github.com/simstudioai/sim/pull/6111/files#diff-c6bac2d3a6eadf8137191897c7cc8d9caff189a178cbdf7d95c9abb01d43d1e0
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/app/api/v1/tables/%5BtableId%5D/columns/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-c6bac2d3a6eadf8137191897c7cc8d9caff189a178cbdf7d95c9abb01d43d1e0
https://github.com/simstudioai/sim/pull/6111/files#diff-c6bac2d3a6eadf8137191897c7cc8d9caff189a178cbdf7d95c9abb01d43d1e0
...[workspaceId]/tables/[tableId]/components/column-config-sidebar/column-config-sidebar.tsxhttps://github.com/simstudioai/sim/pull/6111/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/column-config-sidebar/column-config-sidebar.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
https://github.com/simstudioai/sim/pull/6111/files#diff-8a24c4a972a10a939213feae3b7af45f0e88bae9450414d39544d91dabc55617
...ace/[workspaceId]/tables/[tableId]/components/new-column-dropdown/new-column-dropdown.tsxhttps://github.com/simstudioai/sim/pull/6111/files#diff-6c88e7b9b12576ce6f5127346e7071b8ade9960a53964b258a3e60db0be8aec3
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/new-column-dropdown/new-column-dropdown.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-6c88e7b9b12576ce6f5127346e7071b8ade9960a53964b258a3e60db0be8aec3
https://github.com/simstudioai/sim/pull/6111/files#diff-6c88e7b9b12576ce6f5127346e7071b8ade9960a53964b258a3e60db0be8aec3
apps/sim/lib/table/__tests__/column-conversion.test.tshttps://github.com/simstudioai/sim/pull/6111/files#diff-d8276dfb6cf23764fc6922c8744bac5f3c91d6d40e396849ebd32fe35eaf6d0f
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/lib/table/__tests__/column-conversion.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-d8276dfb6cf23764fc6922c8744bac5f3c91d6d40e396849ebd32fe35eaf6d0f
https://github.com/simstudioai/sim/pull/6111/files#diff-d8276dfb6cf23764fc6922c8744bac5f3c91d6d40e396849ebd32fe35eaf6d0f
apps/sim/lib/table/__tests__/currency.test.tshttps://github.com/simstudioai/sim/pull/6111/files#diff-1c442d106a3a6e3b312f7d0ddfa4c2728cc13889c16d37ce6b98c5c807893aa7
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/lib/table/__tests__/currency.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-1c442d106a3a6e3b312f7d0ddfa4c2728cc13889c16d37ce6b98c5c807893aa7
https://github.com/simstudioai/sim/pull/6111/files#diff-1c442d106a3a6e3b312f7d0ddfa4c2728cc13889c16d37ce6b98c5c807893aa7
apps/sim/lib/table/column-types/currency.tshttps://github.com/simstudioai/sim/pull/6111/files#diff-2fdc854be287d653af382088f1fdc88de44bb93c98b875794f29dcd68da52a18
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/lib/table/column-types/currency.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-2fdc854be287d653af382088f1fdc88de44bb93c98b875794f29dcd68da52a18
Please reload this pagehttps://github.com/simstudioai/sim/pull/6111/files
https://github.com/simstudioai/sim/pull/6111/files#diff-2fdc854be287d653af382088f1fdc88de44bb93c98b875794f29dcd68da52a18
apps/sim/lib/table/columns/service.tshttps://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
View file https://github.com/simstudioai/sim/blob/66d5479f8574dedeb2d16066b4ba94bbf536e788/apps/sim/lib/table/columns/service.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6111/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
https://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
https://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
https://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
https://github.com/simstudioai/sim/pull/6111/files#diff-034147dccb8313fb3f68d5f7a81a3a6c8614a6570c690a92334fc8ab25524ca5
Please reload this pagehttps://github.com/simstudioai/sim/pull/6111/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6111/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.