Title: fix(settings): add bottom padding to settings sidebar by waleedlatif1 · Pull Request #6097 · simstudioai/sim · GitHub
Open Graph Title: fix(settings): add bottom padding to settings sidebar by waleedlatif1 · Pull Request #6097 · simstudioai/sim
X Title: fix(settings): add bottom padding to settings sidebar by waleedlatif1 · Pull Request #6097 · simstudioai/sim
Description: Summary The settings sidebar's nav list ended flush against the bottom of the sidebar column — the last item had zero bottom gutter (reported by Emir) Root cause: on the settings route the sidebar renders scroll region + nothing after it, while the non-settings branch has a footer block (pt-[9px] pb-2) supplying the bottom gutter. The scroll container's pt-1.5 was copy-pasted from that branch, where the missing pb is fine because the footer follows it Added pb-2 to the settings scroll container, matching the non-settings footer exactly Also normalized the standalone settings shell (account / org / self-host planes) from py-1.5 to pt-1.5 pb-2 — it was 6px, 2px off the workspace sidebar and off its own content pane's p-[8px] inset Type of Change Bug fix Testing Measured the box model in Chromium and WebKit with Playwright: gap from the last nav chip to the sidebar's bottom edge goes 0px -> 8px when the list overflows, and is unchanged (no-op) when it doesn't. Confirmed the padding lands inside the scrollable area (scrollHeight 764 -> 772, clientHeight unchanged) rather than being clipped. Checked for regressions: neither settings sidebar computes hasOverflowBottom, so no bottom-border/fade state can flip; the hasOverflowBottom logic in sidebar.tsx is bound to the untouched non-settings container. No CSS selector targets these containers' padding. The desktop hover-peek card renders this component with isCollapsed=false and stretches rather than being fixed-height, so the padding adds scrollable space instead of clipping — it now clears the card's rounded-lg bottom corners. No tests or snapshots reference these classNames. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The settings sidebar's nav list ended flush against the bottom of the sidebar column — the last item had zero bottom gutter (reported by Emir) Root cause: on the settings route the sid...
X Description: Summary The settings sidebar's nav list ended flush against the bottom of the sidebar column — the last item had zero bottom gutter (reported by Emir) Root cause: on the settings route the...
Opengraph URL: https://github.com/simstudioai/sim/pull/6097
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:44036373-07d5-ccd8-d970-196e18b0712c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9A4:3F4D3B:AD5A4F:ED89D4:6AFB506E |
| html-safe-nonce | 84ee29d0a36a184ca8751e308d015f30a57ab4fe98dfa390559c015420f70611 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUE0OjNGNEQzQjpBRDVBNEY6RUQ4OUQ0OjZBRkI1MDZFIiwidmlzaXRvcl9pZCI6IjUzMjgzMzY3ODU2OTQ3NDA1OTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3f70c0a2f509e17c49441ea938ac181eb8317b59ce5861558ea283f4cf912b33 |
| hovercard-subject-tag | pull_request:4172077624 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6097/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The settings sidebar's nav list ended flush against the bottom of the sidebar column — the last item had zero bottom gutter (reported by Emir) Root cause: on the settings route the sid... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width