Title: chore(gitignore): ignore the repo-root uploads spill directory by waleedlatif1 · Pull Request #6089 · simstudioai/sim · GitHub
Open Graph Title: chore(gitignore): ignore the repo-root uploads spill directory by waleedlatif1 · Pull Request #6089 · simstudioai/sim
X Title: chore(gitignore): ignore the repo-root uploads spill directory by waleedlatif1 · Pull Request #6089 · simstudioai/sim
Description: Summary Running the test suite from the repo root leaves ~40 untracked uploads/execution/**/large-value-*.json artifacts; nothing ignored them UPLOAD_DIR_SERVER is join(process.cwd(), 'uploads'), so it follows the cwd — under turbo run test the cwd is apps/sim and that package's /uploads rule catches it, but a repo-root invocation escapes it Added an anchored /uploads to the root .gitignore. Unanchored uploads/ would also match apps/sim/lib/uploads/ — 61 files of tracked source — and silently ignore anything added there later Type of Change Bug fix Testing Verified both directions: git check-ignore confirms the artifact path is now ignored, and confirms apps/sim/lib/uploads/core/setup.server.ts is still not ignored. bun run lint clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Running the test suite from the repo root leaves ~40 untracked uploads/execution/**/large-value-*.json artifacts; nothing ignored them UPLOAD_DIR_SERVER is join(process.cwd(), 'uploads...
X Description: Summary Running the test suite from the repo root leaves ~40 untracked uploads/execution/**/large-value-*.json artifacts; nothing ignored them UPLOAD_DIR_SERVER is join(process.cwd(), 'upl...
Opengraph URL: https://github.com/simstudioai/sim/pull/6089
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:ca6ed127-8da9-46e2-d479-8bbf7b4b1df0 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8CD8:F138D:5307A2:72E270:6AFB3BF0 |
| html-safe-nonce | a7a18359779d88185d1e96f12dfcb93a9de07399d06afe6be7ed6e7f2df0345b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Q0Q4OkYxMzhEOjUzMDdBMjo3MkUyNzA6NkFGQjNCRjAiLCJ2aXNpdG9yX2lkIjoiODc0MjIxNTg4MDUwMDAwMTc3NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e11687a1ffd74075f71bb740b2073cdd78d1a5d097deb10968ae964af6d0fd87 |
| hovercard-subject-tag | pull_request:4165959256 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6089/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Running the test suite from the repo root leaves ~40 untracked uploads/execution/**/large-value-*.json artifacts; nothing ignored them UPLOAD_DIR_SERVER is join(process.cwd(), 'uploads... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width