René's URL Explorer Experiment


Title: perf(tests): skip jest-dom in node-environment test files by waleedlatif1 · Pull Request #6088 · simstudioai/sim · GitHub

Open Graph Title: perf(tests): skip jest-dom in node-environment test files by waleedlatif1 · Pull Request #6088 · simstudioai/sim

X Title: perf(tests): skip jest-dom in node-environment test files by waleedlatif1 · Pull Request #6088 · simstudioai/sim

Description: Summary Lint and Test is now the CI critical path (184s vs Build App's 147s after #6080), and 143s of that 184s is the test suite. This takes ~8% off it. vitest.setup.ts loaded @testing-library/jest-dom/vitest unconditionally, so all 1,219 test files paid for it. jest-dom only registers DOM matchers (toBeInTheDocument, toBeVisible, …), which are useless without a document — and 985 of those files declare @vitest-environment node. Where the time actually goes From the CI run's own vitest summary (aggregate across workers, so it exceeds wall clock): Duration 141.02s (transform 101.32s, setup 123.76s, import 686.00s, tests 55.18s, environment 15.07s) Actual test execution is 55s. The rest is per-file overhead — and setup is the part a global setup file controls. Measured, same machine, full suite Duration setup (aggregate) baseline 179.47s 367.13s guarded 165.78s 252.72s 7.6% off the suite, 31% off aggregate setup. On a node-only subset (50 files, n=3 each) it's 21% — 2.75s → 2.16s median. Nothing loses a matcher All 7 files that actually call a jest-dom matcher are explicitly @vitest-environment jsdom, so typeof document !== 'undefined' is true for exactly those. Verified by running them: 4 files / 7 tests pass. Full suite is identical either way — 1225 files / 16184 tests pass. The one failure (cloud-review-tools.test.ts) reproduces on unmodified staging: its spawned python3 can't find rg on macOS. CI installs ripgrep explicitly and it passes there. Two CI docs that claimed more than the code does Same class as #6076, found while tracing this: The step was named "Run tests with coverage" but runs bun run test = vitest run, with no --coverage anywhere. The Codecov upload reads apps/sim/coverage, which nothing generates — vitest.config.ts declares no coverage provider. It uploads nothing and still reports success in ~1s because fail_ci_if_error: false. So its green tick has never meant coverage was published. I annotated rather than deleted the Codecov step: @vitest/coverage-v8 is installed, so enabling coverage is possible, but instrumentation costs test time and nothing gates on the result. That's a call for you, not a side effect of a perf change — happy to either wire it up or drop the step. Not addressed here import is the real monster — 686s aggregate vs 55s of actual tests. That's module graph cost per test file, the same root cause as the tool registry being 68–78% of every route's graph. vitest.setup.ts already globally mocks @/blocks/registry; doing the same for @/tools/registry could be large, but it would silently change behaviour for any test that needs real tools, across 1,219 files. Needs its own measured, scoped change. Type of Change Performance Improvement (CI documentation accuracy) Testing Full suite run both ways on the same machine (numbers above); the 7 jest-dom-dependent files run explicitly; actionlint clean; biome clean.

Open Graph Description: Summary Lint and Test is now the CI critical path (184s vs Build App's 147s after #6080), and 143s of that 184s is the test suite. This takes ~8% off it. vitest.setup.ts loaded @testing-library...

X Description: Summary Lint and Test is now the CI critical path (184s vs Build App's 147s after #6080), and 143s of that 184s is the test suite. This takes ~8% off it. vitest.setup.ts loaded @testing-lib...

Opengraph URL: https://github.com/simstudioai/sim/pull/6088

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f62ba3b9-b414-5e62-8e57-c59d7f037d6a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB212:15B52D:5F47B0:88B8CF:6AFB4123
html-safe-noncebfc2e6cd9eb5df24b47dc50801212905bea6e3ec6118ea3af893969bb37f8ca6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjEyOjE1QjUyRDo1RjQ3QjA6ODhCOENGOjZBRkI0MTIzIiwidmlzaXRvcl9pZCI6IjQ3MTMzNTA4MzM4NzYxODk0NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacad97bd202174c9e656379f97ca7ace8deeecb137e92027318aff80e999d50ef5
hovercard-subject-tagpull_request:4165924293
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6088/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Lint and Test is now the CI critical path (184s vs Build App's 147s after #6080), and 143s of that 184s is the test suite. This takes ~8% off it. vitest.setup.ts loaded @testing-library...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6088/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6088%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6088%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6088/files
Reloadhttps://github.com/simstudioai/sim/pull/6088/files
Reloadhttps://github.com/simstudioai/sim/pull/6088/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
perf/test-setup-node-fast-pathhttps://github.com/simstudioai/sim/tree/perf/test-setup-node-fast-path
Conversation 3 https://github.com/simstudioai/sim/pull/6088
Commits 1 https://github.com/simstudioai/sim/pull/6088/commits
Checks 27 https://github.com/simstudioai/sim/pull/6088/checks
Files changed https://github.com/simstudioai/sim/pull/6088/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6088/files
perf(tests): skip jest-dom in node-environment test files https://github.com/simstudioai/sim/pull/6088/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6088/files
264dcef perf(tests): skip jest-dom in node-environment test files waleedlatif1 Jul 30, 2026 https://github.com/simstudioai/sim/pull/6088/commits/264dcef0fc430f79c4ea4c0d62d7fe4d3028f6e6
Clear filters https://github.com/simstudioai/sim/pull/6088/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6088/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6088/files
test-build.yml https://github.com/simstudioai/sim/pull/6088/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
vitest.setup.ts https://github.com/simstudioai/sim/pull/6088/files#diff-1c83d21da09a2c5f53044c10fa0e0a257cccd112a3f4a1156f9e258554abbb3c
.github/workflows/test-build.ymlhttps://github.com/simstudioai/sim/pull/6088/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
View file https://github.com/simstudioai/sim/blob/264dcef0fc430f79c4ea4c0d62d7fe4d3028f6e6/.github/workflows/test-build.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6088/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6088/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/6088/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
https://github.com/simstudioai/sim/pull/6088/files#diff-a583f7935a5f3192471a2999cbf059eadc857228b5be2c7247f481b799949f8d
apps/sim/vitest.setup.tshttps://github.com/simstudioai/sim/pull/6088/files#diff-1c83d21da09a2c5f53044c10fa0e0a257cccd112a3f4a1156f9e258554abbb3c
View file https://github.com/simstudioai/sim/blob/264dcef0fc430f79c4ea4c0d62d7fe4d3028f6e6/apps/sim/vitest.setup.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6088/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6088/files#diff-1c83d21da09a2c5f53044c10fa0e0a257cccd112a3f4a1156f9e258554abbb3c
https://github.com/simstudioai/sim/pull/6088/files#diff-1c83d21da09a2c5f53044c10fa0e0a257cccd112a3f4a1156f9e258554abbb3c
Please reload this pagehttps://github.com/simstudioai/sim/pull/6088/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.