René's URL Explorer Experiment


Title: fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary by waleedlatif1 · Pull Request #6082 · simstudioai/sim · GitHub

Open Graph Title: fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary by waleedlatif1 · Pull Request #6082 · simstudioai/sim

X Title: fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary by waleedlatif1 · Pull Request #6082 · simstudioai/sim

Description: Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Root cause The test passed a deadline of exactly PI_SANDBOX_MAX_LIFETIME_MS (90 min), then asserted the resolved lifetime equalled that ceiling: const timeout = createTimeoutAbortController(90 * 60 * 1000) expect(resolvePiRunLifetimeMs(timeout.signal)).toBe(PI_SANDBOX_MAX_LIFETIME_MS) But the resolved lifetime is Math.min(ceiling, remaining), where remaining is getRemainingExecutionMs() = deadline - Date.now(). With the deadline set equal to the ceiling, remaining starts at the ceiling and decays below it the instant any time elapses — so Math.min returns remaining, not the ceiling. The assertion held only when zero milliseconds passed between constructing the controller and reading it. A coin flip weighted by runner speed. Demonstrated, not guessed ceiling = 5400000 OLD (== ceiling) after 5ms -> 5399994 FAIL (off by 6ms) NEW (ceiling + 60s) after 5ms -> 5400000 PASS The old input drifts by exactly the elapsed time. The new one is exact regardless. The fix also repairs the test's intent The name says the run outlives the ceiling — but a deadline equal to the ceiling isn't outliving it. Raising the deadline past the ceiling fixes the assertion and the intent together, and it's the case actually worth covering: a run whose deadline exceeds the ceiling should be clamped to the ceiling. Derived from PI_SANDBOX_MAX_LIFETIME_MS + 60_000 rather than restating 90 * 60 * 1000, so the test can't silently drift if the async execution ceiling moves — which is exactly how the original hardcoded value came to sit on the boundary. Also drops the old comment's claim that "the provider cap still wins". The provider cap is 24 h, far above the 90 min async ceiling, so the ceiling is what wins — the comment described the opposite of the mechanism. Notes Deliberately not reached for vi.useFakeTimers(). Freezing the clock would mask the boundary rather than fix it, and the assertion would still be testing an input that contradicts the test's name. The sibling assertions in this file that compare against the ceiling (lines 103-104, 145) are safe — they use signals with no deadline, so getRemainingExecutionMs returns undefined and the ceiling is returned unconditionally. Type of Change Bug fix (test correctness / CI flake) Testing Fixed test run 5x, 16/16 passing each time. Mechanism verified directly against the real helpers (output above) rather than inferred from a green run — the old version passed most of the time too, so repetition alone proves nothing here.

Open Graph Description: Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Root ca...

X Description: Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Roo...

Opengraph URL: https://github.com/simstudioai/sim/pull/6082

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:07d27dd1-3bcf-6362-4d9c-f8a8e2478d55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF92:389441:56D74:7B233:6AFB4459
html-safe-nonce8760470705691bd0d5ad55936a658a6ff764da6f1e326eef107c0e739a726b00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjkyOjM4OTQ0MTo1NkQ3NDo3QjIzMzo2QUZCNDQ1OSIsInZpc2l0b3JfaWQiOiI3NDM5MzY3NTg1OTY0NzA0ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacfb2c61dbff804e0b09df43f2614977e28bcaec198b577c951aad249992082f21
hovercard-subject-tagpull_request:4165468318
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6082/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Root ca...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6082/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6082%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6082%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6082/files
Reloadhttps://github.com/simstudioai/sim/pull/6082/files
Reloadhttps://github.com/simstudioai/sim/pull/6082/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/pi-lifetime-boundary-flakehttps://github.com/simstudioai/sim/tree/fix/pi-lifetime-boundary-flake
Conversation 3 https://github.com/simstudioai/sim/pull/6082
Commits 1 https://github.com/simstudioai/sim/pull/6082/commits
Checks 27 https://github.com/simstudioai/sim/pull/6082/checks
Files changed https://github.com/simstudioai/sim/pull/6082/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6082/files
fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary https://github.com/simstudioai/sim/pull/6082/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6082/files
f40c410 fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary waleedlatif1 Jul 30, 2026 https://github.com/simstudioai/sim/pull/6082/commits/f40c410edd649aa4c5f4f8c0a79f642d1f8d3610
Clear filters https://github.com/simstudioai/sim/pull/6082/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6082/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6082/files
apps/sim/lib/execution/remote-sandbox/pi-lifetime.test.tshttps://github.com/simstudioai/sim/pull/6082/files#diff-0d56f4ce4d4caecfc031f4b811f54258325a360506b768136d631f89e09d8c63
View file https://github.com/simstudioai/sim/blob/f40c410edd649aa4c5f4f8c0a79f642d1f8d3610/apps/sim/lib/execution/remote-sandbox/pi-lifetime.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6082/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6082/files#diff-0d56f4ce4d4caecfc031f4b811f54258325a360506b768136d631f89e09d8c63
https://github.com/simstudioai/sim/pull/6082/files#diff-0d56f4ce4d4caecfc031f4b811f54258325a360506b768136d631f89e09d8c63
Please reload this pagehttps://github.com/simstudioai/sim/pull/6082/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.