Title: fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary by waleedlatif1 · Pull Request #6082 · simstudioai/sim · GitHub
Open Graph Title: fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary by waleedlatif1 · Pull Request #6082 · simstudioai/sim
X Title: fix(tests): stop pi-lifetime asserting the ceiling on a racing boundary by waleedlatif1 · Pull Request #6082 · simstudioai/sim
Description: Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Root cause The test passed a deadline of exactly PI_SANDBOX_MAX_LIFETIME_MS (90 min), then asserted the resolved lifetime equalled that ceiling: const timeout = createTimeoutAbortController(90 * 60 * 1000) expect(resolvePiRunLifetimeMs(timeout.signal)).toBe(PI_SANDBOX_MAX_LIFETIME_MS) But the resolved lifetime is Math.min(ceiling, remaining), where remaining is getRemainingExecutionMs() = deadline - Date.now(). With the deadline set equal to the ceiling, remaining starts at the ceiling and decays below it the instant any time elapses — so Math.min returns remaining, not the ceiling. The assertion held only when zero milliseconds passed between constructing the controller and reading it. A coin flip weighted by runner speed. Demonstrated, not guessed ceiling = 5400000 OLD (== ceiling) after 5ms -> 5399994 FAIL (off by 6ms) NEW (ceiling + 60s) after 5ms -> 5400000 PASS The old input drifts by exactly the elapsed time. The new one is exact regardless. The fix also repairs the test's intent The name says the run outlives the ceiling — but a deadline equal to the ceiling isn't outliving it. Raising the deadline past the ceiling fixes the assertion and the intent together, and it's the case actually worth covering: a run whose deadline exceeds the ceiling should be clamped to the ceiling. Derived from PI_SANDBOX_MAX_LIFETIME_MS + 60_000 rather than restating 90 * 60 * 1000, so the test can't silently drift if the async execution ceiling moves — which is exactly how the original hardcoded value came to sit on the boundary. Also drops the old comment's claim that "the provider cap still wins". The provider cap is 24 h, far above the 90 min async ceiling, so the ceiling is what wins — the comment described the opposite of the mechanism. Notes Deliberately not reached for vi.useFakeTimers(). Freezing the clock would mask the boundary rather than fix it, and the assertion would still be testing an input that contradicts the test's name. The sibling assertions in this file that compare against the ceiling (lines 103-104, 145) are safe — they use signals with no deadline, so getRemainingExecutionMs returns undefined and the ceiling is returned unconditionally. Type of Change Bug fix (test correctness / CI flake) Testing Fixed test run 5x, 16/16 passing each time. Mechanism verified directly against the real helpers (output above) rather than inferred from a green run — the old version passed most of the time too, so repetition alone proves nothing here.
Open Graph Description: Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Root ca...
X Description: Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Roo...
Opengraph URL: https://github.com/simstudioai/sim/pull/6082
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:07d27dd1-3bcf-6362-4d9c-f8a8e2478d55 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF92:389441:56D74:7B233:6AFB4459 |
| html-safe-nonce | 8760470705691bd0d5ad55936a658a6ff764da6f1e326eef107c0e739a726b00 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjkyOjM4OTQ0MTo1NkQ3NDo3QjIzMzo2QUZCNDQ1OSIsInZpc2l0b3JfaWQiOiI3NDM5MzY3NTg1OTY0NzA0ODU3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | fb2c61dbff804e0b09df43f2614977e28bcaec198b577c951aad249992082f21 |
| hovercard-subject-tag | pull_request:4165468318 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6082/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary pi-lifetime.test.ts > keeps the ceiling when the run outlives it is flaky. It failed CI tonight as AssertionError: expected 5399999 to be 5400000 — 1 failure out of 16,047 tests. Root ca... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width