| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/commits(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:b5d74c8a-0909-b5f1-4e66-1dd6ea074f3c |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B58E:303206:38C812:51027C:6AFB3965 |
| html-safe-nonce | cf83e6379e6ef3083dd13ac41ab62a16ac8ec90e1c92ce250af165d869098c8e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNThFOjMwMzIwNjozOEM4MTI6NTEwMjdDOjZBRkIzOTY1IiwidmlzaXRvcl9pZCI6IjQzOTkyNjg0MDk2MTk3MjQ2NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 7f1194b63037a452096e2ab0f2b3c65a6120dacba7c8cea2461dc817787e4d93 |
| hovercard-subject-tag | pull_request:4164578857 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/commits |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6065/commits |
| twitter:image | https://opengraph.githubassets.com/c31e522066b1bad8a11738420f965344b5d01502879393a91b379ed395c3a71d/simstudioai/sim/pull/6065 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c31e522066b1bad8a11738420f965344b5d01502879393a91b379ed395c3a71d/simstudioai/sim/pull/6065 |
| og:image:alt | Summary
Ran Vercel's deepsec over the desktop trust boundary and fixed everything it found. 11 findings survived revalidation; all 11 are fixed here.
Scope was three projects, not just apps/des... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | waleedlatif1 |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-cache |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/simstudioai/sim/pull/6065/commits#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6065%2Fcommits |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6065%2Fcommits |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim |
| Reload | https://github.com/simstudioai/sim/pull/6065/commits |
| Reload | https://github.com/simstudioai/sim/pull/6065/commits |
| Reload | https://github.com/simstudioai/sim/pull/6065/commits |
| simstudioai | https://github.com/simstudioai |
| sim | https://github.com/simstudioai/sim |
| Code | https://github.com/simstudioai/sim |
| Issues129 (129) | https://github.com/simstudioai/sim/issues |
| Pull requests199 (199) | https://github.com/simstudioai/sim/pulls |
| Actions | https://github.com/simstudioai/sim/actions |
| Projects | https://github.com/simstudioai/sim/projects |
| Security and quality | https://github.com/simstudioai/sim/security |
| Insights | https://github.com/simstudioai/sim/pulse |
| https://github.com/simstudioai/sim |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| worktree-deepsec-desktop | https://github.com/simstudioai/sim/tree/worktree-deepsec-desktop |
| Conversation | https://github.com/simstudioai/sim/pull/6065 |
| Commits16 (16) | https://github.com/simstudioai/sim/pull/6065/commits |
| Checks | https://github.com/simstudioai/sim/pull/6065/checks |
| Files changed | https://github.com/simstudioai/sim/pull/6065/files |
| fix(desktop): fix 11 security findings from a deepsec scan of the desktop app | https://github.com/simstudioai/sim/pull/6065/commits#top |
| waleedlatif1 | https://github.com/waleedlatif1 |
| staging | https://github.com/simstudioai/sim/tree/staging |
| worktree-deepsec-desktop | https://github.com/simstudioai/sim/tree/worktree-deepsec-desktop |
| fix(desktop): gate terminal writes and user activation on real OS input | https://github.com/simstudioai/sim/pull/6065/commits/a99223d141510ed224d1f62dfa2b6d9354b93043 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| a99223d | https://github.com/simstudioai/sim/pull/6065/commits/a99223d141510ed224d1f62dfa2b6d9354b93043 |
| https://github.com/simstudioai/sim/tree/a99223d141510ed224d1f62dfa2b6d9354b93043 |
| fix(desktop): reclaim tmux run temp directories that outlive their wait window | https://github.com/simstudioai/sim/pull/6065/commits/b0fe9d4b99b5f3b0e4d45d6d132f8ad5d7e35a21 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| b0fe9d4 | https://github.com/simstudioai/sim/pull/6065/commits/b0fe9d4b99b5f3b0e4d45d6d132f8ad5d7e35a21 |
| https://github.com/simstudioai/sim/tree/b0fe9d4b99b5f3b0e4d45d6d132f8ad5d7e35a21 |
| fix(desktop): contain sign-in handoff failures when no window is available | https://github.com/simstudioai/sim/pull/6065/commits/b2cefe28b65a1107761a84aa83cd5074d1c6f32a |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| b2cefe2 | https://github.com/simstudioai/sim/pull/6065/commits/b2cefe28b65a1107761a84aa83cd5074d1c6f32a |
| https://github.com/simstudioai/sim/tree/b2cefe28b65a1107761a84aa83cd5074d1c6f32a |
| fix(desktop): validate manual-update download urls against the scheme allowlist | https://github.com/simstudioai/sim/pull/6065/commits/09b40cb2ede2d14170304a51f4a92f92a4eb08cb |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 09b40cb | https://github.com/simstudioai/sim/pull/6065/commits/09b40cb2ede2d14170304a51f4a92f92a4eb08cb |
| https://github.com/simstudioai/sim/tree/09b40cb2ede2d14170304a51f4a92f92a4eb08cb |
| fix(desktop): scope credential presence grants to the operation proven | https://github.com/simstudioai/sim/pull/6065/commits/73570c716a2b4ed53997d67b7e9659cf28d14941 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 73570c7 | https://github.com/simstudioai/sim/pull/6065/commits/73570c716a2b4ed53997d67b7e9659cf28d14941 |
| https://github.com/simstudioai/sim/tree/73570c716a2b4ed53997d67b7e9659cf28d14941 |
| fix(desktop): DNS-check agent subresources that are readable or execute | https://github.com/simstudioai/sim/pull/6065/commits/9b8df939c57dbb0b1f77d463e0157b516d649b14 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 9b8df93 | https://github.com/simstudioai/sim/pull/6065/commits/9b8df939c57dbb0b1f77d463e0157b516d649b14 |
| https://github.com/simstudioai/sim/tree/9b8df939c57dbb0b1f77d463e0157b516d649b14 |
| fix(desktop): close three credential-disclosure gaps in agent page functions | https://github.com/simstudioai/sim/pull/6065/commits/7782a569d3b3db605f28d9acf9bd709e9dd9320c |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 7782a56 | https://github.com/simstudioai/sim/pull/6065/commits/7782a569d3b3db605f28d9acf9bd709e9dd9320c |
| https://github.com/simstudioai/sim/tree/7782a569d3b3db605f28d9acf9bd709e9dd9320c |
| fix(desktop): hand the panel occlusion frame only to a user-driven renderer | https://github.com/simstudioai/sim/pull/6065/commits/fc9469fca96b6edd07809422a6a5dd334abee866 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| fc9469f | https://github.com/simstudioai/sim/pull/6065/commits/fc9469fca96b6edd07809422a6a5dd334abee866 |
| https://github.com/simstudioai/sim/tree/fc9469fca96b6edd07809422a6a5dd334abee866 |
| fix(desktop): act on adversarial review of the security fixes | https://github.com/simstudioai/sim/pull/6065/commits/c18f4d38e575ee5dc32b46fdb76cdaa3b478fdc6 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| c18f4d3 | https://github.com/simstudioai/sim/pull/6065/commits/c18f4d38e575ee5dc32b46fdb76cdaa3b478fdc6 |
| https://github.com/simstudioai/sim/tree/c18f4d38e575ee5dc32b46fdb76cdaa3b478fdc6 |
| refactor(security): one DNS resolver for every SSRF guard, checking all addresses | https://github.com/simstudioai/sim/pull/6065/commits/042db18a21b6920843cc3a06dddd26e6e24237ce |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 042db18 | https://github.com/simstudioai/sim/pull/6065/commits/042db18a21b6920843cc3a06dddd26e6e24237ce |
| https://github.com/simstudioai/sim/tree/042db18a21b6920843cc3a06dddd26e6e24237ce |
| fix(security): filter refused DNS records instead of failing the host | https://github.com/simstudioai/sim/pull/6065/commits/a155f93c6fe5b67a2e473eb2c5e2d45c421f1326 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| a155f93 | https://github.com/simstudioai/sim/pull/6065/commits/a155f93c6fe5b67a2e473eb2c5e2d45c421f1326 |
| https://github.com/simstudioai/sim/tree/a155f93c6fe5b67a2e473eb2c5e2d45c421f1326 |
| fix(desktop): invert the terminal-write gate, and finish the XHTML normalization | https://github.com/simstudioai/sim/pull/6065/commits/592c067df68bf6ac1628090b5d525b8c8b80a11e |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 592c067 | https://github.com/simstudioai/sim/pull/6065/commits/592c067df68bf6ac1628090b5d525b8c8b80a11e |
| https://github.com/simstudioai/sim/tree/592c067df68bf6ac1628090b5d525b8c8b80a11e |
| refactor(desktop): simplify what the security fixes added | https://github.com/simstudioai/sim/pull/6065/commits/96346a2f6e953b31bd516cbecd40a6235bc31af4 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 96346a2 | https://github.com/simstudioai/sim/pull/6065/commits/96346a2f6e953b31bd516cbecd40a6235bc31af4 |
| https://github.com/simstudioai/sim/tree/96346a2f6e953b31bd516cbecd40a6235bc31af4 |
| docs(desktop): correct comments that no longer match the code | https://github.com/simstudioai/sim/pull/6065/commits/d0a6eb96952048cee97e19d9195454ca35a2fedb |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| d0a6eb9 | https://github.com/simstudioai/sim/pull/6065/commits/d0a6eb96952048cee97e19d9195454ca35a2fedb |
| https://github.com/simstudioai/sim/tree/d0a6eb96952048cee97e19d9195454ca35a2fedb |
| fix(desktop): stop a command riding inside a fake PTY reply, and fail closed in XHTML | https://github.com/simstudioai/sim/pull/6065/commits/708dbb3ba5aff1f5bdf3b4746209c0175c6aad82 |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 708dbb3 | https://github.com/simstudioai/sim/pull/6065/commits/708dbb3ba5aff1f5bdf3b4746209c0175c6aad82 |
| https://github.com/simstudioai/sim/tree/708dbb3ba5aff1f5bdf3b4746209c0175c6aad82 |
| fix(desktop): paste from main, and stop a reclaimed run dir printing into tmux | https://github.com/simstudioai/sim/pull/6065/commits/7712e09dd743bfa1917070c5178ece48dd7e8d6a |
| https://github.com/waleedlatif1 |
| waleedlatif1 | https://github.com/simstudioai/sim/commits?author=waleedlatif1 |
| 7712e09 | https://github.com/simstudioai/sim/pull/6065/commits/7712e09dd743bfa1917070c5178ece48dd7e8d6a |
| https://github.com/simstudioai/sim/tree/7712e09dd743bfa1917070c5178ece48dd7e8d6a |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |