René's URL Explorer Experiment


Title: fix(desktop): fix 11 security findings from a deepsec scan of the desktop app by waleedlatif1 · Pull Request #6065 · simstudioai/sim · GitHub

Open Graph Title: fix(desktop): fix 11 security findings from a deepsec scan of the desktop app by waleedlatif1 · Pull Request #6065 · simstudioai/sim

X Title: fix(desktop): fix 11 security findings from a deepsec scan of the desktop app by waleedlatif1 · Pull Request #6065 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - fix(desktop): fix 11 security findings from a deepsec scan of the desktop app by waleedlatif1 · Pull Request #6065 · simstudioai/sim

Open Graph Description: Summary Ran Vercel's deepsec over the desktop trust boundary and fixed everything it found. 11 findings survived revalidation; all 11 are fixed here. Scope was three projects, not just apps/des...

X Description: Summary Ran Vercel's deepsec over the desktop trust boundary and fixed everything it found. 11 findings survived revalidation; all 11 are fixed here. Scope was three projects, not just apps...

Opengraph URL: https://github.com/simstudioai/sim/pull/6065

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:b5d74c8a-0909-b5f1-4e66-1dd6ea074f3c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB58E:303206:38C812:51027C:6AFB3965
html-safe-noncecf83e6379e6ef3083dd13ac41ab62a16ac8ec90e1c92ce250af165d869098c8e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNThFOjMwMzIwNjozOEM4MTI6NTEwMjdDOjZBRkIzOTY1IiwidmlzaXRvcl9pZCI6IjQzOTkyNjg0MDk2MTk3MjQ2NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac7f1194b63037a452096e2ab0f2b3c65a6120dacba7c8cea2461dc817787e4d93
hovercard-subject-tagpull_request:4164578857
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6065/commits
twitter:imagehttps://opengraph.githubassets.com/c31e522066b1bad8a11738420f965344b5d01502879393a91b379ed395c3a71d/simstudioai/sim/pull/6065
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c31e522066b1bad8a11738420f965344b5d01502879393a91b379ed395c3a71d/simstudioai/sim/pull/6065
og:image:altSummary Ran Vercel's deepsec over the desktop trust boundary and fixed everything it found. 11 findings survived revalidation; all 11 are fixed here. Scope was three projects, not just apps/des...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6065/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6065%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6065%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6065/commits
Reloadhttps://github.com/simstudioai/sim/pull/6065/commits
Reloadhttps://github.com/simstudioai/sim/pull/6065/commits
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-deepsec-desktophttps://github.com/simstudioai/sim/tree/worktree-deepsec-desktop
Conversationhttps://github.com/simstudioai/sim/pull/6065
Commits16 (16)https://github.com/simstudioai/sim/pull/6065/commits
Checkshttps://github.com/simstudioai/sim/pull/6065/checks
Files changedhttps://github.com/simstudioai/sim/pull/6065/files
fix(desktop): fix 11 security findings from a deepsec scan of the desktop apphttps://github.com/simstudioai/sim/pull/6065/commits#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-deepsec-desktophttps://github.com/simstudioai/sim/tree/worktree-deepsec-desktop
fix(desktop): gate terminal writes and user activation on real OS inputhttps://github.com/simstudioai/sim/pull/6065/commits/a99223d141510ed224d1f62dfa2b6d9354b93043
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
a99223dhttps://github.com/simstudioai/sim/pull/6065/commits/a99223d141510ed224d1f62dfa2b6d9354b93043
https://github.com/simstudioai/sim/tree/a99223d141510ed224d1f62dfa2b6d9354b93043
fix(desktop): reclaim tmux run temp directories that outlive their wait windowhttps://github.com/simstudioai/sim/pull/6065/commits/b0fe9d4b99b5f3b0e4d45d6d132f8ad5d7e35a21
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b0fe9d4https://github.com/simstudioai/sim/pull/6065/commits/b0fe9d4b99b5f3b0e4d45d6d132f8ad5d7e35a21
https://github.com/simstudioai/sim/tree/b0fe9d4b99b5f3b0e4d45d6d132f8ad5d7e35a21
fix(desktop): contain sign-in handoff failures when no window is availablehttps://github.com/simstudioai/sim/pull/6065/commits/b2cefe28b65a1107761a84aa83cd5074d1c6f32a
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b2cefe2https://github.com/simstudioai/sim/pull/6065/commits/b2cefe28b65a1107761a84aa83cd5074d1c6f32a
https://github.com/simstudioai/sim/tree/b2cefe28b65a1107761a84aa83cd5074d1c6f32a
fix(desktop): validate manual-update download urls against the scheme allowlisthttps://github.com/simstudioai/sim/pull/6065/commits/09b40cb2ede2d14170304a51f4a92f92a4eb08cb
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
09b40cbhttps://github.com/simstudioai/sim/pull/6065/commits/09b40cb2ede2d14170304a51f4a92f92a4eb08cb
https://github.com/simstudioai/sim/tree/09b40cb2ede2d14170304a51f4a92f92a4eb08cb
fix(desktop): scope credential presence grants to the operation provenhttps://github.com/simstudioai/sim/pull/6065/commits/73570c716a2b4ed53997d67b7e9659cf28d14941
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
73570c7https://github.com/simstudioai/sim/pull/6065/commits/73570c716a2b4ed53997d67b7e9659cf28d14941
https://github.com/simstudioai/sim/tree/73570c716a2b4ed53997d67b7e9659cf28d14941
fix(desktop): DNS-check agent subresources that are readable or executehttps://github.com/simstudioai/sim/pull/6065/commits/9b8df939c57dbb0b1f77d463e0157b516d649b14
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
9b8df93https://github.com/simstudioai/sim/pull/6065/commits/9b8df939c57dbb0b1f77d463e0157b516d649b14
https://github.com/simstudioai/sim/tree/9b8df939c57dbb0b1f77d463e0157b516d649b14
fix(desktop): close three credential-disclosure gaps in agent page functionshttps://github.com/simstudioai/sim/pull/6065/commits/7782a569d3b3db605f28d9acf9bd709e9dd9320c
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
7782a56https://github.com/simstudioai/sim/pull/6065/commits/7782a569d3b3db605f28d9acf9bd709e9dd9320c
https://github.com/simstudioai/sim/tree/7782a569d3b3db605f28d9acf9bd709e9dd9320c
fix(desktop): hand the panel occlusion frame only to a user-driven rendererhttps://github.com/simstudioai/sim/pull/6065/commits/fc9469fca96b6edd07809422a6a5dd334abee866
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
fc9469fhttps://github.com/simstudioai/sim/pull/6065/commits/fc9469fca96b6edd07809422a6a5dd334abee866
https://github.com/simstudioai/sim/tree/fc9469fca96b6edd07809422a6a5dd334abee866
fix(desktop): act on adversarial review of the security fixeshttps://github.com/simstudioai/sim/pull/6065/commits/c18f4d38e575ee5dc32b46fdb76cdaa3b478fdc6
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
c18f4d3https://github.com/simstudioai/sim/pull/6065/commits/c18f4d38e575ee5dc32b46fdb76cdaa3b478fdc6
https://github.com/simstudioai/sim/tree/c18f4d38e575ee5dc32b46fdb76cdaa3b478fdc6
refactor(security): one DNS resolver for every SSRF guard, checking all addresseshttps://github.com/simstudioai/sim/pull/6065/commits/042db18a21b6920843cc3a06dddd26e6e24237ce
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
042db18https://github.com/simstudioai/sim/pull/6065/commits/042db18a21b6920843cc3a06dddd26e6e24237ce
https://github.com/simstudioai/sim/tree/042db18a21b6920843cc3a06dddd26e6e24237ce
fix(security): filter refused DNS records instead of failing the hosthttps://github.com/simstudioai/sim/pull/6065/commits/a155f93c6fe5b67a2e473eb2c5e2d45c421f1326
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
a155f93https://github.com/simstudioai/sim/pull/6065/commits/a155f93c6fe5b67a2e473eb2c5e2d45c421f1326
https://github.com/simstudioai/sim/tree/a155f93c6fe5b67a2e473eb2c5e2d45c421f1326
fix(desktop): invert the terminal-write gate, and finish the XHTML normalizationhttps://github.com/simstudioai/sim/pull/6065/commits/592c067df68bf6ac1628090b5d525b8c8b80a11e
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
592c067https://github.com/simstudioai/sim/pull/6065/commits/592c067df68bf6ac1628090b5d525b8c8b80a11e
https://github.com/simstudioai/sim/tree/592c067df68bf6ac1628090b5d525b8c8b80a11e
refactor(desktop): simplify what the security fixes addedhttps://github.com/simstudioai/sim/pull/6065/commits/96346a2f6e953b31bd516cbecd40a6235bc31af4
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
96346a2https://github.com/simstudioai/sim/pull/6065/commits/96346a2f6e953b31bd516cbecd40a6235bc31af4
https://github.com/simstudioai/sim/tree/96346a2f6e953b31bd516cbecd40a6235bc31af4
docs(desktop): correct comments that no longer match the codehttps://github.com/simstudioai/sim/pull/6065/commits/d0a6eb96952048cee97e19d9195454ca35a2fedb
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
d0a6eb9https://github.com/simstudioai/sim/pull/6065/commits/d0a6eb96952048cee97e19d9195454ca35a2fedb
https://github.com/simstudioai/sim/tree/d0a6eb96952048cee97e19d9195454ca35a2fedb
fix(desktop): stop a command riding inside a fake PTY reply, and fail closed in XHTMLhttps://github.com/simstudioai/sim/pull/6065/commits/708dbb3ba5aff1f5bdf3b4746209c0175c6aad82
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
708dbb3https://github.com/simstudioai/sim/pull/6065/commits/708dbb3ba5aff1f5bdf3b4746209c0175c6aad82
https://github.com/simstudioai/sim/tree/708dbb3ba5aff1f5bdf3b4746209c0175c6aad82
fix(desktop): paste from main, and stop a reclaimed run dir printing into tmuxhttps://github.com/simstudioai/sim/pull/6065/commits/7712e09dd743bfa1917070c5178ece48dd7e8d6a
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
7712e09https://github.com/simstudioai/sim/pull/6065/commits/7712e09dd743bfa1917070c5178ece48dd7e8d6a
https://github.com/simstudioai/sim/tree/7712e09dd743bfa1917070c5178ece48dd7e8d6a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.