René's URL Explorer Experiment


Title: docs(folders): correct four comments that claimed more than the code does by waleedlatif1 · Pull Request #6063 · simstudioai/sim · GitHub

Open Graph Title: docs(folders): correct four comments that claimed more than the code does by waleedlatif1 · Pull Request #6063 · simstudioai/sim

X Title: docs(folders): correct four comments that claimed more than the code does by waleedlatif1 · Pull Request #6063 · simstudioai/sim

Description: Follow-up to #6062, which merged before these landed. A comment-accuracy pass over that branch found four factual errors — all mine, all introduced in #6062 — plus some comments that restated the code. This matters beyond tidiness: in the folder migration work, comments asserting more than the code delivered were the single most recurring defect. A comment that documents a guarantee the code does not provide is worse than no comment, because the next reader trusts it. The four inaccuracies 1. Reasoning copied to a place it doesn't apply. route.test.ts justified its column-pinned assertion with "resourceType/workspaceId are eq nodes, so a bare 'some isNull exists' check could pass on an unrelated clause." That reasoning is true in lifecycle.test.ts — where a root folder's isNull(parentId) genuinely makes a presence-only check vacuous — but this route's condition has no second isNull node, so the stated failure cannot occur. Replaced with the reason that is actually true here (future-proofing against a nullable filter being added). 2. "Every clause mirrors one column of the partial unique index" — wrong on two counts: deletedAt is the index predicate, not an indexed column, and name is an indexed column with no clause (it's filtered in JS). 3. "Optimistic client reparents can write one" (about a pre-existing folder cycle) — unsupported. wouldCreateFolderCycle has exactly one caller and no write path bypasses it, so a client reparent cannot land a cycle. The realistic origin is two concurrent reparents each passing the check independently. 4. "restoreFolder runs its restoreChildren hook BEFORE un-archiving the folder rows" — true only for the injected hook path. The in-transaction fallback restoreFolderChildren runs after restoreFolderRows, so the claim covered one of two paths. Also Trims comments that restated the code or duplicated a TSDoc block on the module under test (the admin route's rationale lives in the route; toFolderApi's lives in queries.ts), and drops two lines of narration about this work's own history. Pins three presence-only isNull assertions to the deletedAt column. They were not vacuous today — each of those conditions happens to contain only one isNull — but that is incidental, and it is exactly the fragility that already made one assertion in this suite vacuous. Mutation-checked: dropping isNull(folder.deletedAt) from findActiveFolder now fails the test, which it would not have before. Testing Typecheck, lint:check (23/23), check:api-validation, and 107 tests pass. No behavioural change to product code — the only non-comment edits are test assertions being tightened. Type of Change Chore / docs Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Follow-up to #6062, which merged before these landed. A comment-accuracy pass over that branch found four factual errors — all mine, all introduced in #6062 — plus some comments that restated the c...

X Description: Follow-up to #6062, which merged before these landed. A comment-accuracy pass over that branch found four factual errors — all mine, all introduced in #6062 — plus some comments that restated the c...

Opengraph URL: https://github.com/simstudioai/sim/pull/6063

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f0d7105c-bf57-a883-15d4-e82c2334e87d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA552:1BB96C:53A3B1:7362BE:6AFB3BC7
html-safe-nonce5510d3fad826e24feebdfabb434ee29724c7077c82eaf1a6ab18156a00c8bbd2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTUyOjFCQjk2Qzo1M0EzQjE6NzM2MkJFOjZBRkIzQkM3IiwidmlzaXRvcl9pZCI6IjYwNzA2ODIyNzg5MTQ4OTg4ODciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac68aba40d52e8c77f53ec9974c929e29a39eb298873b06b66ff9a36b034331a90
hovercard-subject-tagpull_request:4164412896
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6063/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFollow-up to #6062, which merged before these landed. A comment-accuracy pass over that branch found four factual errors — all mine, all introduced in #6062 — plus some comments that restated the c...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6063/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6063%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6063%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6063/files
Reloadhttps://github.com/simstudioai/sim/pull/6063/files
Reloadhttps://github.com/simstudioai/sim/pull/6063/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/folder-comment-accuracyhttps://github.com/simstudioai/sim/tree/fix/folder-comment-accuracy
Conversation 5 https://github.com/simstudioai/sim/pull/6063
Commits 1 https://github.com/simstudioai/sim/pull/6063/commits
Checks 26 https://github.com/simstudioai/sim/pull/6063/checks
Files changed https://github.com/simstudioai/sim/pull/6063/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6063/files
docs(folders): correct four comments that claimed more than the code does https://github.com/simstudioai/sim/pull/6063/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6063/files
dd27264 docs(folders): correct four comments that claimed more than the code … waleedlatif1 Jul 29, 2026 https://github.com/simstudioai/sim/pull/6063/commits/dd27264ce81eeda2ecf11c02e54756e7873f0c0d
Clear filters https://github.com/simstudioai/sim/pull/6063/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6063/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6063/files
route.test.ts https://github.com/simstudioai/sim/pull/6063/files#diff-ac70c41477e3642a78a1876d9ce65bb5c64ad69ec9d02412e08dca3233a41118
route.ts https://github.com/simstudioai/sim/pull/6063/files#diff-d0a542f9126d529917e6fabcbf06ea33e920ce0894b241fdbe17f7a0203acfc8
lifecycle.test.ts https://github.com/simstudioai/sim/pull/6063/files#diff-a8f1c3f618fff6b4625c421c4caf8d379702418c6861611522540397576ef154
lifecycle.ts https://github.com/simstudioai/sim/pull/6063/files#diff-5549871eaa1033ce9ab06110a45243e09b010842207b25b9bffeaefb843e53ba
naming.test.ts https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
queries.test.ts https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
apps/sim/app/api/v1/admin/workspaces/[id]/folders/route.test.tshttps://github.com/simstudioai/sim/pull/6063/files#diff-ac70c41477e3642a78a1876d9ce65bb5c64ad69ec9d02412e08dca3233a41118
View file https://github.com/simstudioai/sim/blob/dd27264ce81eeda2ecf11c02e54756e7873f0c0d/apps/sim/app/api/v1/admin/workspaces/%5Bid%5D/folders/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6063/files#diff-ac70c41477e3642a78a1876d9ce65bb5c64ad69ec9d02412e08dca3233a41118
https://github.com/simstudioai/sim/pull/6063/files#diff-ac70c41477e3642a78a1876d9ce65bb5c64ad69ec9d02412e08dca3233a41118
https://github.com/simstudioai/sim/pull/6063/files#diff-ac70c41477e3642a78a1876d9ce65bb5c64ad69ec9d02412e08dca3233a41118
apps/sim/app/api/v1/admin/workspaces/[id]/folders/route.tshttps://github.com/simstudioai/sim/pull/6063/files#diff-d0a542f9126d529917e6fabcbf06ea33e920ce0894b241fdbe17f7a0203acfc8
View file https://github.com/simstudioai/sim/blob/dd27264ce81eeda2ecf11c02e54756e7873f0c0d/apps/sim/app/api/v1/admin/workspaces/%5Bid%5D/folders/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6063/files#diff-d0a542f9126d529917e6fabcbf06ea33e920ce0894b241fdbe17f7a0203acfc8
https://github.com/simstudioai/sim/pull/6063/files#diff-d0a542f9126d529917e6fabcbf06ea33e920ce0894b241fdbe17f7a0203acfc8
apps/sim/lib/folders/lifecycle.test.tshttps://github.com/simstudioai/sim/pull/6063/files#diff-a8f1c3f618fff6b4625c421c4caf8d379702418c6861611522540397576ef154
View file https://github.com/simstudioai/sim/blob/dd27264ce81eeda2ecf11c02e54756e7873f0c0d/apps/sim/lib/folders/lifecycle.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6063/files#diff-a8f1c3f618fff6b4625c421c4caf8d379702418c6861611522540397576ef154
https://github.com/simstudioai/sim/pull/6063/files#diff-a8f1c3f618fff6b4625c421c4caf8d379702418c6861611522540397576ef154
https://github.com/simstudioai/sim/pull/6063/files#diff-a8f1c3f618fff6b4625c421c4caf8d379702418c6861611522540397576ef154
apps/sim/lib/folders/lifecycle.tshttps://github.com/simstudioai/sim/pull/6063/files#diff-5549871eaa1033ce9ab06110a45243e09b010842207b25b9bffeaefb843e53ba
View file https://github.com/simstudioai/sim/blob/dd27264ce81eeda2ecf11c02e54756e7873f0c0d/apps/sim/lib/folders/lifecycle.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6063/files#diff-5549871eaa1033ce9ab06110a45243e09b010842207b25b9bffeaefb843e53ba
https://github.com/simstudioai/sim/pull/6063/files#diff-5549871eaa1033ce9ab06110a45243e09b010842207b25b9bffeaefb843e53ba
apps/sim/lib/folders/naming.test.tshttps://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
View file https://github.com/simstudioai/sim/blob/dd27264ce81eeda2ecf11c02e54756e7873f0c0d/apps/sim/lib/folders/naming.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
https://github.com/simstudioai/sim/pull/6063/files#diff-94f7c81f9d07b56bd1ed6d0f34268c741c9b4cdd9a5d1d5e7717369b1b82b630
apps/sim/lib/folders/queries.test.tshttps://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
View file https://github.com/simstudioai/sim/blob/dd27264ce81eeda2ecf11c02e54756e7873f0c0d/apps/sim/lib/folders/queries.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6063/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
https://github.com/simstudioai/sim/pull/6063/files#diff-76c466bd8dd934f65570b800c2e539a2e034da449727b0a9c354c0e259c8dea2
Please reload this pagehttps://github.com/simstudioai/sim/pull/6063/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.