Title: fix(connectors): resolve SharePoint folder paths against the right document library by waleedlatif1 · Pull Request #6026 · simstudioai/sim · GitHub
Open Graph Title: fix(connectors): resolve SharePoint folder paths against the right document library by waleedlatif1 · Pull Request #6026 · simstudioai/sim
X Title: fix(connectors): resolve SharePoint folder paths against the right document library by waleedlatif1 · Pull Request #6026 · simstudioai/sim
Description: Summary Folder-scoped SharePoint connectors failed with Folder not found for folders that exist and are readable with the same credential — whole-library sync was the only working option Resolve the target drive explicitly and thread it through listing, download and hydration, which all previously hardcoded the site's default library Resolve folder paths in layers: byte-exact addressing first (unchanged from today), then a leading document-library name, then a normalized children walk that recovers names carrying non-breaking or invisible whitespace Accept a folder URL pasted from the browser address bar Report the site, library, attempted path and existing folder names on failure instead of a bare Folder not found Document the expected folder path format in the connector schema — the old placeholder (Documents/Reports) taught a form that can never resolve, since root: is already the library root Notes on compatibility Exact path addressing runs first and is byte-identical to the current request, so any configuration that resolves today resolves to the same item. The new layers only run on a path that already 404'd — covered by a test asserting a real folder named Documents still wins over the library-name interpretation The default drive is resolved via GET /sites/{siteId}/drive (the documented default library), not drives[0], whose ordering is not guaranteed — so item.id is unchanged and no documents are re-indexed No scope change: Sites.Read.All covers every endpoint used. Tokenized /:f:/ sharing links are deliberately not supported — resolving them requires /shares, which needs write scopes this connector should not hold Pagination cursors are per-run and never persisted (sync-engine.ts), so the cursor state change has no upgrade surface Type of Change Bug fix Testing 22 unit tests against a mocked Graph covering exact paths, leading/trailing slashes, nested folders, Documents/Shared Documents prefixes, non-default libraries, non-breaking-space and case recovery, ambiguity rejection, address-bar URLs, sharing-link rejection, and the diagnostic error contents. Full connector suite (468 tests) passes. Not verified against a live tenant. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Folder-scoped SharePoint connectors failed with Folder not found for folders that exist and are readable with the same credential — whole-library sync was the only working option Resolve t...
X Description: Summary Folder-scoped SharePoint connectors failed with Folder not found for folders that exist and are readable with the same credential — whole-library sync was the only working option Resolve t...
Opengraph URL: https://github.com/simstudioai/sim/pull/6026
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:264a4e3e-1582-d0de-95dd-7dcf34d7925b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DD2E:7D93E:70C119:9B6583:6AFB4331 |
| html-safe-nonce | 8b6bc0ac7775595ef45cac8bbd7bed9f06ebab4851f0612a1468fd339e06472a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERDJFOjdEOTNFOjcwQzExOTo5QjY1ODM6NkFGQjQzMzEiLCJ2aXNpdG9yX2lkIjoiNjM1NTAxOTAwOTUxNDc1MDc2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e7aefedaafbf6d884cfb95a93e717b3e9fb15cce86d100a5418dfab7c175b0e7 |
| hovercard-subject-tag | pull_request:4155782665 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6026/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Folder-scoped SharePoint connectors failed with Folder not found for folders that exist and are readable with the same credential — whole-library sync was the only working option Resolve t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width