René's URL Explorer Experiment


Title: fix(knowledge): resolve connector tokens as the credential owner, not the KB owner by waleedlatif1 · Pull Request #6024 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): resolve connector tokens as the credential owner, not the KB owner by waleedlatif1 · Pull Request #6024 · simstudioai/sim

X Title: fix(knowledge): resolve connector tokens as the credential owner, not the KB owner by waleedlatif1 · Pull Request #6024 · simstudioai/sim

Description: Summary KB connector syncs resolved OAuth tokens as the knowledge base owner. Token reads are scoped to account.userId, so a shared workspace credential authorized by a different member resolved no token at all — surfacing as Failed to obtain access token for credential X (provider: confluence) Added resolveCredentialTokenIdentity and used it in the sync engine and the connector PATCH route, matching how authorizeCredentialUse (65 request-bound routes) and getCredentialOwner (webhooks + subscription-renewal cron) already resolve credentials Connectors were the only module in the app treating resource ownership as credential ownership Also scopes the credential to the KB's workspace and requires its owner to still have workspace access; service-account credentials pass through unchanged since they mint their own token and ignore the acting user Reported from a live workspace: the KB was owned by one member while the Confluence credential was authorized by another, so every sync failed and swapping service accounts couldn't help. Type of Change Bug fix Testing Verified against production data: all 102 existing credential-backed connectors resolve to the same user before and after this change, so it is a no-op for every current connector and only alters the already-broken case. Also confirmed zero connectors would be newly rejected by the added workspace/permission guards, and zero use service-account credentials. 830 tests passing across credentials/oauth/webhooks (9 new), typecheck clean, check:api-validation passing. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary KB connector syncs resolved OAuth tokens as the knowledge base owner. Token reads are scoped to account.userId, so a shared workspace credential authorized by a different member resolved n...

X Description: Summary KB connector syncs resolved OAuth tokens as the knowledge base owner. Token reads are scoped to account.userId, so a shared workspace credential authorized by a different member resolved n...

Opengraph URL: https://github.com/simstudioai/sim/pull/6024

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:279645c6-0e7e-8b2c-0c7d-a3ac4930dfb5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA566:18732E:70027E:9AC617:6AFB431C
html-safe-nonce2b04610cdc4d85e33c7dcd140922616b5b7c979c6f6f4b5a828fcf5820d21a9a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNTY2OjE4NzMyRTo3MDAyN0U6OUFDNjE3OjZBRkI0MzFDIiwidmlzaXRvcl9pZCI6IjY3NjkyNDY3MzA5NDU1MTIyMjAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9d9e2b3da35ecfb784a5fb3bde56184aa97a5cddc068d8bc424f68988e560768
hovercard-subject-tagpull_request:4155740110
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6024/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary KB connector syncs resolved OAuth tokens as the knowledge base owner. Token reads are scoped to account.userId, so a shared workspace credential authorized by a different member resolved n...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6024/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6024%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6024%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6024/files
Reloadhttps://github.com/simstudioai/sim/pull/6024/files
Reloadhttps://github.com/simstudioai/sim/pull/6024/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-confluence-cred-tokenhttps://github.com/simstudioai/sim/tree/worktree-confluence-cred-token
Conversation 7 https://github.com/simstudioai/sim/pull/6024
Commits 1 https://github.com/simstudioai/sim/pull/6024/commits
Checks 19 https://github.com/simstudioai/sim/pull/6024/checks
Files changed https://github.com/simstudioai/sim/pull/6024/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6024/files
fix(knowledge): resolve connector tokens as the credential owner, not the KB owner https://github.com/simstudioai/sim/pull/6024/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6024/files
3f89cce fix(knowledge): resolve connector tokens as the credential owner, not… waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/6024/commits/3f89cce141503c1282c90738f2bea42fef349def
Clear filters https://github.com/simstudioai/sim/pull/6024/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6024/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6024/files
route.ts https://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
add-connector-modal.tsx https://github.com/simstudioai/sim/pull/6024/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
access.test.ts https://github.com/simstudioai/sim/pull/6024/files#diff-21f0c71e582953b325d308c9f7f2f1e2a29dbbeb4c3851f16d9cdc5a4426c2e2
access.ts https://github.com/simstudioai/sim/pull/6024/files#diff-cc3a3524519fba749906993a783577c1dd22d45169bfea43ab74dc3dfaba896a
sync-engine.ts https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
apps/sim/app/api/knowledge/[id]/connectors/[connectorId]/route.tshttps://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
View file https://github.com/simstudioai/sim/blob/3f89cce141503c1282c90738f2bea42fef349def/apps/sim/app/api/knowledge/%5Bid%5D/connectors/%5BconnectorId%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6024/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
https://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
https://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
https://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
https://github.com/simstudioai/sim/pull/6024/files#diff-1123ed11307562c4f018c51d26a42b13f893f6351dbda1a01bfb6213179697ea
...space/[workspaceId]/knowledge/[id]/components/add-connector-modal/add-connector-modal.tsxhttps://github.com/simstudioai/sim/pull/6024/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
View file https://github.com/simstudioai/sim/blob/3f89cce141503c1282c90738f2bea42fef349def/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/%5Bid%5D/components/add-connector-modal/add-connector-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6024/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6024/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
https://github.com/simstudioai/sim/pull/6024/files#diff-8f2e14ad1c9db96a6e7a2ca44932172a76725be95a85d2fcd2601f597ec3b8b6
apps/sim/lib/credentials/access.test.tshttps://github.com/simstudioai/sim/pull/6024/files#diff-21f0c71e582953b325d308c9f7f2f1e2a29dbbeb4c3851f16d9cdc5a4426c2e2
View file https://github.com/simstudioai/sim/blob/3f89cce141503c1282c90738f2bea42fef349def/apps/sim/lib/credentials/access.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6024/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6024/files#diff-21f0c71e582953b325d308c9f7f2f1e2a29dbbeb4c3851f16d9cdc5a4426c2e2
https://github.com/simstudioai/sim/pull/6024/files#diff-21f0c71e582953b325d308c9f7f2f1e2a29dbbeb4c3851f16d9cdc5a4426c2e2
apps/sim/lib/credentials/access.tshttps://github.com/simstudioai/sim/pull/6024/files#diff-cc3a3524519fba749906993a783577c1dd22d45169bfea43ab74dc3dfaba896a
View file https://github.com/simstudioai/sim/blob/3f89cce141503c1282c90738f2bea42fef349def/apps/sim/lib/credentials/access.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6024/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6024/files#diff-cc3a3524519fba749906993a783577c1dd22d45169bfea43ab74dc3dfaba896a
https://github.com/simstudioai/sim/pull/6024/files#diff-cc3a3524519fba749906993a783577c1dd22d45169bfea43ab74dc3dfaba896a
apps/sim/lib/knowledge/connectors/sync-engine.tshttps://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
View file https://github.com/simstudioai/sim/blob/3f89cce141503c1282c90738f2bea42fef349def/apps/sim/lib/knowledge/connectors/sync-engine.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6024/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
https://github.com/simstudioai/sim/pull/6024/files#diff-277f76464f02682e44e6de58ebd215c927f0f6a3a7165af669a0717b593790e9
Please reload this pagehttps://github.com/simstudioai/sim/pull/6024/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.