René's URL Explorer Experiment


Title: fix(files): count the document body against the export limit by waleedlatif1 · Pull Request #6006 · simstudioai/sim · GitHub

Open Graph Title: fix(files): count the document body against the export limit by waleedlatif1 · Pull Request #6006 · simstudioai/sim

X Title: fix(files): count the document body against the export limit by waleedlatif1 · Pull Request #6006 · simstudioai/sim

Description: Follow-up to #5995, from Bugbot's finding on the v0.7.47 release PR (#6005). Summary The 250 MB markdown-export cap measured only the embedded assets' declared sizes. The document body was downloaded with no limit and never counted, so a large document with modest attachments cleared the check and still produced a zip well over the stated limit, materialized whole in memory The body is the largest single entry in most bundles, so excluding it left the limit unenforced against the item most able to exceed it It is now capped on read and counted alongside its assets, and the message names both Provenance #5995 added the asset caps but did not extend them to the body. The unbounded body read predates that PR; what #5995 introduced was an export limit that silently excluded the largest item — so this closes a gap it created rather than an unrelated defect. Type of Change Bug fix Testing Two tests added to the suite #5995 introduced: the body counting toward the limit when assets alone sit under it, and the body read carrying the cap. Seven tests on this route pass; lint, check:utils, typecheck and check:api-validation clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Follow-up to #5995, from Bugbot's finding on the v0.7.47 release PR (#6005). Summary The 250 MB markdown-export cap measured only the embedded assets' declared sizes. The document body was...

X Description: Follow-up to #5995, from Bugbot's finding on the v0.7.47 release PR (#6005). Summary The 250 MB markdown-export cap measured only the embedded assets' declared sizes. The document ...

Opengraph URL: https://github.com/simstudioai/sim/pull/6006

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8a43517f-8cd8-d4cb-7493-84cd85d9caa7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6A4:3020C5:94322:D444F:6AFB456A
html-safe-nonce0ebf1bd5668915b2071dd4d24f189993b133bf0b8d9b4ce4dd7453ee2314bdb0
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkE0OjMwMjBDNTo5NDMyMjpENDQ0Rjo2QUZCNDU2QSIsInZpc2l0b3JfaWQiOiI4MDM4NzQ3NTY3OTU0ODA2MTIyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdc983b2139db1dfb2baa10d70a9809be5a3d51a4145eee6f6c64e22278746594
hovercard-subject-tagpull_request:4153716660
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6006/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altFollow-up to #5995, from Bugbot's finding on the v0.7.47 release PR (#6005). Summary The 250 MB markdown-export cap measured only the embedded assets' declared sizes. The document body was...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6006/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6006%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6006%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6006/files
Reloadhttps://github.com/simstudioai/sim/pull/6006/files
Reloadhttps://github.com/simstudioai/sim/pull/6006/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/export-count-markdown-bodyhttps://github.com/simstudioai/sim/tree/fix/export-count-markdown-body
Conversation 13 https://github.com/simstudioai/sim/pull/6006
Commits 4 https://github.com/simstudioai/sim/pull/6006/commits
Checks 19 https://github.com/simstudioai/sim/pull/6006/checks
Files changed https://github.com/simstudioai/sim/pull/6006/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6006/files
fix(files): count the document body against the export limit https://github.com/simstudioai/sim/pull/6006/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/6006/files
fc2ded7 fix(files): count the document body against the export limit waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/6006/commits/fc2ded7425387d097e59819dda55a90580a2c8a6
f16e140 test(v1): cover the file download's rendered-bytes behavior waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/6006/commits/f16e140ea33d52498794be4ef6cceadc026b9b52
b7f6acd fix(files): report an oversized document body as a size rejection waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/6006/commits/b7f6acd15b8a607a0052063ebc1f2aa380694168
6950e22 chore(files): drop the unreachable export asset-count cap waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/6006/commits/6950e22032ae22966933b98e4b4a72b63fa84de5
Clear filters https://github.com/simstudioai/sim/pull/6006/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6006/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6006/files
route.test.ts https://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
route.ts https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
route.test.ts https://github.com/simstudioai/sim/pull/6006/files#diff-b54b227a4f0056aeb3cd9a452ee2a7d12c3e842546e584932a2adef27f5cb97c
apps/sim/app/api/files/export/[id]/route.test.tshttps://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
View file https://github.com/simstudioai/sim/blob/6950e22032ae22966933b98e4b4a72b63fa84de5/apps/sim/app/api/files/export/%5Bid%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6006/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
https://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
https://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
https://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
https://github.com/simstudioai/sim/pull/6006/files#diff-cd591b0264baee291a708160d8122658c9999b7e32f09d74b0908bcd874e96fb
apps/sim/app/api/files/export/[id]/route.tshttps://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
View file https://github.com/simstudioai/sim/blob/6950e22032ae22966933b98e4b4a72b63fa84de5/apps/sim/app/api/files/export/%5Bid%5D/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6006/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
https://github.com/simstudioai/sim/pull/6006/files#diff-c1d6d66f4d090c56d722fc0d20b0c02464e9d96959db92ecea1553be66affa6a
apps/sim/app/api/v1/files/[fileId]/route.test.tshttps://github.com/simstudioai/sim/pull/6006/files#diff-b54b227a4f0056aeb3cd9a452ee2a7d12c3e842546e584932a2adef27f5cb97c
View file https://github.com/simstudioai/sim/blob/6950e22032ae22966933b98e4b4a72b63fa84de5/apps/sim/app/api/v1/files/%5BfileId%5D/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6006/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6006/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.