René's URL Explorer Experiment


Title: fix(api): stop workspace import dropping every workflow variable by waleedlatif1 · Pull Request #6002 · simstudioai/sim · GitHub

Open Graph Title: fix(api): stop workspace import dropping every workflow variable by waleedlatif1 · Pull Request #6002 · simstudioai/sim

X Title: fix(api): stop workspace import dropping every workflow variable by waleedlatif1 · Pull Request #6002 · simstudioai/sim

Description: Summary Follow-up to #5999, which extracted the shared import helpers. This applies them to the last path that was still hand-rolling its own — and that path had a real data-loss bug. Workspace import silently dropped every workflow variable. It guarded its variable write on Array.isArray, but parseWorkflowVariables — what the matching workspace export emits — returns the record form. So export a workspace, import it back, and all variables were gone. Restore path, no warning, no error. Now uses the shared normalizeImportedVariables, which accepts both shapes. Workspace import also skipped the normalization pipeline that the editor, the v1 import API and the single-workflow admin import already share. It wrote raw parsed state, so a dangling edge tripped the workflow_edges foreign key and failed the restore, and blocks missing their backfilled columns could land unopenable — the same class #5999 closed elsewhere. Now calls prepareWorkflowStateForPersistence. Repointed persistImportedWorkflow (the in-app importer) at the same helper, removing the last inline copy. All four import paths now normalize variables identically. Type of Change Bug fix Testing First tests for these helpers — 15 cases covering both shapes, JSON-string column values, missing/padded/non-string ids, unrecognized type, a __proto__-keyed entry (built via JSON.parse, since an object literal's __proto__ sets the prototype instead), and the export → import round trip that pins the record form the bug dropped. 1273 tests pass across lib/workflows/, app/api/v1/workflows/ and app/api/workflows/. Typecheck, lint, check:api-validation:strict and the monorepo boundary check all pass. Not exercised against a live server — no real workspace was exported and re-imported end to end. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #5999, which extracted the shared import helpers. This applies them to the last path that was still hand-rolling its own — and that path had a real data-loss bug. Workspace im...

X Description: Summary Follow-up to #5999, which extracted the shared import helpers. This applies them to the last path that was still hand-rolling its own — and that path had a real data-loss bug. Workspace im...

Opengraph URL: https://github.com/simstudioai/sim/pull/6002

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:40024f1e-470b-43e6-c2c2-68de08f3c796
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA3B0:38C411:7379:A378:6AFB47A5
html-safe-nonce0be01c93f3f2c990c5857fe80ba6ea0cb656a47b1e951eb2ce7739c79b1320ac
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBM0IwOjM4QzQxMTo3Mzc5OkEzNzg6NkFGQjQ3QTUiLCJ2aXNpdG9yX2lkIjoiMzg0NjAyNzE3MzkzNjQ0OTQ0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5ce08a907995e9430dada02bec46d66f033b3c0091b905ab4d4a3039e6d53312
hovercard-subject-tagpull_request:4148983052
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/6002/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #5999, which extracted the shared import helpers. This applies them to the last path that was still hand-rolling its own — and that path had a real data-loss bug. Workspace im...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/6002/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6002%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F6002%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/6002/files
Reloadhttps://github.com/simstudioai/sim/pull/6002/files
Reloadhttps://github.com/simstudioai/sim/pull/6002/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
workflow-import-followuphttps://github.com/simstudioai/sim/tree/workflow-import-followup
Conversation 3 https://github.com/simstudioai/sim/pull/6002
Commits 1 https://github.com/simstudioai/sim/pull/6002/commits
Checks 19 https://github.com/simstudioai/sim/pull/6002/checks
Files changed https://github.com/simstudioai/sim/pull/6002/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6002/files
fix(api): stop workspace import dropping every workflow variable https://github.com/simstudioai/sim/pull/6002/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/6002/files
d70825a fix(api): stop workspace import dropping every workflow variable waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/6002/commits/d70825aab9b2bc25e9272ee590fc28d1529ba7e3
Clear filters https://github.com/simstudioai/sim/pull/6002/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6002/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/6002/files
route.ts https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
import-export.ts https://github.com/simstudioai/sim/pull/6002/files#diff-f816c7a34827ade49b2f491811b7a13a59c88c10eda17694826823d47c3c8aa5
parse.test.ts https://github.com/simstudioai/sim/pull/6002/files#diff-3e74b5c4e7fb67651f36f848e699e3cb5b317276f0771b7a52c116b67c70983f
apps/sim/app/api/v1/admin/workspaces/[id]/import/route.tshttps://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
View file https://github.com/simstudioai/sim/blob/d70825aab9b2bc25e9272ee590fc28d1529ba7e3/apps/sim/app/api/v1/admin/workspaces/%5Bid%5D/import/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6002/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
https://github.com/simstudioai/sim/pull/6002/files#diff-452cc246b49304a6035fa514a151a362b480b91656df5661cc0b0b40dab19eb1
apps/sim/lib/workflows/operations/import-export.tshttps://github.com/simstudioai/sim/pull/6002/files#diff-f816c7a34827ade49b2f491811b7a13a59c88c10eda17694826823d47c3c8aa5
View file https://github.com/simstudioai/sim/blob/d70825aab9b2bc25e9272ee590fc28d1529ba7e3/apps/sim/lib/workflows/operations/import-export.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6002/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/6002/files#diff-f816c7a34827ade49b2f491811b7a13a59c88c10eda17694826823d47c3c8aa5
https://github.com/simstudioai/sim/pull/6002/files#diff-f816c7a34827ade49b2f491811b7a13a59c88c10eda17694826823d47c3c8aa5
https://github.com/simstudioai/sim/pull/6002/files#diff-f816c7a34827ade49b2f491811b7a13a59c88c10eda17694826823d47c3c8aa5
https://github.com/simstudioai/sim/pull/6002/files#diff-f816c7a34827ade49b2f491811b7a13a59c88c10eda17694826823d47c3c8aa5
apps/sim/lib/workflows/variables/parse.test.tshttps://github.com/simstudioai/sim/pull/6002/files#diff-3e74b5c4e7fb67651f36f848e699e3cb5b317276f0771b7a52c116b67c70983f
View file https://github.com/simstudioai/sim/blob/d70825aab9b2bc25e9272ee590fc28d1529ba7e3/apps/sim/lib/workflows/variables/parse.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/6002/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/6002/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.