René's URL Explorer Experiment


Title: perf(files): stream workspace archives instead of buffering them by waleedlatif1 · Pull Request #5993 · simstudioai/sim · GitHub

Open Graph Title: perf(files): stream workspace archives instead of buffering them by waleedlatif1 · Pull Request #5993 · simstudioai/sim

X Title: perf(files): stream workspace archives instead of buffering them by waleedlatif1 · Pull Request #5993 · simstudioai/sim

Description: Stacked on #5986 — review that first. Base retargets to staging once it merges. Summary The zip route materialized every selected file before writing a byte, so peak memory tracked the size of the selection. Ordinary files are now appended as lazy streams — each opens its storage read only when the archiver reaches it, so one entry is resident at a time instead of the whole archive Generated documents still resolve to buffers first. They are the only entries whose bytes decide anything, and every status this route returns comes from them — once the first byte is written the status code is committed, so those decisions have to happen before the archive starts This removes the memory objection on #5986 at its root rather than tuning around it: the per-entry allowance and byte budget now govern documents only, which are small by nature Why these dependencies archiver (35.6M weekly downloads, 8.0.0 released this May) — its entry queue processes appends sequentially. Raw zip-stream, which archiver wraps, has no queue management lazystream (31.3M weekly) — defers each storage read until the archiver pulls it. Already a direct dependency of archiver, so declaring it just makes an import we use explicit. Handing the archiver one open stream per entry would hold more connections than the storage client pools, most sitting idle until their turn Reuse nodeReadableToWebStream moves out of input-validation.server.ts into lib/core/utils/node-stream.ts and is shared. Its existing comment is the reason it exists: Readable.toWeb throws an unhandled ERR_INVALID_STATE when a consumer cancels while the source is still flowing — exactly what a cancelled download does. It also copies chunks off pooled buffers, honours backpressure, and settles a destroy that never emits error. Trade worth reviewing A storage read that fails mid-archive now truncates the response instead of returning 500, because the status is already sent. Documents cannot hit this (they resolve up front); it applies to ordinary files. app/api/table/[tableId]/export already behaves this way. Type of Change Performance Testing Ten route tests, including one asserting that no storage read happens until the archive is pulled — the property the whole change rests on — plus nested paths across both entry kinds, the pending-artifact 409, per-entry vs shared-budget size attribution, and the declared-size pre-check rejecting before any read. 1112 tests pass across lib/uploads, lib/core/security, lib/core/utils, and the touched routes. Lint, check:utils, typecheck and check:api-validation clean. Not live-tested in a browser yet. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Stacked on #5986 — review that first. Base retargets to staging once it merges. Summary The zip route materialized every selected file before writing a byte, so peak memory tracked the size of the...

X Description: Stacked on #5986 — review that first. Base retargets to staging once it merges. Summary The zip route materialized every selected file before writing a byte, so peak memory tracked the size of the...

Opengraph URL: https://github.com/simstudioai/sim/pull/5993

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:08fe3398-92b9-e7e4-1f0f-0a1dd379d75f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD850:5A71D:B63763:F96627:6AFB517D
html-safe-nonce56f448a71074804ade94f54565e55cf54624dd6c7d64eb96521f86cf3299765b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEODUwOjVBNzFEOkI2Mzc2MzpGOTY2Mjc6NkFGQjUxN0QiLCJ2aXNpdG9yX2lkIjoiMzkyNTIxNzIzMTE4NDI4NjA3NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd7b3d4a404add01fef552932057f996a620c44f2ef9b6cc299ed82a6885d241c
hovercard-subject-tagpull_request:4147127123
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5993/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altStacked on #5986 — review that first. Base retargets to staging once it merges. Summary The zip route materialized every selected file before writing a byte, so peak memory tracked the size of the...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5993/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5993%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5993%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5993/files
Reloadhttps://github.com/simstudioai/sim/pull/5993/files
Reloadhttps://github.com/simstudioai/sim/pull/5993/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
fix/archive-generated-doc-byteshttps://github.com/simstudioai/sim/tree/fix/archive-generated-doc-bytes
perf/stream-workspace-file-archiveshttps://github.com/simstudioai/sim/tree/perf/stream-workspace-file-archives
Conversation 9 https://github.com/simstudioai/sim/pull/5993
Commits 1 https://github.com/simstudioai/sim/pull/5993/commits
Checks 4 https://github.com/simstudioai/sim/pull/5993/checks
Files changed https://github.com/simstudioai/sim/pull/5993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5993/files
perf(files): stream workspace archives instead of buffering them https://github.com/simstudioai/sim/pull/5993/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5993/files
80a4e0c perf(files): stream workspace archives instead of buffering them waleedlatif1 Jul 28, 2026 https://github.com/simstudioai/sim/pull/5993/commits/80a4e0cfcb2768c2aca7277c40f050df33a35c2d
Clear filters https://github.com/simstudioai/sim/pull/5993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5993/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5993/files
route.test.ts https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
route.ts https://github.com/simstudioai/sim/pull/5993/files#diff-9409e139d8dc3ad2d247da0545d04306516702ec8fab78b87b3b2eff1186f4f3
input-validation.server.ts https://github.com/simstudioai/sim/pull/5993/files#diff-6aff011dd9656fc3e2283ce7a33580a51622749a977dcacb0b75050284426798
node-stream.ts https://github.com/simstudioai/sim/pull/5993/files#diff-8b00a5985cd80e78bdcab8d06a3653dfcdf6754ba416abee5205e71093b67d81
package.json https://github.com/simstudioai/sim/pull/5993/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
bun.lock https://github.com/simstudioai/sim/pull/5993/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
apps/sim/app/api/workspaces/[id]/files/download/route.test.tshttps://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
View file https://github.com/simstudioai/sim/blob/80a4e0cfcb2768c2aca7277c40f050df33a35c2d/apps/sim/app/api/workspaces/%5Bid%5D/files/download/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5993/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
https://github.com/simstudioai/sim/pull/5993/files#diff-21e96ed9826e90b7329c0f1d4f3cc50878206832cf2989952c81b8bc82adb9c5
Please reload this pagehttps://github.com/simstudioai/sim/pull/5993/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.