Title: fix(security): suppress the CodeQL password-hash false positive on sha256Hex by TheodoreSpeaks · Pull Request #5982 · simstudioai/sim · GitHub
Open Graph Title: fix(security): suppress the CodeQL password-hash false positive on sha256Hex by TheodoreSpeaks · Pull Request #5982 · simstudioai/sim
X Title: fix(security): suppress the CodeQL password-hash false positive on sha256Hex by TheodoreSpeaks · Pull Request #5982 · simstudioai/sim
Description: Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is required, so the release is blocked. Why they appeared now. d362e6816e (setup wizard) added sha256Base64Url to this file. Touching it made every pre-existing taint path that ends here count as "new code changed by this pull request" — CodeQL's own summary hints at this ("Alerts not introduced by this pull request might have been detected because the code changes were too large"). The flagged lines are in sha256Hex, which was not modified, and neither were any of its callers. Why they're false positives. Neither taint source is a human-chosen password: Caller What it passes hashApiKey(plainKey) An API key built from generateSecureToken(24) = randomBytes(24) — 192 bits. A fast digest is the correct construction for an indexed WHERE key_hash = $1 lookup; a slow KDF would run on every authenticated request and buy nothing against a keyspace that cannot be searched. passwordSlot(encryptedPassword) An already-encrypted value, hashed to an 8-char discriminator so deployment auth tokens invalidate when the password changes. Not credential storage. User credentials never reach this helper — Better Auth owns them and applies its own KDF. I verified there is no other password-shaped caller. Approach Inline // lgtm[js/insufficient-password-hash] on the two flagged lines, matching the convention this repo already uses for the same class of judgement (uuidV5 in apps/sim/ee/workspace-forking/lib/remap/block-identity.ts suppresses js/weak-cryptographic-algorithm the same way; there are currently 0 open alerts for that rule, so the mechanism works). The sha256Hex doc comment now states the invariant — high-entropy secrets and content digests only, genuine passwords go to Better Auth — so a future caller has the rule in front of them rather than inheriting a silent suppression. sha256Base64Url is deliberately left unannotated even though it is the same primitive: it was not flagged, and a speculative suppression there would hide a real finding later. Type of Change Bug fix (unblocks a failing required check) Testing packages/security suite passes (35 tests), bun run lint clean. No behavior change — comments only. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is...
X Description: Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is...
Opengraph URL: https://github.com/simstudioai/sim/pull/5982
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:74607fa9-a23a-c599-6ce8-cfc70629a86e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B3E0:870C9:84017C:BB5FA2:6AFB4D5A |
| html-safe-nonce | 831f571eb4d38d43b6157d9ac9247c3aac4a6b194a16adb3ea3be2c8a0744068 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0UwOjg3MEM5Ojg0MDE3QzpCQjVGQTI6NkFGQjRENUEiLCJ2aXNpdG9yX2lkIjoiODE3NTUyMDM1MDUyNDM2MjA3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | c452911fba7065802aeca073815554fcc6ffe164592d6644a6ddd42ed9985b89 |
| hovercard-subject-tag | pull_request:4146124814 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5982/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width