René's URL Explorer Experiment


Title: fix(security): suppress the CodeQL password-hash false positive on sha256Hex by TheodoreSpeaks · Pull Request #5982 · simstudioai/sim · GitHub

Open Graph Title: fix(security): suppress the CodeQL password-hash false positive on sha256Hex by TheodoreSpeaks · Pull Request #5982 · simstudioai/sim

X Title: fix(security): suppress the CodeQL password-hash false positive on sha256Hex by TheodoreSpeaks · Pull Request #5982 · simstudioai/sim

Description: Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is required, so the release is blocked. Why they appeared now. d362e6816e (setup wizard) added sha256Base64Url to this file. Touching it made every pre-existing taint path that ends here count as "new code changed by this pull request" — CodeQL's own summary hints at this ("Alerts not introduced by this pull request might have been detected because the code changes were too large"). The flagged lines are in sha256Hex, which was not modified, and neither were any of its callers. Why they're false positives. Neither taint source is a human-chosen password: Caller What it passes hashApiKey(plainKey) An API key built from generateSecureToken(24) = randomBytes(24) — 192 bits. A fast digest is the correct construction for an indexed WHERE key_hash = $1 lookup; a slow KDF would run on every authenticated request and buy nothing against a keyspace that cannot be searched. passwordSlot(encryptedPassword) An already-encrypted value, hashed to an 8-char discriminator so deployment auth tokens invalidate when the password changes. Not credential storage. User credentials never reach this helper — Better Auth owns them and applies its own KDF. I verified there is no other password-shaped caller. Approach Inline // lgtm[js/insufficient-password-hash] on the two flagged lines, matching the convention this repo already uses for the same class of judgement (uuidV5 in apps/sim/ee/workspace-forking/lib/remap/block-identity.ts suppresses js/weak-cryptographic-algorithm the same way; there are currently 0 open alerts for that rule, so the mechanism works). The sha256Hex doc comment now states the invariant — high-entropy secrets and content digests only, genuine passwords go to Better Auth — so a future caller has the rule in front of them rather than inheriting a silent suppression. sha256Base64Url is deliberately left unannotated even though it is the same primitive: it was not flagged, and a speculative suppression there would hide a real finding later. Type of Change Bug fix (unblocks a failing required check) Testing packages/security suite passes (35 tests), bun run lint clean. No behavior change — comments only. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is...

X Description: Summary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is...

Opengraph URL: https://github.com/simstudioai/sim/pull/5982

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:74607fa9-a23a-c599-6ce8-cfc70629a86e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB3E0:870C9:84017C:BB5FA2:6AFB4D5A
html-safe-nonce831f571eb4d38d43b6157d9ac9247c3aac4a6b194a16adb3ea3be2c8a0744068
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCM0UwOjg3MEM5Ojg0MDE3QzpCQjVGQTI6NkFGQjRENUEiLCJ2aXNpdG9yX2lkIjoiODE3NTUyMDM1MDUyNDM2MjA3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc452911fba7065802aeca073815554fcc6ffe164592d6644a6ddd42ed9985b89
hovercard-subject-tagpull_request:4146124814
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5982/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary CodeQL fails #5963 (the v0.7.46 release PR) with 2 high-severity js/insufficient-password-hash alerts on packages/security/src/hash.ts:12 and :14. Both are false positives, but the check is...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5982/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5982%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5982%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5982/files
Reloadhttps://github.com/simstudioai/sim/pull/5982/files
Reloadhttps://github.com/simstudioai/sim/pull/5982/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
TheodoreSpeakshttps://github.com/TheodoreSpeaks
staginghttps://github.com/simstudioai/sim/tree/staging
fix/codeql-hash-suppressionhttps://github.com/simstudioai/sim/tree/fix/codeql-hash-suppression
Conversation 3 https://github.com/simstudioai/sim/pull/5982
Commits 1 https://github.com/simstudioai/sim/pull/5982/commits
Checks 19 https://github.com/simstudioai/sim/pull/5982/checks
Files changed https://github.com/simstudioai/sim/pull/5982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5982/files
fix(security): suppress the CodeQL password-hash false positive on sha256Hex https://github.com/simstudioai/sim/pull/5982/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5982/files
491c318 fix(security): suppress the CodeQL password-hash alert on sha256Hex TheodoreSpeaks Jul 27, 2026 https://github.com/simstudioai/sim/pull/5982/commits/491c31859580cc183d767a5a174c7990fcfc4793
Clear filters https://github.com/simstudioai/sim/pull/5982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5982/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5982/files
packages/security/src/hash.tshttps://github.com/simstudioai/sim/pull/5982/files#diff-e661bd49ba2ff7ac98f23965d26a306ee86fc08e49ceafe77c0520c3c6a8dbe2
View file https://github.com/simstudioai/sim/blob/491c31859580cc183d767a5a174c7990fcfc4793/packages/security/src/hash.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5982/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5982/files#diff-e661bd49ba2ff7ac98f23965d26a306ee86fc08e49ceafe77c0520c3c6a8dbe2
https://github.com/simstudioai/sim/pull/5982/files#diff-e661bd49ba2ff7ac98f23965d26a306ee86fc08e49ceafe77c0520c3c6a8dbe2
Please reload this pagehttps://github.com/simstudioai/sim/pull/5982/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.