Title: fix(unload): remove beforeunload warning since we communicate via wss by waleedlatif1 · Pull Request #597 · simstudioai/sim · GitHub
Open Graph Title: fix(unload): remove beforeunload warning since we communicate via wss by waleedlatif1 · Pull Request #597 · simstudioai/sim
X Title: fix(unload): remove beforeunload warning since we communicate via wss by waleedlatif1 · Pull Request #597 · simstudioai/sim
Description: Description Remove beforeunload warning since we communicate via wss. This removes the 'Are you sure you want to leave this page?' every time someone closes the simstudio tab. This is not necessary since we stream changes in realtime. Type of change Bug fix (non-breaking change which fixes an issue) How Has This Been Tested? Tested navigating away from the tab, ensured there was no alert dialog. Checklist: My code follows the style guidelines of this project I have performed a self-review of my own code I have commented my code, particularly in hard-to-understand areas I have added tests that prove my fix is effective or that my feature works All tests pass locally and in CI (bun run test) My changes generate no new warnings Any dependent changes have been merged and published in downstream modules I have updated version numbers as needed (if needed) I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) Security Considerations: My changes do not introduce any new security vulnerabilities I have considered the security implications of my changes
Open Graph Description: Description Remove beforeunload warning since we communicate via wss. This removes the 'Are you sure you want to leave this page?' every time someone closes the simstudio tab. This is not n...
X Description: Description Remove beforeunload warning since we communicate via wss. This removes the 'Are you sure you want to leave this page?' every time someone closes the simstudio tab. This ...
Opengraph URL: https://github.com/simstudioai/sim/pull/597
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9117f58f-1946-b2e2-cc03-78de2539d1e2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8014:330459:5063FF:72D116:6AFB404C |
| html-safe-nonce | 31fad8d1de0106b11bb7e477ffddb320adff13e6c5e1d7982ac56bb6516f301f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDE0OjMzMDQ1OTo1MDYzRkY6NzJEMTE2OjZBRkI0MDRDIiwidmlzaXRvcl9pZCI6IjQwOTA3MDQ0MDg0NTMyNjc1MzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b46e51b7ffa062f61efe8ad8040feed643f00bc2b977b4297a48d0b9c90000a6 |
| hovercard-subject-tag | pull_request:2630963344 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/597/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Description Remove beforeunload warning since we communicate via wss. This removes the 'Are you sure you want to leave this page?' every time someone closes the simstudio tab. This is not n... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | d849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | a6c2f87cbcb6414452377b4967858ed6a66f1109 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width