Title: fix(ci): skip lifecycle scripts on CI installs by waleedlatif1 · Pull Request #5959 · simstudioai/sim · GitHub
Open Graph Title: fix(ci): skip lifecycle scripts on CI installs by waleedlatif1 · Pull Request #5959 · simstudioai/sim
X Title: fix(ci): skip lifecycle scripts on CI installs by waleedlatif1 · Pull Request #5959 · simstudioai/sim
Description: Summary Fixes the Create GitHub Release failure on main, a regression from #5935, and removes the class of failure rather than just this instance. #5935 removed the blanket .npmrc ignore-scripts=true, so isolated-vm's install script now actually runs. Upstream publishes prebuilds for Node 22 (ABI 127) and Node 24 (ABI 137) only. Jobs that set up Bun but never setup-node inherit the runner default — Node 20 — where prebuild-install finds nothing: prebuild-install warn install No prebuilt binaries found (target=20.20.0 runtime=node arch=x64 libc= platform=linux) and falls back to node-gyp, which crashes: gyp ERR! stack TypeError: webidl.util.markAsUncloneable is not a function error: install script from "isolated-vm" exited with 1 That failure is undici #5024 — a regression in undici 8.0.3 that broke Node 20, still open. node-gyp bundles undici and Bun fetches node-gyp@latest via bunx, so this arrives unpinned at install time. Before #5935 the script never ran, so the skew was invisible. The fix: --ignore-scripts on all 8 CI installs No CI job needs a compiled native module. isolated-vm landed in December 2025 and .npmrc blocked lifecycle scripts until #5935, so CI ran green for ~7 months with it never built. That is corroborated structurally: next.config.ts lists it in serverExternalPackages and trigger.config.ts externals it (never bundled), every test mocks it, and the only real require('isolated-vm') is in isolated-vm-worker.cjs, which no CI job spawns. All three Dockerfiles already install with --ignore-scripts and rebuild it by hand. Building it in CI buys nothing and couples every job to prebuild availability for the pinned Node. With only two ABIs published upstream, the next setup-node bump would resurface the same opaque node-gyp failure. Local dev keeps the automatic build that #5935 was for. Skipping lifecycle scripts on CI installs is also standard supply-chain hardening — it is one layer of the usual lockfile + cooldown + script-blocking stack, and Bun blocks scripts by default for the same reason. What is deliberately not here An earlier revision of this PR also added setup-node to create-release, migrate, and deploy-trigger-dev. That was redundant and has been removed: once scripts are skipped, nothing in those jobs invokes node. They run bun run scripts/create-single-release.ts, bun run db:push + bun run scripts/migrate.ts, and bunx trigger.dev deploy — and all three were green without setup-node for months. setup-bun + setup-node is redundant unless a job needs node-specific tooling. setup-node remains only where it is load-bearing: publish-cli and publish-ts-sdk need it for npm publish and its registry-url auth; test-build and docs-embeddings already had it. The one extra change is publish-cli.yml Node 18 → 22. That job's setup-node is required, and 18 has been EOL since April 2025; this matches publish-ts-sdk.yml, which already publishes on 22. Separable from the bug fix if you would rather it land on its own. Audit Every job in the repo that runs bun install: workflow job setup-node --ignore-scripts ci.yml create-release — the failing job none added ci.yml deploy-trigger-dev none added migrations.yml migrate none added publish-cli.yml publish-npm 18 → 22 (needed for npm publish) added docs-embeddings.yml process-docs-embeddings 22 (unchanged) added publish-ts-sdk.yml publish-npm 22 (unchanged) added test-build.yml test-build 22 (unchanged) added test-build.yml build 22 (unchanged) added Testing Verified upstream prebuild coverage against the v6.0.2 release assets: node-v127 and node-v137 only — no ABI 115 (Node 20) or 108 (Node 18) build on any platform Confirmed prebuild-install resolves ABI from the real node on PATH, not Bun's claimed version Audited all 8 install jobs; each passes --ignore-scripts, and every remaining setup-node is ordered before its install step Test and Build / Build App and Lint and Test both pass on this branch, exercising the --ignore-scripts install path end to end All workflow YAML parses cleanly Note: create-release only runs on release commits on main and deploy-trigger-dev only on pushes to dev, so neither is exercised by this PR's own CI. test-build and build do exercise the --ignore-scripts install path here. Follow-up (not in this PR) .devcontainer/Dockerfile is oven/bun:1.3.13-alpine and post-create.sh runs a plain bun install. The official oven/bun images ship no Node binary, and prebuild-install is a node-shebang script with node-gyp as its fallback — so #5935 likely broke devcontainer onboarding too. Unverified (no local Docker daemon). The real fix there is adding Node to the image: isolated-vm spawns a Node child process at runtime, so the sandbox has never worked in that container regardless. Type of Change Bug fix Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Fixes the Create GitHub Release failure on main, a regression from #5935, and removes the class of failure rather than just this instance. #5935 removed the blanket .npmrc ignore-scripts=tr...
X Description: Summary Fixes the Create GitHub Release failure on main, a regression from #5935, and removes the class of failure rather than just this instance. #5935 removed the blanket .npmrc ignore-scripts=tr...
Opengraph URL: https://github.com/simstudioai/sim/pull/5959
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6dcbef09-480a-d1d4-e06b-56839d8a1c46 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 855E:29D5DB:A62082:E3FF0C:6AFB4FF6 |
| html-safe-nonce | ccfe6349900d7b1b6818891bc24a26d39a47c694a42d708cdc4ffeb0d9103fe7 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTVFOjI5RDVEQjpBNjIwODI6RTNGRjBDOjZBRkI0RkY2IiwidmlzaXRvcl9pZCI6IjU3NTIxODIzMzkwNjA1ODQ0MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 69463d675ac494ba56983aa3d040a0da471f8c8983f721bb2ebde34c9ca03b54 |
| hovercard-subject-tag | pull_request:4130859949 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5959/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fixes the Create GitHub Release failure on main, a regression from #5935, and removes the class of failure rather than just this instance. #5935 removed the blanket .npmrc ignore-scripts=tr... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width