Title: test(data-drains): cover the migrated detail and create surfaces by waleedlatif1 · Pull Request #5958 · simstudioai/sim · GitHub
Open Graph Title: test(data-drains): cover the migrated detail and create surfaces by waleedlatif1 · Pull Request #5958 · simstudioai/sim
X Title: test(data-drains): cover the migrated detail and create surfaces by waleedlatif1 · Pull Request #5958 · simstudioai/sim
Description: Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks the behaviours the migration could have silently dropped. The first run immediately caught a defect that shipped in #5954: dropping toLowerCase from humanizeConfigKey (a review suggestion, to stop accessKeyId reading as Access key id) left every config label in Title Case — Force Path Style — while the function's own TSDoc still promised Force path style. Now sentence case with initialisms preserved: Force path style, Access key ID, Service account JSON. Fixed here since #5954 was already merged. What the tests pin down: the detail carries every column the old table showed (source, destination, cadence, last run) and never renders credentials run sizes report sub-kilobyte writes rather than flooring to 0 Bytes, and a 5 GB run stays in GB — both directions of the formatFileSize bug Run now stays disabled while a drain is disabled, matching the old row menu delete leaves the detail only after the request resolves, and stays put + toasts on failure create gates on name plus a complete destination, sends the correct destination branch, trims the name, and toasts on failure every labelled field across all seven destination forms resolves to a real control id, and every select carries an accessible name — the regression from the ChipModalField → SettingRow migration, now guarded Type of Change Tests Bug fix (config label casing) Testing 18 tests across the two new files; full ee/data-drains + lib/data-drains suites, typecheck, and lint:check green. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks ...
X Description: Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks ...
Opengraph URL: https://github.com/simstudioai/sim/pull/5958
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:772ef8a4-239d-21fe-f0ac-cb1fbf1ac6c7 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CA30:1A169A:264404:35CD41:6AFB5290 |
| html-safe-nonce | 918a79532e6cf8634aa827aded21775c8fda2a47d8250bafe74ce821b213c0e9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTMwOjFBMTY5QToyNjQ0MDQ6MzVDRDQxOjZBRkI1MjkwIiwidmlzaXRvcl9pZCI6IjU3MjcxODA0ODQwMjcwNDQ0OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 8c3e171d09b233a851f1406e82ae0f42cfff35c8b7ed47d4b5596129f3285dc2 |
| hovercard-subject-tag | pull_request:4130810388 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5958/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width