René's URL Explorer Experiment


Title: test(data-drains): cover the migrated detail and create surfaces by waleedlatif1 · Pull Request #5958 · simstudioai/sim · GitHub

Open Graph Title: test(data-drains): cover the migrated detail and create surfaces by waleedlatif1 · Pull Request #5958 · simstudioai/sim

X Title: test(data-drains): cover the migrated detail and create surfaces by waleedlatif1 · Pull Request #5958 · simstudioai/sim

Description: Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks the behaviours the migration could have silently dropped. The first run immediately caught a defect that shipped in #5954: dropping toLowerCase from humanizeConfigKey (a review suggestion, to stop accessKeyId reading as Access key id) left every config label in Title Case — Force Path Style — while the function's own TSDoc still promised Force path style. Now sentence case with initialisms preserved: Force path style, Access key ID, Service account JSON. Fixed here since #5954 was already merged. What the tests pin down: the detail carries every column the old table showed (source, destination, cadence, last run) and never renders credentials run sizes report sub-kilobyte writes rather than flooring to 0 Bytes, and a 5 GB run stays in GB — both directions of the formatFileSize bug Run now stays disabled while a drain is disabled, matching the old row menu delete leaves the detail only after the request resolves, and stays put + toasts on failure create gates on name plus a complete destination, sends the correct destination branch, trims the name, and toasts on failure every labelled field across all seven destination forms resolves to a real control id, and every select carries an accessible name — the regression from the ChipModalField → SettingRow migration, now guarded Type of Change Tests Bug fix (config label casing) Testing 18 tests across the two new files; full ee/data-drains + lib/data-drains suites, typecheck, and lint:check green. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks ...

X Description: Summary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks ...

Opengraph URL: https://github.com/simstudioai/sim/pull/5958

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:772ef8a4-239d-21fe-f0ac-cb1fbf1ac6c7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA30:1A169A:264404:35CD41:6AFB5290
html-safe-nonce918a79532e6cf8634aa827aded21775c8fda2a47d8250bafe74ce821b213c0e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTMwOjFBMTY5QToyNjQ0MDQ6MzVDRDQxOjZBRkI1MjkwIiwidmlzaXRvcl9pZCI6IjU3MjcxODA0ODQwMjcwNDQ0OTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8c3e171d09b233a851f1406e82ae0f42cfff35c8b7ed47d4b5596129f3285dc2
hovercard-subject-tagpull_request:4130810388
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5958/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #5954. That PR shipped the fullscreen migration with every gate green but nothing ever rendered — so this executes the two new views instead of reasoning about them, and locks ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5958/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5958%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5958%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5958/files
Reloadhttps://github.com/simstudioai/sim/pull/5958/files
Reloadhttps://github.com/simstudioai/sim/pull/5958/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
data-drains-testshttps://github.com/simstudioai/sim/tree/data-drains-tests
Conversation 5 https://github.com/simstudioai/sim/pull/5958
Commits 1 https://github.com/simstudioai/sim/pull/5958/commits
Checks 19 https://github.com/simstudioai/sim/pull/5958/checks
Files changed https://github.com/simstudioai/sim/pull/5958/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5958/files
test(data-drains): cover the migrated detail and create surfaces https://github.com/simstudioai/sim/pull/5958/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5958/files
5aa1632 test(data-drains): cover the migrated detail and create surfaces waleedlatif1 Jul 25, 2026 https://github.com/simstudioai/sim/pull/5958/commits/5aa1632011a8ca326dcc24784d700d8cf7d68e00
Clear filters https://github.com/simstudioai/sim/pull/5958/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5958/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5958/files
data-drain-create.test.tsx https://github.com/simstudioai/sim/pull/5958/files#diff-ef721b0a45bed550a84d44b47c8ef748927cfcee26dccc55f74782a8a5b0c4cd
data-drain-detail.test.tsx https://github.com/simstudioai/sim/pull/5958/files#diff-eaad7bf78a9179bafbb896cb3210333e407449ff7fbe6a0505707d96e9d3224c
data-drain-detail.tsx https://github.com/simstudioai/sim/pull/5958/files#diff-f766b2f4006fd0c48d77761fd9ccfb73b36638cd27ba6e9f38dbf484f569e4c5
apps/sim/ee/data-drains/components/data-drain-create.test.tsxhttps://github.com/simstudioai/sim/pull/5958/files#diff-ef721b0a45bed550a84d44b47c8ef748927cfcee26dccc55f74782a8a5b0c4cd
View file https://github.com/simstudioai/sim/blob/5aa1632011a8ca326dcc24784d700d8cf7d68e00/apps/sim/ee/data-drains/components/data-drain-create.test.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5958/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/5958/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5958/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.