Title: test(copilot): catch a tool silently dropping its query from the chip by j15z · Pull Request #5953 · simstudioai/sim · GitHub
Open Graph Title: test(copilot): catch a tool silently dropping its query from the chip by j15z · Pull Request #5953 · simstudioai/sim
X Title: test(copilot): catch a tool silently dropping its query from the chip by j15z · Pull Request #5953 · simstudioai/sim
Description: Summary has an intentional display title for every visible catalog tool only checks that a title exists. A bare fallback label satisfies it exactly as well as a useful one, so a tool that shows its query in the chip can stop doing so with the suite still green. Adds a subset ratchet: any catalog tool taking a query must show it, unless listed in a documented allowlist. The set may shrink but never grow, so removing a tool — or teaching one to show its query — needs no change here. Three tools currently ignore their query and are baselined with the reason recorded: search_documentation and search_library_docs have no argument-aware case, and search_online has one that reads toolTitle/title without falling back to query. Changing their chips is a UX decision that does not belong in a test-hardening change. Type of Change Other: test hardening Testing Verified the assertion actually fires — removing an entry from the allowlist fails with the offending tool named: AssertionError: expected [ 'search_online' ] to deeply equal [] 52 tool-display tests pass, tsc clean, biome clean. Reviewers should focus on whether the allowlist is the right shape: a subset check keeps the invariant honest about today's state while still catching a regression, but it does mean the three baselined tools are not enforced until someone removes them. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary has an intentional display title for every visible catalog tool only checks that a title exists. A bare fallback label satisfies it exactly as well as a useful one, so a tool that shows its...
X Description: Summary has an intentional display title for every visible catalog tool only checks that a title exists. A bare fallback label satisfies it exactly as well as a useful one, so a tool that shows its...
Opengraph URL: https://github.com/simstudioai/sim/pull/5953
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9f2f8a54-fc69-2f37-d958-5953402d6b9d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A47C:D16D6:5B3375:7E3DCF:6AFB3F69 |
| html-safe-nonce | d0b15a55fcf401e2801134e179e011b115eb5340686b3c5797fb767848ca97d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNDdDOkQxNkQ2OjVCMzM3NTo3RTNEQ0Y6NkFGQjNGNjkiLCJ2aXNpdG9yX2lkIjoiMjcxMDI0ODk0NTM5MjIzODQ0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | dcff34a1619e21b67166a04414baccbc1d43b73ffaf89e147a6ec7130d7309c0 |
| hovercard-subject-tag | pull_request:4130614210 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5953/files |
| twitter:image | https://avatars.githubusercontent.com/u/96924014?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/96924014?s=400&v=4 |
| og:image:alt | Summary has an intentional display title for every visible catalog tool only checks that a title exists. A bare fallback label satisfies it exactly as well as a useful one, so a tool that shows its... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3b4fc8df5ef1c6757e733a23e6b81b6725021823 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width