René's URL Explorer Experiment


Title: fix(deps): build isolated-vm on install via root trustedDependencies by waleedlatif1 · Pull Request #5935 · simstudioai/sim · GitHub

Open Graph Title: fix(deps): build isolated-vm on install via root trustedDependencies by waleedlatif1 · Pull Request #5935 · simstudioai/sim

X Title: fix(deps): build isolated-vm on install via root trustedDependencies by waleedlatif1 · Pull Request #5935 · simstudioai/sim

Description: Summary isolated-vm now builds on bun install — no more manual npm rebuild for every contributor Root cause was .npmrc with ignore-scripts=true, a blanket switch that overrode Bun's trustedDependencies allowlist and blocked every lifecycle script, including this repo's own root scripts That line landed in the May 2025 Bun migration (#371), seven months before isolated-vm was introduced (#2385). Two later commits added isolated-vm to trustedDependencies — root in #2387, then apps/sim in #2613 — and both were silently inert Deleted .npmrc; lifecycle policy now lives solely in root trustedDependencies, and added isolated-vm to it Removed the trustedDependencies block from apps/sim/package.json — Bun only reads the root list, so it never had any effect and was what misled the two earlier fixes Dropped the now-dangling .npmrc entry from CODEOWNERS Why this doesn't widen the supply-chain surface Naming any package in trustedDependencies replaces Bun's curated default-trust list rather than adding to it (verified: with trustedDependencies: ["nothing-real"], isolated-vm does not build even though it is on Bun's default list). So the allowlist is deny-by-default and the only packages permitted to run install scripts are isolated-vm and sharp. Everything currently blocked stays blocked — esbuild, core-js, protobufjs, ssh2, cpu-features, bufferutil, free-email-domains, ffmpeg-static. bunfig.toml's minimumReleaseAge supply-chain gate is untouched. isolated-vm's install script is prebuild-install || node-gyp rebuild. We already execute that exact binary as the sandbox for all untrusted user code, so running its installer adds no trust we don't already extend. Side effect worth knowing The .npmrc switch also blocked the repo's own root scripts, so husky's prepare never ran and core.hooksPath was unset — the pre-commit lint-staged hook has not been active for anyone who installed since May 2025. It installs correctly now (the hook ran on this PR's commit). Testing Verified in an isolated worktree, baseline vs. after on a clean node_modules: before after isolated-vm/out/isolated_vm.node absent built ffmpeg-static binary absent absent (unchanged) core.hooksPath unset .husky/_ Binary loads under the real runtime: node -e "require('isolated-vm')" → evalSync('40+2') = 42 ABI targeting is correct — prebuild-install runs under the node on PATH, not Bun, so it fetched node-v127 matching local Node 22 rather than Bun's claimed 24.3.0. That is the same Node that spawns the worker in lib/execution/isolated-vm.ts Upstream publishes prebuilds for node ABI v127/v137 across linux x64/arm64 (incl. musl), darwin-arm64 and win32-x64, covering the Blacksmith ubuntu-2404 x64/arm64 runners. Intel macOS has no prebuild and compiles from source — the same as the manual npm rebuild it replaces bun install --frozen-lockfile (the CI path) exits 0 bun run lint:check clean across all 19 tasks Docker unaffected: all three Dockerfiles pass --ignore-scripts explicitly and rebuild isolated-vm against the Node ABI by hand, so .npmrc was never load-bearing there Type of Change Bug fix Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary isolated-vm now builds on bun install — no more manual npm rebuild for every contributor Root cause was .npmrc with ignore-scripts=true, a blanket switch that overrode Bun's trustedDep...

X Description: Summary isolated-vm now builds on bun install — no more manual npm rebuild for every contributor Root cause was .npmrc with ignore-scripts=true, a blanket switch that overrode Bun's truste...

Opengraph URL: https://github.com/simstudioai/sim/pull/5935

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f12de7b4-7885-7927-fee7-661e9a6dc890
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB72C:1C88A1:61B1D5:8B5643:6AFB434C
html-safe-nonce7e2922aaf1a92fd39e458a8c15e61217c4d3c440cacc90ce0170dfae518609a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNzJDOjFDODhBMTo2MUIxRDU6OEI1NjQzOjZBRkI0MzRDIiwidmlzaXRvcl9pZCI6IjEyNDUyNDg0OTg1MTM0MjkzMjQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac266cbe5a2e86d933e01441f6a37165e12613a5d773198b9894617bf78e4d250a
hovercard-subject-tagpull_request:4127164607
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5935/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary isolated-vm now builds on bun install — no more manual npm rebuild for every contributor Root cause was .npmrc with ignore-scripts=true, a blanket switch that overrode Bun's trustedDep...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5935/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5935%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5935%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5935/files
Reloadhttps://github.com/simstudioai/sim/pull/5935/files
Reloadhttps://github.com/simstudioai/sim/pull/5935/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/isolated-vm-install-scriptshttps://github.com/simstudioai/sim/tree/fix/isolated-vm-install-scripts
Conversation 4 https://github.com/simstudioai/sim/pull/5935
Commits 1 https://github.com/simstudioai/sim/pull/5935/commits
Checks 19 https://github.com/simstudioai/sim/pull/5935/checks
Files changed https://github.com/simstudioai/sim/pull/5935/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5935/files
fix(deps): build isolated-vm on install via root trustedDependencies https://github.com/simstudioai/sim/pull/5935/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5935/files
5a55ca4 fix(deps): build isolated-vm on install via root trustedDependencies waleedlatif1 Jul 24, 2026 https://github.com/simstudioai/sim/pull/5935/commits/5a55ca452d07435c791243c8e0d168257add1172
Clear filters https://github.com/simstudioai/sim/pull/5935/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5935/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5935/files
CODEOWNERS https://github.com/simstudioai/sim/pull/5935/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
.npmrc https://github.com/simstudioai/sim/pull/5935/files#diff-e813096d69c49812e40e00be9ac8fa14d77f0ec1f97ab4c45cb096b3bedd35de
package.json https://github.com/simstudioai/sim/pull/5935/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
bun.lock https://github.com/simstudioai/sim/pull/5935/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
package.json https://github.com/simstudioai/sim/pull/5935/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
.github/CODEOWNERShttps://github.com/simstudioai/sim/pull/5935/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
View file https://github.com/simstudioai/sim/blob/5a55ca452d07435c791243c8e0d168257add1172/.github/CODEOWNERS
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5935/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5935/files#diff-3d36a1bf06148bc6ba1ce2ed3d19de32ea708d955fed212c0d27c536f0bd4da7
.npmrchttps://github.com/simstudioai/sim/pull/5935/files#diff-e813096d69c49812e40e00be9ac8fa14d77f0ec1f97ab4c45cb096b3bedd35de
View file https://github.com/simstudioai/sim/blob/5a8d21904deff9d454c9d7a2e54f22120ebe8124/.npmrc
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/simstudioai/sim/pull/5935/files
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L36
apps/sim/package.jsonhttps://github.com/simstudioai/sim/pull/5935/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
View file https://github.com/simstudioai/sim/blob/5a55ca452d07435c791243c8e0d168257add1172/apps/sim/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5935/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5935/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/pull/5935/files#diff-43a1bb37ce68ac536b0a4ed9e973d9d52da3975d74b37865f591bb37e191be64
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L38
bun.lockhttps://github.com/simstudioai/sim/pull/5935/files#diff-bfd0ef82a01108fa1e836c2500b98b7de8a92bb1ae352a8efcbd9d6ffcaabd60
View file https://github.com/simstudioai/sim/blob/5a55ca452d07435c791243c8e0d168257add1172/bun.lock
Open in desktop https://desktop.github.com
how customized files appear on GitHubhttps://docs.github.com/github/administering-a-repository/customizing-how-changed-files-appear-on-github
Please reload this pagehttps://github.com/simstudioai/sim/pull/5935/files
https://github.com/simstudioai/sim/blob/staging/.github/CODEOWNERS#L36
package.jsonhttps://github.com/simstudioai/sim/pull/5935/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
View file https://github.com/simstudioai/sim/blob/5a55ca452d07435c791243c8e0d168257add1172/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5935/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5935/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
https://github.com/simstudioai/sim/pull/5935/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
Please reload this pagehttps://github.com/simstudioai/sim/pull/5935/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.