René's URL Explorer Experiment


Title: fix(sso): surface DNS verification failures and the provider auto-append gotcha by waleedlatif1 · Pull Request #5931 · simstudioai/sim · GitHub

Open Graph Title: fix(sso): surface DNS verification failures and the provider auto-append gotcha by waleedlatif1 · Pull Request #5931 · simstudioai/sim

X Title: fix(sso): surface DNS verification failures and the provider auto-append gotcha by waleedlatif1 · Pull Request #5931 · simstudioai/sim

Description: Summary Follow-ups from a post-merge audit of verified domains (#5909). The security core came back correct — exact-match (not suffix-match) domain comparison, closed TOCTOU, 192-bit row-bound tokens, and no way to verify a domain without controlling its DNS zone. These fix the operational gaps around it. DNS provider auto-append. We handed admins the FQDN _sim-challenge.acme.com. GoDaddy, Namecheap, Hover and most cPanel panels append the zone to whatever is typed → _sim-challenge.acme.com.acme.com. The record looks correct in their panel, verification never succeeds, and our 422 tells them to wait 48 hours. Added a hint under the host field and a docs callout. (Cloudflare/Route 53 take the full host, so both forms are covered.) DNS failures were invisible in prod. They were logged at debug, but production log level is ERROR — so blocked egress or SERVFAIL produced zero signal for us and was misreported to the admin as "record not found yet". Infrastructure-class failures now log at warn with the DNS error code; genuinely-absent codes (ENODATA/ENOTFOUND/NXDOMAIN) stay at debug. Trim the joined TXT value. Several DNS panels pad the stored string, which otherwise fails an exact match forever with no way for the admin to tell why. Concatenation happens first, so trimming can't corrupt a chunk boundary. Still an exact match — no case-folding. Bounded the resolver. c-ares multiplies timeout across servers and retries by ~7x (measured), so the previous 5s/2-try config could block a verify request ~35s when resolvers are unreachable. Now 2s/1 try. Tests for checkDomainTxtRecord — the function that decides whether the gate opens had none. Covers exact match, chunk-joined value, match among unrelated records, padded value, near-miss, another org's token, absent record, infrastructure failure, and empty response. Verification The mechanism was also validated empirically against live DNS (not just reviewed): NXDOMAIN → false without throwing, a host with 15 unrelated TXT records → false, a genuinely published record → true found among those 15, and a 410-char record split across 2 chunks → joined and matched. Not included (deliberate) No data migration for the backfill normalizer. Migration 0268's SQL normalizer is a subset of normalizeSSODomain (no protocol/port/path/trailing-dot stripping). Prod is unaffected — its only SSO domain is already canonical (hex-verified). Replicating the full 7-step regex chain in SQL would risk introducing exactly the divergence it's meant to fix, and the self-host registration script already self-heals: it normalizes through the shared function and upserts the verified row. Periodic re-verification (verification currently never expires) is a product decision, not a bug fix — worth its own change. Type of Change Bug fix Testing 16 tests in domain-verification.test.ts (was 6); 65 across the SSO/domains surface. tsc 0, check:api-validation, check:utils, check:migrations all clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Follow-ups from a post-merge audit of verified domains (#5909). The security core came back correct — exact-match (not suffix-match) domain comparison, closed TOCTOU, 192-bit row-bound toke...

X Description: Summary Follow-ups from a post-merge audit of verified domains (#5909). The security core came back correct — exact-match (not suffix-match) domain comparison, closed TOCTOU, 192-bit row-bound toke...

Opengraph URL: https://github.com/simstudioai/sim/pull/5931

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:80aafc56-bbad-2eeb-9d1b-14939c64aa20
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id90FC:1C88A1:63F92B:8E818C:6AFB43E3
html-safe-nonceec2821d92b697f23c01917d695986f5706978884e84eef3fbd756df7d662051c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MEZDOjFDODhBMTo2M0Y5MkI6OEU4MThDOjZBRkI0M0UzIiwidmlzaXRvcl9pZCI6IjMzNjk1ODk5Nzc5NTkzMTg0OTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac5d93fe657973b99ef9c477f8fb144462f8ae1b7d09d8e4cb679df0fc892d1f0b
hovercard-subject-tagpull_request:4126915735
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5931/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-ups from a post-merge audit of verified domains (#5909). The security core came back correct — exact-match (not suffix-match) domain comparison, closed TOCTOU, 192-bit row-bound toke...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5931/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5931%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5931%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5931/files
Reloadhttps://github.com/simstudioai/sim/pull/5931/files
Reloadhttps://github.com/simstudioai/sim/pull/5931/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sso-domain-verification-followupshttps://github.com/simstudioai/sim/tree/fix/sso-domain-verification-followups
Conversation 14 https://github.com/simstudioai/sim/pull/5931
Commits 3 https://github.com/simstudioai/sim/pull/5931/commits
Checks 19 https://github.com/simstudioai/sim/pull/5931/checks
Files changed https://github.com/simstudioai/sim/pull/5931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5931/files
fix(sso): surface DNS verification failures and the provider auto-append gotcha https://github.com/simstudioai/sim/pull/5931/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/5931/files
8260b49 fix(sso): surface DNS verification failures and the provider auto-app… waleedlatif1 Jul 24, 2026 https://github.com/simstudioai/sim/pull/5931/commits/8260b4919c892da847e08642f1073d740f48e391
85d00c7 fix(sso): log DNS infrastructure failures at error so prod actually s… waleedlatif1 Jul 24, 2026 https://github.com/simstudioai/sim/pull/5931/commits/85d00c71cccae58edfc2bc18beb6ba3407e47d1e
7733c38 fix(sso): state the zone-removal rule instead of a wrong subdomain hint waleedlatif1 Jul 24, 2026 https://github.com/simstudioai/sim/pull/5931/commits/7733c38e7cf7497f61acc6c2401262f407a86fb1
Clear filters https://github.com/simstudioai/sim/pull/5931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5931/files
verified-domains.mdx https://github.com/simstudioai/sim/pull/5931/files#diff-e548e70a00459ee944c3e1c87fdc05457daa2a5795b51143c6ee85457721bbd7
domain-settings.tsx https://github.com/simstudioai/sim/pull/5931/files#diff-ab85eb66ba7d386b214d56d272660164e13cddd9703bcb356d0dfce09f2c02c4
domain-verification.test.ts https://github.com/simstudioai/sim/pull/5931/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
domain-verification.ts https://github.com/simstudioai/sim/pull/5931/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
apps/docs/content/docs/en/platform/enterprise/verified-domains.mdxhttps://github.com/simstudioai/sim/pull/5931/files#diff-e548e70a00459ee944c3e1c87fdc05457daa2a5795b51143c6ee85457721bbd7
View file https://github.com/simstudioai/sim/blob/7733c38e7cf7497f61acc6c2401262f407a86fb1/apps/docs/content/docs/en/platform/enterprise/verified-domains.mdx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5931/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5931/files#diff-e548e70a00459ee944c3e1c87fdc05457daa2a5795b51143c6ee85457721bbd7
https://github.com/simstudioai/sim/pull/5931/files#diff-e548e70a00459ee944c3e1c87fdc05457daa2a5795b51143c6ee85457721bbd7
apps/sim/ee/sso/components/domain-settings.tsxhttps://github.com/simstudioai/sim/pull/5931/files#diff-ab85eb66ba7d386b214d56d272660164e13cddd9703bcb356d0dfce09f2c02c4
View file https://github.com/simstudioai/sim/blob/7733c38e7cf7497f61acc6c2401262f407a86fb1/apps/sim/ee/sso/components/domain-settings.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5931/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5931/files#diff-ab85eb66ba7d386b214d56d272660164e13cddd9703bcb356d0dfce09f2c02c4
https://github.com/simstudioai/sim/pull/5931/files#diff-ab85eb66ba7d386b214d56d272660164e13cddd9703bcb356d0dfce09f2c02c4
https://github.com/simstudioai/sim/pull/5931/files#diff-ab85eb66ba7d386b214d56d272660164e13cddd9703bcb356d0dfce09f2c02c4
https://github.com/simstudioai/sim/pull/5931/files#diff-ab85eb66ba7d386b214d56d272660164e13cddd9703bcb356d0dfce09f2c02c4
apps/sim/lib/auth/sso/domain-verification.test.tshttps://github.com/simstudioai/sim/pull/5931/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
View file https://github.com/simstudioai/sim/blob/7733c38e7cf7497f61acc6c2401262f407a86fb1/apps/sim/lib/auth/sso/domain-verification.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5931/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5931/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
https://github.com/simstudioai/sim/pull/5931/files#diff-dd271c6e10feda2971276a50f78f804f37caf57d0b0aa17b327fd62db36de9da
apps/sim/lib/auth/sso/domain-verification.tshttps://github.com/simstudioai/sim/pull/5931/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
View file https://github.com/simstudioai/sim/blob/7733c38e7cf7497f61acc6c2401262f407a86fb1/apps/sim/lib/auth/sso/domain-verification.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5931/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5931/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
https://github.com/simstudioai/sim/pull/5931/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
https://github.com/simstudioai/sim/pull/5931/files#diff-ef69af511644a483081f2c9e1ca6289d6afbda31d1f1b50e3f2cacd80dc847a0
Please reload this pagehttps://github.com/simstudioai/sim/pull/5931/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5931/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.