René's URL Explorer Experiment


Title: refactor(skills): one definition of the skill fields across every surface by waleedlatif1 · Pull Request #5916 · simstudioai/sim · GitHub

Open Graph Title: refactor(skills): one definition of the skill fields across every surface by waleedlatif1 · Pull Request #5916 · simstudioai/sim

X Title: refactor(skills): one definition of the skill fields across every surface by waleedlatif1 · Pull Request #5916 · simstudioai/sim

Description: Summary The skill Name / Description / Content trio was implemented three times — in the canvas SkillModal, and again in each of the /skills/new and /skills/[skillId] pages. They had already drifted: modal create page detail page Name hint in the hint slot below the field missing required markers yes no no Content min-height 200 260 260 This extracts SkillFields — the DetailSection form both full-page surfaces render — and moves the shared strings into skill-copy.ts. The modal keeps ChipModalField, because .claude/rules/sim-styling.md requires every labeled field inside a ChipModalBody to be one, so it genuinely cannot share the pages' JSX. It now reads the same placeholder / hint / max-length constants instead, so the wording can no longer diverge. Also folded in: the detail page's local FieldLockTooltip moves into SkillFields, so both pages get the "why is this locked" tooltip the dynamic rich-editor import drops from three copies to two −219 / +72. Behavior No intended change other than resolving the drift: the name hint now shows on the detail page, matching create. Everything else renders as before — the canvas modal is untouched apart from sourcing its copy from constants. Type of Change Refactor Testing tsc, biome, and the six repo gates (react-query, client-boundary, api-validation, utils, boundaries, migrations) all pass; 1,195 tests in app/workspace pass. Not visually verified — worth a glance at the three surfaces to confirm the fields render identically. Checklist Code follows project style guidelines Self-reviewed my changes No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The skill Name / Description / Content trio was implemented three times — in the canvas SkillModal, and again in each of the /skills/new and /skills/[skillId] pages. They had already drifte...

X Description: Summary The skill Name / Description / Content trio was implemented three times — in the canvas SkillModal, and again in each of the /skills/new and /skills/[skillId] pages. They had already drifte...

Opengraph URL: https://github.com/simstudioai/sim/pull/5916

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:abb3789d-5a75-c9a4-9f23-f7f7bd0c7794
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBA7C:2D6147:5A5EA0:81385C:6AFB4323
html-safe-nonce8b82836319e08e1ca819d9a968e6c22ff5d0eb4b3c5c74d2038a2820e4cbd5a9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTdDOjJENjE0Nzo1QTVFQTA6ODEzODVDOjZBRkI0MzIzIiwidmlzaXRvcl9pZCI6Ijg1MjMwNTYzMDUxMTQxMzczNzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace0f70f096d696fe99d900dc57c36799c0faa6d33b48fce151fd32f031ef2a94d
hovercard-subject-tagpull_request:4121572611
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5916/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The skill Name / Description / Content trio was implemented three times — in the canvas SkillModal, and again in each of the /skills/new and /skills/[skillId] pages. They had already drifte...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5916/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5916%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5916%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5916/files
Reloadhttps://github.com/simstudioai/sim/pull/5916/files
Reloadhttps://github.com/simstudioai/sim/pull/5916/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
skills-shared-fieldshttps://github.com/simstudioai/sim/tree/skills-shared-fields
Conversation 5 https://github.com/simstudioai/sim/pull/5916
Commits 2 https://github.com/simstudioai/sim/pull/5916/commits
Checks 19 https://github.com/simstudioai/sim/pull/5916/checks
Files changed https://github.com/simstudioai/sim/pull/5916/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5916/files
refactor(skills): one definition of the skill fields across every surface https://github.com/simstudioai/sim/pull/5916/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/5916/files
6d87eee refactor(skills): one definition of the skill fields across every sur… waleedlatif1 Jul 24, 2026 https://github.com/simstudioai/sim/pull/5916/commits/6d87eee75b724afb40e833ebea8c6d948e05d727
210c288 refactor(skills): derive modal saving state, collapse the field messa… waleedlatif1 Jul 24, 2026 https://github.com/simstudioai/sim/pull/5916/commits/210c288f37b2243a374b5d697a1d200cfad19621
Clear filters https://github.com/simstudioai/sim/pull/5916/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5916/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5916/files
skill-detail.tsx https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
skill-copy.ts https://github.com/simstudioai/sim/pull/5916/files#diff-0530ca22e9120b1d1578c5626c2579ba5596fb85f185cb408fd6506f1ed95e0c
index.ts https://github.com/simstudioai/sim/pull/5916/files#diff-7c493ee94004cff6895526201d80cfdf0df5e5a5c851af138f025b238a7586be
skill-fields.tsx https://github.com/simstudioai/sim/pull/5916/files#diff-6e893f65f2535c1a3a76425f8fa6eee7e0683ecb2f752ab5eedb6ed0c1f6abe7
skill-modal.tsx https://github.com/simstudioai/sim/pull/5916/files#diff-5591b24ddac45c313b32bf2f410c26957c179527363b734a6fbeb65a34c46fa8
skill-create.tsx https://github.com/simstudioai/sim/pull/5916/files#diff-657a60ae6f86c298e06fb3939eb46d8ebf8bcd90c8eb4888b03b652686bbff3e
apps/sim/app/workspace/[workspaceId]/skills/[skillId]/skill-detail.tsxhttps://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
View file https://github.com/simstudioai/sim/blob/210c288f37b2243a374b5d697a1d200cfad19621/apps/sim/app/workspace/%5BworkspaceId%5D/skills/%5BskillId%5D/skill-detail.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5916/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
https://github.com/simstudioai/sim/pull/5916/files#diff-e8678ffbfffa6bf4f592af2c785d903c0b5a813a6dd00a101aac5fa6473bfe9c
apps/sim/app/workspace/[workspaceId]/skills/components/skill-copy.tshttps://github.com/simstudioai/sim/pull/5916/files#diff-0530ca22e9120b1d1578c5626c2579ba5596fb85f185cb408fd6506f1ed95e0c
View file https://github.com/simstudioai/sim/blob/210c288f37b2243a374b5d697a1d200cfad19621/apps/sim/app/workspace/%5BworkspaceId%5D/skills/components/skill-copy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5916/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/skills/components/skill-fields/index.tshttps://github.com/simstudioai/sim/pull/5916/files#diff-7c493ee94004cff6895526201d80cfdf0df5e5a5c851af138f025b238a7586be
View file https://github.com/simstudioai/sim/blob/210c288f37b2243a374b5d697a1d200cfad19621/apps/sim/app/workspace/%5BworkspaceId%5D/skills/components/skill-fields/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5916/{{ revealButtonHref }}
apps/sim/app/workspace/[workspaceId]/skills/components/skill-fields/skill-fields.tsxhttps://github.com/simstudioai/sim/pull/5916/files#diff-6e893f65f2535c1a3a76425f8fa6eee7e0683ecb2f752ab5eedb6ed0c1f6abe7
View file https://github.com/simstudioai/sim/blob/210c288f37b2243a374b5d697a1d200cfad19621/apps/sim/app/workspace/%5BworkspaceId%5D/skills/components/skill-fields/skill-fields.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5916/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/5916/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5916/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.