René's URL Explorer Experiment


Title: feat(sso): DNS domain verification gating org SSO registration by waleedlatif1 · Pull Request #5909 · simstudioai/sim · GitHub

Open Graph Title: feat(sso): DNS domain verification gating org SSO registration by waleedlatif1 · Pull Request #5909 · simstudioai/sim

X Title: feat(sso): DNS domain verification gating org SSO registration by waleedlatif1 · Pull Request #5909 · simstudioai/sim

Description: Sim is the collaborative workspace to build, deploy, and monitor AI agents and workflows. Used by 100,000+ builders. - feat(sso): DNS domain verification gating org SSO registration by waleedlatif1 · Pull Request #5909 · simstudioai/sim

Open Graph Description: Summary Adds org-scoped domain ownership verification (DNS TXT challenge) as the security precondition for configuring SSO — closes the first-come domain-claim vuln where any org could point anoth...

X Description: Summary Adds org-scoped domain ownership verification (DNS TXT challenge) as the security precondition for configuring SSO — closes the first-come domain-claim vuln where any org could point anoth...

Opengraph URL: https://github.com/simstudioai/sim/pull/5909

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/commits(.:format)
route-controllerpull_requests
route-actioncommits
fetch-noncev2:e42a29d3-b66e-3d8e-82e2-bc69adeb8fdd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCE36:1C88A1:56CAE3:7C2D33:6AFB4081
html-safe-nonce10c54bc583389df5bcbb746138771e3c39c9572e5676be4f9d16772bffc5171f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTM2OjFDODhBMTo1NkNBRTM6N0MyRDMzOjZBRkI0MDgxIiwidmlzaXRvcl9pZCI6IjcxMDgzMTgxMzgyMTg1Mjg4OTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc058a739331f4d26d3a66feae9e0c9b80a6b98a6bb3465c1f91d6f6a73a565c2
hovercard-subject-tagpull_request:4120900832
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/commits
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5909/commits
twitter:imagehttps://opengraph.githubassets.com/bfb784acec26b0915660ba2581bbe324b901d0ccdd68c519d73116acdb92c60b/simstudioai/sim/pull/5909
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bfb784acec26b0915660ba2581bbe324b901d0ccdd68c519d73116acdb92c60b/simstudioai/sim/pull/5909
og:image:altSummary Adds org-scoped domain ownership verification (DNS TXT challenge) as the security precondition for configuring SSO — closes the first-come domain-claim vuln where any org could point anoth...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewaleedlatif1
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-cache
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5909/commits#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5909%2Fcommits
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5909%2Fcommits
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Fcommits&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5909/commits
Reloadhttps://github.com/simstudioai/sim/pull/5909/commits
Reloadhttps://github.com/simstudioai/sim/pull/5909/commits
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
https://github.com/simstudioai/sim
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
feat/sso-domain-verificationhttps://github.com/simstudioai/sim/tree/feat/sso-domain-verification
Conversationhttps://github.com/simstudioai/sim/pull/5909
Commits18 (18)https://github.com/simstudioai/sim/pull/5909/commits
Checkshttps://github.com/simstudioai/sim/pull/5909/checks
Files changedhttps://github.com/simstudioai/sim/pull/5909/files
feat(sso): DNS domain verification gating org SSO registrationhttps://github.com/simstudioai/sim/pull/5909/commits#top
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
feat/sso-domain-verificationhttps://github.com/simstudioai/sim/tree/feat/sso-domain-verification
feat(sso): DNS domain verification gating org SSO registrationhttps://github.com/simstudioai/sim/pull/5909/commits/5f9f3e6c3caa0bea66aab4596feacd99bbc0fd25
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
5f9f3e6https://github.com/simstudioai/sim/pull/5909/commits/5f9f3e6c3caa0bea66aab4596feacd99bbc0fd25
https://github.com/simstudioai/sim/tree/5f9f3e6c3caa0bea66aab4596feacd99bbc0fd25
fix(sso): harden domain verification against concurrency + fix CI linthttps://github.com/simstudioai/sim/pull/5909/commits/c27a28a5a4d36c080690f50e67e6dfc41ba40281
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
c27a28ahttps://github.com/simstudioai/sim/pull/5909/commits/c27a28a5a4d36c080690f50e67e6dfc41ba40281
https://github.com/simstudioai/sim/tree/c27a28a5a4d36c080690f50e67e6dfc41ba40281
fix(sso): re-check domain verification before provider write (TOCTOU)https://github.com/simstudioai/sim/pull/5909/commits/6fc3224806e8c0a834698555e03906c67150f9b7
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
6fc3224https://github.com/simstudioai/sim/pull/5909/commits/6fc3224806e8c0a834698555e03906c67150f9b7
https://github.com/simstudioai/sim/tree/6fc3224806e8c0a834698555e03906c67150f9b7
fix(sso): stop rotating verification token on idempotent re-addhttps://github.com/simstudioai/sim/pull/5909/commits/16f92b55ec79817c1bfe0a8572194ab79cf21837
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
16f92b5https://github.com/simstudioai/sim/pull/5909/commits/16f92b55ec79817c1bfe0a8572194ab79cf21837
https://github.com/simstudioai/sim/tree/16f92b55ec79817c1bfe0a8572194ab79cf21837
fix(sso): close register TOCTOU with compensating delete + harden edgeshttps://github.com/simstudioai/sim/pull/5909/commits/1995af7e82fb3e1ebaed8a0929721808c6d4dda3
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
1995af7https://github.com/simstudioai/sim/pull/5909/commits/1995af7e82fb3e1ebaed8a0929721808c6d4dda3
https://github.com/simstudioai/sim/tree/1995af7e82fb3e1ebaed8a0929721808c6d4dda3
fix(sso): redact domain tokens from non-admins + fix script stale-updatehttps://github.com/simstudioai/sim/pull/5909/commits/99b4f13032da0cb78b0c807bbd35150f9d9eef86
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
99b4f13https://github.com/simstudioai/sim/pull/5909/commits/99b4f13032da0cb78b0c807bbd35150f9d9eef86
https://github.com/simstudioai/sim/tree/99b4f13032da0cb78b0c807bbd35150f9d9eef86
docs(sso): drop unshipped enforce-SSO / auto-join copy from verified domainshttps://github.com/simstudioai/sim/pull/5909/commits/64fceab13581a6e12a083111898614407fcc28b2
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
64fceabhttps://github.com/simstudioai/sim/pull/5909/commits/64fceab13581a6e12a083111898614407fcc28b2
https://github.com/simstudioai/sim/tree/64fceab13581a6e12a083111898614407fcc28b2
fix(sso): guard rollback to new providers only + Enterprise-gate domain removalhttps://github.com/simstudioai/sim/pull/5909/commits/1e33e8911aab382a5a5a2d15bf5560e2b0a3e610
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
1e33e89https://github.com/simstudioai/sim/pull/5909/commits/1e33e8911aab382a5a5a2d15bf5560e2b0a3e610
https://github.com/simstudioai/sim/tree/1e33e8911aab382a5a5a2d15bf5560e2b0a3e610
fix(sso): roll back the SSO provider by row id, not logical keyshttps://github.com/simstudioai/sim/pull/5909/commits/44bf72c4cc44eb47fc1180adbea9bd8f8597f5a2
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
44bf72chttps://github.com/simstudioai/sim/pull/5909/commits/44bf72c4cc44eb47fc1180adbea9bd8f8597f5a2
https://github.com/simstudioai/sim/tree/44bf72c4cc44eb47fc1180adbea9bd8f8597f5a2
chore(sso): final-review polish — trim script read, unify copy, doc migration edgehttps://github.com/simstudioai/sim/pull/5909/commits/98c54f6d8e72beebbd224edaf53947edb1617022
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
98c54f6https://github.com/simstudioai/sim/pull/5909/commits/98c54f6d8e72beebbd224edaf53947edb1617022
https://github.com/simstudioai/sim/tree/98c54f6d8e72beebbd224edaf53947edb1617022
fix(sso): apply attribute mapping + make SSO edit work; drop dead guardhttps://github.com/simstudioai/sim/pull/5909/commits/b4c7a34793c0485ced87501e8793abb261bde0e0
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b4c7a34https://github.com/simstudioai/sim/pull/5909/commits/b4c7a34793c0485ced87501e8793abb261bde0e0
https://github.com/simstudioai/sim/tree/b4c7a34793c0485ced87501e8793abb261bde0e0
fix(sso): require null org on personal-mode provider lookups (gate bypass)https://github.com/simstudioai/sim/pull/5909/commits/bb9637a58bfce7e33cc1268ca222c0ae084723ba
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
bb9637ahttps://github.com/simstudioai/sim/pull/5909/commits/bb9637a58bfce7e33cc1268ca222c0ae084723ba
https://github.com/simstudioai/sim/tree/bb9637a58bfce7e33cc1268ca222c0ae084723ba
fix(sso): script updates the observed provider by id, not providerIdhttps://github.com/simstudioai/sim/pull/5909/commits/464e7e0247f9e46b2ed4386978bc85e13f9f6c2b
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
464e7e0https://github.com/simstudioai/sim/pull/5909/commits/464e7e0247f9e46b2ed4386978bc85e13f9f6c2b
https://github.com/simstudioai/sim/tree/464e7e0247f9e46b2ed4386978bc85e13f9f6c2b
fix(sso): script upserts provider via delete-then-insert (no unique constraint)https://github.com/simstudioai/sim/pull/5909/commits/b37655e7dbeaa6e8137230ccdc113c55dba70aba
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
b37655ehttps://github.com/simstudioai/sim/pull/5909/commits/b37655e7dbeaa6e8137230ccdc113c55dba70aba
https://github.com/simstudioai/sim/tree/b37655e7dbeaa6e8137230ccdc113c55dba70aba
fix(sso): guard compensating-delete row id so rollback can't silently no-ophttps://github.com/simstudioai/sim/pull/5909/commits/c106d87bae4fe60890139764497089f142bf1c9b
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
c106d87https://github.com/simstudioai/sim/pull/5909/commits/c106d87bae4fe60890139764497089f142bf1c9b
https://github.com/simstudioai/sim/tree/c106d87bae4fe60890139764497089f142bf1c9b
Merge remote-tracking branch 'origin/staging' into feat/sso-domain-verificationhttps://github.com/simstudioai/sim/pull/5909/commits/c03f38942216e2ac7a86f18acbc61a9510841855
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
c03f389https://github.com/simstudioai/sim/pull/5909/commits/c03f38942216e2ac7a86f18acbc61a9510841855
https://github.com/simstudioai/sim/tree/c03f38942216e2ac7a86f18acbc61a9510841855
chore(sso): regenerate migration as 0268 after merging staginghttps://github.com/simstudioai/sim/pull/5909/commits/dce6d6393b3ad704214baa15d0a5ae178b5115af
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
dce6d63https://github.com/simstudioai/sim/pull/5909/commits/dce6d6393b3ad704214baa15d0a5ae178b5115af
https://github.com/simstudioai/sim/tree/dce6d6393b3ad704214baa15d0a5ae178b5115af
refactor(sso): share normalizeSSODomain via @sim/utils so script matches gatehttps://github.com/simstudioai/sim/pull/5909/commits/085a962345de9945bee4f2aa83387081b0c7d01a
https://github.com/waleedlatif1
waleedlatif1https://github.com/simstudioai/sim/commits?author=waleedlatif1
085a962https://github.com/simstudioai/sim/pull/5909/commits/085a962345de9945bee4f2aa83387081b0c7d01a
https://github.com/simstudioai/sim/tree/085a962345de9945bee4f2aa83387081b0c7d01a
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.