Title: fix(tables): sniff CSV delimiter and capture the real header row on import by waleedlatif1 · Pull Request #5888 · simstudioai/sim · GitHub
Open Graph Title: fix(tables): sniff CSV delimiter and capture the real header row on import by waleedlatif1 · Pull Request #5888 · simstudioai/sim
X Title: fix(tables): sniff CSV delimiter and capture the real header row on import by waleedlatif1 · Pull Request #5888 · simstudioai/sim
Description: Summary CSV table import derived the delimiter from the file extension only, so semicolon-delimited exports (European-locale Excel) parsed as a single column — the reported "alarms-export" bug. Now the delimiter is sniffed from the file head (, ; \t |), quote-aware, with the extension only as a fallback. Header derivation used Object.keys(rows[0]); with relax_column_count a ragged/sparse first data row dropped its trailing columns from schema inference and mapping. The true header row is now captured via the csv-parse columns callback on every path — fixes the "sparse csv didn't work" report. New detectCsvDelimiter (trial-parse each candidate, pick most columns, tie-break on row-width consistency) mirrors PapaParse/csv.Sniffer, and sniffCsvDelimiterFromStream (64KB peek-then-replay) keeps the streaming paths memory-bounded on multi-GB files. Wired into all consumers: create route, append/replace route, background runner, client dialog preview, and parseFileRows (copilot). Type of Change Bug fix Testing 442 table + route tests pass (49 new/updated covering delimiter detection, ragged headers, stream replay, error/destroy/empty edge cases) Verified against the real 61 MB alarms-export file: comma → 1 column, semicolon → 34 columns / 1249 records; sniffer detects ; Typecheck clean, biome clean, check:api-validation passes Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary CSV table import derived the delimiter from the file extension only, so semicolon-delimited exports (European-locale Excel) parsed as a single column — the reported "alarms-export&quo...
X Description: Summary CSV table import derived the delimiter from the file extension only, so semicolon-delimited exports (European-locale Excel) parsed as a single column — the reported "alarms-export...
Opengraph URL: https://github.com/simstudioai/sim/pull/5888
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/commits/:range(.:format) |
| route-controller | pull_requests |
| route-action | commits |
| fetch-nonce | v2:2ebdf0ab-7474-4ebd-ea42-42037270024d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C11C:2DD98A:1FB4E49:2AB8C94:6A6555D1 |
| html-safe-nonce | 20c89e6ac21f7542b3092cbb1d4a4e82d715a2148b2c3509678874c54cc83d50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTFDOjJERDk4QToxRkI0RTQ5OjJBQjhDOTQ6NkE2NTU1RDEiLCJ2aXNpdG9yX2lkIjoiNDE4NTEyMTY3ODQxOTEyMjczIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 65ed1a4bce7fb746522574e7ffdbf901891005a77214f6a606fea4f7683ce02a |
| hovercard-subject-tag | pull_request:4117901548 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5888/commits/4312df9c936ca9d0ad1e31dd601a827991b9f7ae |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary CSV table import derived the delimiter from the file extension only, so semicolon-delimited exports (European-locale Excel) parsed as a single column — the reported "alarms-export&quo... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width