Title: fix(custom-blocks): stop image icons blowing up on class-sized surfaces by TheodoreSpeaks · Pull Request #5878 · simstudioai/sim · GitHub
Open Graph Title: fix(custom-blocks): stop image icons blowing up on class-sized surfaces by TheodoreSpeaks · Pull Request #5878 · simstudioai/sim
X Title: fix(custom-blocks): stop image icons blowing up on class-sized surfaces by TheodoreSpeaks · Pull Request #5878 · simstudioai/sim
Description: Summary Custom block image icons blew up to full container width on any surface that sizes block icons with a class (size-[14px]) instead of a fixed-size tile wrapper — hit the @-mention dropdown, chat context mention chips, and the files editor mention/slash menus Root cause: makeImageIcon appended a trailing size-full that won the twMerge conflict against every consumer size class; each surface had to be point-patched with inline styles (like the earlier subagent tool-row fix) Inverted the precedence: size-full is now only the default and any consumer size class or inline style wins; tile surfaces that want the image to fill (canvas node, toolbar, search modal, editor headers, terminal, trace view, etc.) opt in with [&_img]:size-full on their fixed wrapper — a missed surface now renders a small icon instead of a page-breaking image Added overflow-hidden to the fill tiles so image corners clip to the tile rounding, brought connection-blocks into the fill contract, sized img icons in the files suggestion menus, and reverted the now-unneeded inline-style workaround in the chat tool-call row Type of Change Bug fix Testing Tested manually against a live workspace with a published custom block: @-mention dropdown renders the uploaded icon at 14px, toolbar tile still fills 16px, canvas tile precedence verified at 24px. lint:check, tsc --noEmit, check:api-validation:strict, and custom-block unit tests all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Custom block image icons blew up to full container width on any surface that sizes block icons with a class (size-[14px]) instead of a fixed-size tile wrapper — hit the @-mention dropdown,...
X Description: Summary Custom block image icons blew up to full container width on any surface that sizes block icons with a class (size-[14px]) instead of a fixed-size tile wrapper — hit the @-mention dropdown,...
Opengraph URL: https://github.com/simstudioai/sim/pull/5878
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:24ca68a0-68f0-d2fa-95d9-119a6aa09f64 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 944C:12CC5:289182B:3842215:6A632B7C |
| html-safe-nonce | d64874957a1eb7531d7781942d8d3a8853a23bd2b1b6246508d3fdc33b650591 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDRDOjEyQ0M1OjI4OTE4MkI6Mzg0MjIxNTo2QTYzMkI3QyIsInZpc2l0b3JfaWQiOiIyOTIxNjE4Mjc3OTA1OTY5ODgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 9e5fe9ee1d6f7533bca226b0b5747d5001790b9e3cb8b6daa1f0f55795190bf4 |
| hovercard-subject-tag | pull_request:4113361283 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5878/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary Custom block image icons blew up to full container width on any surface that sizes block icons with a class (size-[14px]) instead of a fixed-size tile wrapper — hit the @-mention dropdown,... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 30c644d502bce6cd2e59f9000b4744f2b64819abea8e8f959b18e3ad793125aa |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 331492a48ebd91d66ef2de38e1901bb911c9fe9b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width