René's URL Explorer Experiment

Title: improvement(tests+ci): phase 3 — shared-mock convergence completion and CI runner-minute cuts by waleedlatif1 · Pull Request #5875 · simstudioai/sim · GitHub

Open Graph Title: improvement(tests+ci): phase 3 — shared-mock convergence completion and CI runner-minute cuts by waleedlatif1 · Pull Request #5875 · simstudioai/sim

X Title: improvement(tests+ci): phase 3 — shared-mock convergence completion and CI runner-minute cuts by waleedlatif1 · Pull Request #5875 · simstudioai/sim

Description: Summary Shared-mock infrastructure (@sim/testing): complete stateful mocks — with set*/reset* APIs and 20 contract tests — for @/lib/core/config/env, @/lib/core/utils/urls (6 missing exports added), @/lib/core/config/redis, and @/lib/environment/utils, all installed globally in vitest.setup (same proven pattern as the db and env-flags mocks from #5856/#5871). Redundant-mock dedup (~250 test files, net ~−800 lines): deleted file-local vi.mock factories that replicated the global mocks (95 @sim/db replicas in lib/ alone, 43 in app/) and converted customizing factories to configuring the shared mocks. ~40 files keep custom factories with documented reasons (bespoke assertion shapes, import-time env reads, tables re-exported from @sim/db). CI runner-minute cuts (verified against 600-run history, no required-check risk — rulesets were read directly and contain none): Fail-open dedup gate for promotion-PR test runs (39 duplicate runs measured in 5 days; ≈10,900 vcpu-min/mo). Every failure path runs the tests; worst case is status quo plus a small probe job companion-pr-check concurrency (superseded runs raced the sticky-comment upsert) Two trivial jobs right-sized 4vcpu→2vcpu Measured flip-readiness (honest): 3× shuffled isolate: false runs still fail 51–59 files (unchanged vs baseline) — the remaining blockers are the justified custom factories and the upstream vitest mock-registry bug (vitest-dev/vitest#10290, our repro posted). This PR's value is manageability + bill + correctness, not yet the flip. Type of Change Improvement Testing Full apps/sim suite green (13732/13733; sole failure is the known local ripgrep dependency, green in CI). packages/testing 39/39 incl. new contract tests. tsc clean in both packages; biome clean. Dedup gate logic reviewed line-by-line (fail-open on every error path; jq tested against a real run payload); it cannot be exercised until a real promotion-PR event. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Shared-mock infrastructure (@sim/testing): complete stateful mocks — with set*/reset* APIs and 20 contract tests — for @/lib/core/config/env, @/lib/core/utils/urls (6 missing exports added)...

X Description: Summary Shared-mock infrastructure (@sim/testing): complete stateful mocks — with set*/reset* APIs and 20 contract tests — for @/lib/core/config/env, @/lib/core/utils/urls (6 missing exports added)...

Opengraph URL: https://github.com/simstudioai/sim/pull/5875

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width