Title: fix(workflow): align condition/router handles with their rows by waleedlatif1 · Pull Request #5831 · simstudioai/sim · GitHub
Open Graph Title: fix(workflow): align condition/router handles with their rows by waleedlatif1 · Pull Request #5831 · simstudioai/sim
X Title: fix(workflow): align condition/router handles with their rows by waleedlatif1 · Pull Request #5831 · simstudioai/sim
Description: Summary Fix condition/router source handles drifting out of sync with their rows on blocks with many branches Handles were positioned with a 29px per-row pitch while rows actually render at 28px (20px row + 8px gap), so every extra branch added ~1px of cumulative drift; first-handle offset was also 1px off (60 vs 59) Corrected CONDITION_START_Y (60 → 59) and CONDITION_ROW_HEIGHT (29 → 28) in the shared dimensions source of truth, which fixes the editor renderer, the preview renderer, and autolayout's handle-Y estimate together Pinned the summary row height to an explicit h-5 (same 20px the text-sm line box already produced) in both row renderers and documented it as part of the handle-position contract so CSS and constants can't silently drift apart again Type of Change Bug fix Testing Verified geometry against rendered CSS (header 40px + 1px divider + 8px padding + 20px rows with 8px gaps); drift math matches the reported screenshot (~12px at 12 branches) Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Fix condition/router source handles drifting out of sync with their rows on blocks with many branches Handles were positioned with a 29px per-row pitch while rows actually render at 28px (...
X Description: Summary Fix condition/router source handles drifting out of sync with their rows on blocks with many branches Handles were positioned with a 29px per-row pitch while rows actually render at 28px (...
Opengraph URL: https://github.com/simstudioai/sim/pull/5831
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:8b25a725-57fb-15dd-bba0-2e491df470fa |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | AF88:19A5AC:185C2C:2291A1:6A636453 |
| html-safe-nonce | 4419a8617c266f87c7bf47e5971ebb2421e9a22ead5810410b5ffe14945bcfe1 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjg4OjE5QTVBQzoxODVDMkM6MjI5MUExOjZBNjM2NDUzIiwidmlzaXRvcl9pZCI6IjQyNDA2NDQyODA4NDIxNTA5OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | c178a2a05faf3bb6c9824aa0635a01707b0b48a46f1832919bec92d0e1a32f56 |
| hovercard-subject-tag | pull_request:4104231672 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5831/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Fix condition/router source handles drifting out of sync with their rows on blocks with many branches Handles were positioned with a 29px per-row pitch while rows actually render at 28px (... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 669d3fcd704a169521d2b6431762f95a6878a9e8ccaf0fd5f2d0802fc5b971f9 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 20da292f132ff51328be50073854259f417052c1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width