Title: fix(mcp): don't blank the MCP tools page when tool discovery fails by waleedlatif1 · Pull Request #5816 · simstudioai/sim · GitHub
Open Graph Title: fix(mcp): don't blank the MCP tools page when tool discovery fails by waleedlatif1 · Pull Request #5816 · simstudioai/sim
X Title: fix(mcp): don't blank the MCP tools page when tool discovery fails by waleedlatif1 · Pull Request #5816 · simstudioai/sim
Description: Summary A tool-discovery failure (one slow/failing server — e.g. a stalled streamable-HTTP transport timing out) replaced the entire MCP tools server list with a centered error banner, hiding every server including healthy/authorizable ones. Root cause: const error = toolsError || serversError gated the whole list, conflating a tool-discovery failure with a server-list-load failure. Either one blanked the page. Fix: gate the full-list replacement on serversError only (the list genuinely failing to load). When the servers loaded, always render the list — each row already surfaces its own discovery state via toolsStateByServer (per-row status), with a small non-blocking notice above the list when discovery had issues. This restores the per-server isolation intent: one bad server can't hide the others, and you can still act on the list (reconnect an OAuth server, retry, etc.). Type of Change Bug fix (UX resilience) Testing Type-checks + biome clean. Audited the full discovery lifecycle (hook useMcpToolsQuery per-server useQueries isolation, the discover route, the service single/all-server paths, and every render state): page never blanks on a tool-discovery failure in any of loading / no-servers / servers+toolsError / serversError / detail-view; per-server isolation intact; no other code hides the list; no unused vars or regressions. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary A tool-discovery failure (one slow/failing server — e.g. a stalled streamable-HTTP transport timing out) replaced the entire MCP tools server list with a centered error banner, hiding ever...
X Description: Summary A tool-discovery failure (one slow/failing server — e.g. a stalled streamable-HTTP transport timing out) replaced the entire MCP tools server list with a centered error banner, hiding ever...
Opengraph URL: https://github.com/simstudioai/sim/pull/5816
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b76cce92-2ff7-a78a-3720-70b3100d0e5b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A24E:1E946E:29CAC45:3A1AFF4:6A632CFB |
| html-safe-nonce | 5ec35d42f7dcd974a37906155f8f113c7f0d20aaadedd0f468b7311b154467c5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMjRFOjFFOTQ2RToyOUNBQzQ1OjNBMUFGRjQ6NkE2MzJDRkIiLCJ2aXNpdG9yX2lkIjoiMzcxNjQwOTc3MjUxMjMyNDg1OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 68cc4210d03f0c83773f70fa92f8c35cf5921ae114b537f92b5d564e1fb20f40 |
| hovercard-subject-tag | pull_request:4103014471 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5816/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary A tool-discovery failure (one slow/failing server — e.g. a stalled streamable-HTTP transport timing out) replaced the entire MCP tools server list with a centered error banner, hiding ever... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 30c644d502bce6cd2e59f9000b4744f2b64819abea8e8f959b18e3ad793125aa |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 331492a48ebd91d66ef2de38e1901bb911c9fe9b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width