Title: improvement(ux): submit on Enter in chip modals and advance table rows by waleedlatif1 · Pull Request #5781 · simstudioai/sim · GitHub
Open Graph Title: improvement(ux): submit on Enter in chip modals and advance table rows by waleedlatif1 · Pull Request #5781 · simstudioai/sim
X Title: improvement(ux): submit on Enter in chip modals and advance table rows by waleedlatif1 · Pull Request #5781 · simstudioai/sim
Description: Summary ChipModal now fires its footer's primary action when Enter is pressed in any single-line input/email field — Enter-to-submit goes from opt-in (a per-field onSubmit most modals forgot to wire) to automatic across every chip modal. Guards IME composition and respects the primary's disabled state. Enter never triggers a destructive primary action from a text field — ChipModalFooter skips registering variant: 'destructive' primaries. Closes the latent "Enter-to-delete from a textbox" footgun. Added a submitOnEnter opt-out for config-knob fields inside larger forms (applied to the scheduled-task "Number of runs" input so Enter doesn't submit the modal prematurely). Workflow Table sub-block: pressing Enter in a cell now advances to the same column in the next row (spreadsheet-style), matching the data-tables grid convention. Skips while a tag/env-var dropdown is open (Enter selects there) and during IME composition. Previously Enter was a no-op. Type of Change Improvement / enhancement Testing Tested manually. tsc (emcn + app) and full lint:check green. Not covered by automated tests (emcn's test env is node-only, no jsdom). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary ChipModal now fires its footer's primary action when Enter is pressed in any single-line input/email field — Enter-to-submit goes from opt-in (a per-field onSubmit most modals forgot t...
X Description: Summary ChipModal now fires its footer's primary action when Enter is pressed in any single-line input/email field — Enter-to-submit goes from opt-in (a per-field onSubmit most modals forg...
Opengraph URL: https://github.com/simstudioai/sim/pull/5781
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:aa4f13af-7974-1f1e-d1b5-67685c22661b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB72:16F27B:156A165:1EAD1F1:6A634DAC |
| html-safe-nonce | e272d15b19779c2f964c91e52f3f33beb71e42875a92d3420019fd09055f6b44 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjcyOjE2RjI3QjoxNTZBMTY1OjFFQUQxRjE6NkE2MzREQUMiLCJ2aXNpdG9yX2lkIjoiNTQ2ODMzNTk4NjM0MTc5MzE5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | ea86f1a0c1d596399b6dbe307c470f1169a419ec9f24b5bfecc17c14fa8ed500 |
| hovercard-subject-tag | pull_request:4095154531 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5781/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary ChipModal now fires its footer's primary action when Enter is pressed in any single-line input/email field — Enter-to-submit goes from opt-in (a per-field onSubmit most modals forgot t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 59e55daad7174ca59d63c6974d58276ccb5477442e550bebb3c035e1bef11c94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 990295d92a4cc7b63fbbd83a046217cd7d77d49c |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width