Title: fix(oauth): coalesce slack token refresh per installation and preserve provider refresh errors by TheodoreSpeaks · Pull Request #5723 · simstudioai/sim · GitHub
Open Graph Title: fix(oauth): coalesce slack token refresh per installation and preserve provider refresh errors by TheodoreSpeaks · Pull Request #5723 · simstudioai/sim
X Title: fix(oauth): coalesce slack token refresh per installation and preserve provider refresh errors by TheodoreSpeaks · Pull Request #5723 · simstudioai/sim
Description: Summary Slack bot tokens are per-installation (team × app), but every connect creates a new `account` row holding a copy of the same rotating token chain — each row refreshed independently and revoked the siblings' copies, causing intermittent `token_revoked` failures Key Slack refresh coalescing (singleflight + leader lock) and terminal-error dead flags per installation (`oauth:refresh:slack:`) instead of per account row Leader refreshes using the freshest sibling's refresh token and fans the new chain out to all sibling rows of the team, so stale rows self-heal; fresh connects propagate their newly issued chain the same way Slack lock budgets (follower wait + lock TTL) sized past the 15s provider timeout so followers observe slow-but-successful refreshes Legacy pasted `slack-bot-*` rows keep per-row behavior Add `token_revoked` to the terminal refresh-error set Type of Change Bug fix Testing Added unit coverage for installation-keyed locking, freshest-chain selection, fan-out writes, legacy row behavior, and installation-scoped dead flags. `bun run lint`, `bun run check:api-validation:strict`, and `tsc --noEmit` pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Slack bot tokens are per-installation (team × app), but every connect creates a new `account` row holding a copy of the same rotating token chain — each row refreshed independently and rev...
X Description: Summary Slack bot tokens are per-installation (team × app), but every connect creates a new `account` row holding a copy of the same rotating token chain — each row refreshed independently and rev...
Opengraph URL: https://github.com/simstudioai/sim/pull/5723
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2b7b2a63-f6f2-4d28-a6c2-5ae8d432f5bd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A4F8:188F24:1056CA0:1799364:6A633220 |
| html-safe-nonce | 7f8b791f19b018545a801d4ccde60a03cd1a8f69d0a2ce71af4270f1cea05c68 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNEY4OjE4OEYyNDoxMDU2Q0EwOjE3OTkzNjQ6NkE2MzMyMjAiLCJ2aXNpdG9yX2lkIjoiMzY5NjcxNTAwNTU4NzA5MjgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 743219e4234a83175cef93147c1f44171019d8c3466fc954d1d90aa0f49c4f00 |
| hovercard-subject-tag | pull_request:4072516724 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5723/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary Slack bot tokens are per-installation (team × app), but every connect creates a new `account` row holding a copy of the same rotating token chain — each row refreshed independently and rev... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | df6e1c2adcceb061ec8c4106a1b34f38280f08e13f2b195c661c202834cbc3b1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 822a0ff2a479845adcdd40a1a7b1734a56e05818 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width