Title: fix(settings): restore header shell on workspace credit-usage page by waleedlatif1 · Pull Request #5663 · simstudioai/sim · GitHub
Open Graph Title: fix(settings): restore header shell on workspace credit-usage page by waleedlatif1 · Pull Request #5663 · simstudioai/sim
X Title: fix(settings): restore header shell on workspace credit-usage page by waleedlatif1 · Pull Request #5663 · simstudioai/sim
Description: Summary fixes the workspace settings/billing/credit-usage page rendering with no header, title, or scroll region (user-reported: page "won't scroll") regressed in #5545: CreditUsageView moved from the self-chromed CredentialDetailLayout to SettingsPanel, which only registers header config into SettingsHeaderProvider context — the chrome renders in SettingsHeaderShell the workspace plane mounts that shell in settings/[section]/layout.tsx, but billing/credit-usage is a static route outside [section], so the panel registered into nothing and the page rendered bare children with no scroll container (the account/org planes mount the shell at their settings root, which is why the same view works there) fix: mount SettingsHeaderProvider + SettingsHeaderShell in a route-level layout.tsx for billing/credit-usage, mirroring [section]/layout.tsx; this also covers the route's loading.tsx fallback audited every other SettingsPanel consumer (workspace sections, account/org renderers, ee components) — all render under a shell; this route was the only orphan Type of Change Bug fix Testing Typecheck clean, credit-usage + billing tests pass Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary fixes the workspace settings/billing/credit-usage page rendering with no header, title, or scroll region (user-reported: page "won't scroll") regressed in #5545: CreditUsageV...
X Description: Summary fixes the workspace settings/billing/credit-usage page rendering with no header, title, or scroll region (user-reported: page "won't scroll") regressed in #5545: ...
Opengraph URL: https://github.com/simstudioai/sim/pull/5663
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:9b185052-2661-46a7-e4e3-facb275dc3ec |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D6EE:11DC7C:154660F:1D00A09:6AFB75E5 |
| html-safe-nonce | a414e8d6003a124e7f92237feb44d31ab260ea1b833fc1f344f82d6c1d4a7dc3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENkVFOjExREM3QzoxNTQ2NjBGOjFEMDBBMDk6NkFGQjc1RTUiLCJ2aXNpdG9yX2lkIjoiNTgzMjg3NDQzMjI3MTE4NTM4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 85ad33b990e2fc897a4f630c53186b6b3427e49a142f4a3d2dc9561366f5c857 |
| hovercard-subject-tag | pull_request:4049163274 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5663/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary fixes the workspace settings/billing/credit-usage page rendering with no header, title, or scroll region (user-reported: page "won't scroll") regressed in #5545: CreditUsageV... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 0e29e7974fdda2feeaf5c891efd4b23b0734b23480232b62c7bdef13f40b5b48 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2e8872b770cc4d5d0cc1f2026afab747a268e2ce |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width