Title: fix(files-upload): enforce workspace authorization on mothership uploads by waleedlatif1 · Pull Request #5604 · simstudioai/sim · GitHub
Open Graph Title: fix(files-upload): enforce workspace authorization on mothership uploads by waleedlatif1 · Pull Request #5604 · simstudioai/sim
X Title: fix(files-upload): enforce workspace authorization on mothership uploads by waleedlatif1 · Pull Request #5604 · simstudioai/sim
Description: Summary The mothership context in POST /api/files/upload was missing the workspace permission check that every other context (workspace, knowledge-base, execution) already enforces Added the same write/admin getUserEntityPermissions gate, plus the storage quota check other paths also apply Matches the authorization already enforced for mothership in the multipart and presigned upload routes Type of Change Bug fix (security) Testing Added a Mothership Context Permission Gate test suite covering missing workspaceId, non-member, read-only member, over-quota, and write/admin-permission cases. Full route test suite passes (25/25). Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary The mothership context in POST /api/files/upload was missing the workspace permission check that every other context (workspace, knowledge-base, execution) already enforces Added the same ...
X Description: Summary The mothership context in POST /api/files/upload was missing the workspace permission check that every other context (workspace, knowledge-base, execution) already enforces Added the same ...
Opengraph URL: https://github.com/simstudioai/sim/pull/5604
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:5972f1f0-0e9d-9ef1-5e18-6728e715558d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EB54:19AC88:397DE5:50510F:6A63978A |
| html-safe-nonce | 75c418067a7938e7d832132070df849796bbd79206d0fdea92494021ab4ebc5d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQjU0OjE5QUM4ODozOTdERTU6NTA1MTBGOjZBNjM5NzhBIiwidmlzaXRvcl9pZCI6IjEyOTMyNTQ0NTYwNzI0NDM3ODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d7ad06d3d1cbc7c3b11c61c1520900a57d0f9df10a272d10c62311dde73cf164 |
| hovercard-subject-tag | pull_request:4036487549 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5604/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary The mothership context in POST /api/files/upload was missing the workspace permission check that every other context (workspace, knowledge-base, execution) already enforces Added the same ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ca676e17c4da4532dc68541e9fc874034ae840c26b5f34da7f1c42d9a600659 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 3a0a9f049e072eb8e5795dfddcefdba9e277501d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width