Title: fix(knowledge): accept relative internal file URLs in document processor by TheodoreSpeaks · Pull Request #5499 · simstudioai/sim · GitHub
Open Graph Title: fix(knowledge): accept relative internal file URLs in document processor by TheodoreSpeaks · Pull Request #5499 · simstudioai/sim
X Title: fix(knowledge): accept relative internal file URLs in document processor by TheodoreSpeaks · Pull Request #5499 · simstudioai/sim
Description: Summary KB document processing sporadically failed with Unsupported fileUrl scheme: only data: URIs and http(s):// URLs are allowed on knowledge-process-document runs. Root cause: some ingestion paths store an app-relative internal URL (/api/files/serve/...?context=workspace). The download layer (downloadFileFromUrl) already resolves these directly against storage, but parseWithFileParser and downloadFileForBase64 applied a stricter scheme guard that threw before the URL ever reached the downloader. Fix at the consumer: both guards now accept internal URLs via isInternalFileUrl(...) and route them through the existing downloader, matching how the OCR path already behaves. Still fails fast on genuinely unsupported schemes. Consumer-side fix covers every producer and lets already-failed documents recover on retry with no data migration. Security is unchanged — the downloader still authorizes the resolved storage key against the billed actor and derives context from the trusted key prefix. Type of Change Bug fix Testing Tested manually. Ran bun run lint (no changes) and bun run check:api-validation:strict (passed). Typecheck clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary KB document processing sporadically failed with Unsupported fileUrl scheme: only data: URIs and http(s):// URLs are allowed on knowledge-process-document runs. Root cause: some ingestion p...
X Description: Summary KB document processing sporadically failed with Unsupported fileUrl scheme: only data: URIs and http(s):// URLs are allowed on knowledge-process-document runs. Root cause: some ingestion p...
Opengraph URL: https://github.com/simstudioai/sim/pull/5499
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:37eddcf7-b965-26ce-aa64-1e75aafaa25a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C9E6:305156:1DE597:29BCFE:6AFB500D |
| html-safe-nonce | 678f93b16d9edfb8dce7e777b862f442bf8c1bc213d0879bb4156131cda60439 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOUU2OjMwNTE1NjoxREU1OTc6MjlCQ0ZFOjZBRkI1MDBEIiwidmlzaXRvcl9pZCI6IjY2MTU5MjgyODI2NTI4MjM1NjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0e759089452c6ee9620107aca2008e5d09b9fdd2ddf8860857de024143fe81ff |
| hovercard-subject-tag | pull_request:4010872469 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5499/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary KB document processing sporadically failed with Unsupported fileUrl scheme: only data: URIs and http(s):// URLs are allowed on knowledge-process-document runs. Root cause: some ingestion p... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width