René's URL Explorer Experiment


Title: refactor(uploads): hoist execution permission check, dedupe permission-gate tests by waleedlatif1 · Pull Request #5420 · simstudioai/sim · GitHub

Open Graph Title: refactor(uploads): hoist execution permission check, dedupe permission-gate tests by waleedlatif1 · Pull Request #5420 · simstudioai/sim

X Title: refactor(uploads): hoist execution permission check, dedupe permission-gate tests by waleedlatif1 · Pull Request #5420 · simstudioai/sim

Description: Summary Follow-up to #5404 (already merged) — applying an explicit /cleanup + /simplify final gate on that diff surfaced two small, real, low-risk quality issues that this PR fixes: apps/sim/app/api/files/upload/route.ts: the new execution-context workspace permission check (getUserEntityPermissions) was re-run once per uploaded file inside the upload loop, even though workspaceId (and thus the permission result) is invariant for the whole request. Hoisted the workflowId/executionId/workspaceId validation + permission check above the loop so it runs once per request instead of once per file. apps/sim/app/api/files/upload/route.test.ts: the 5 new "Execution Context Permission Gate" tests repeated identical request-construction boilerplate. Extracted a shared postExecutionUpload() helper. No behavior change — same validation order, same error messages/status codes, same mocked call assertions. /cleanup's other 6 sub-passes (effects/memo/callbacks/state/react-query/emcn/url-state) had nothing to flag since this diff is backend-only (no React/UI code). A /simplify "reuse" suggestion to swap the permission check for a different existing helper (verifyExecutionFileAccess) was deliberately not applied — it would make the execution branch inconsistent with the 4 other context branches in the same file that use the identical getUserEntityPermissions + 403 pattern; an altitude-focused review agent independently confirmed the current pattern is the correct, consistent one for this file. Test plan bun vitest run apps/sim/app/api/files/upload/route.test.ts — 19/19 pass apps/sim type-check clean (bun run type-check in apps/sim) bunx biome check clean on both touched files bun run check:api-validation — audit passed

Open Graph Description: Summary Follow-up to #5404 (already merged) — applying an explicit /cleanup + /simplify final gate on that diff surfaced two small, real, low-risk quality issues that this PR fixes: apps/sim/app/a...

X Description: Summary Follow-up to #5404 (already merged) — applying an explicit /cleanup + /simplify final gate on that diff surfaced two small, real, low-risk quality issues that this PR fixes: apps/sim/app/a...

Opengraph URL: https://github.com/simstudioai/sim/pull/5420

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:48fe371b-5b0c-8ec4-b627-ce0918f17425
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96B6:2FF5E0:B52221:F8E72D:6AFB5342
html-safe-nonceb97afa752e767fdb45efd8b0d74cf05472410691e6517febbd53c30f622af380
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkI2OjJGRjVFMDpCNTIyMjE6RjhFNzJEOjZBRkI1MzQyIiwidmlzaXRvcl9pZCI6Ijc1MjE0NDkxMjI1NzAzOTIzODYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmace8f445a055183f36600c896c697cf790c713c7891fb17ff72c935c828ed16379
hovercard-subject-tagpull_request:3991978565
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5420/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #5404 (already merged) — applying an explicit /cleanup + /simplify final gate on that diff surfaced two small, real, low-risk quality issues that this PR fixes: apps/sim/app/a...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5420/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5420%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5420%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5420/files
Reloadhttps://github.com/simstudioai/sim/pull/5420/files
Reloadhttps://github.com/simstudioai/sim/pull/5420/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
cleanup-5404-followuphttps://github.com/simstudioai/sim/tree/cleanup-5404-followup
Conversation 5 https://github.com/simstudioai/sim/pull/5420
Commits 1 https://github.com/simstudioai/sim/pull/5420/commits
Checks 17 https://github.com/simstudioai/sim/pull/5420/checks
Files changed https://github.com/simstudioai/sim/pull/5420/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5420/files
refactor(uploads): hoist execution permission check, dedupe permission-gate tests https://github.com/simstudioai/sim/pull/5420/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5420/files
8c61bfa refactor(uploads): hoist execution permission check out of upload loo… waleedlatif1 Jul 4, 2026 https://github.com/simstudioai/sim/pull/5420/commits/8c61bfa99935a35c0e810dbc077e705d9e2fe873
Clear filters https://github.com/simstudioai/sim/pull/5420/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5420/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5420/files
route.test.ts https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
route.ts https://github.com/simstudioai/sim/pull/5420/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
apps/sim/app/api/files/upload/route.test.tshttps://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
View file https://github.com/simstudioai/sim/blob/8c61bfa99935a35c0e810dbc077e705d9e2fe873/apps/sim/app/api/files/upload/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5420/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
apps/sim/app/api/files/upload/route.tshttps://github.com/simstudioai/sim/pull/5420/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
View file https://github.com/simstudioai/sim/blob/8c61bfa99935a35c0e810dbc077e705d9e2fe873/apps/sim/app/api/files/upload/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5420/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5420/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
https://github.com/simstudioai/sim/pull/5420/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
https://github.com/simstudioai/sim/pull/5420/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
Please reload this pagehttps://github.com/simstudioai/sim/pull/5420/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.