René's URL Explorer Experiment


Title: fix(mcp): make SSRF-guarded fetch structurally mandatory in OAuth auth() calls by waleedlatif1 · Pull Request #5419 · simstudioai/sim · GitHub

Open Graph Title: fix(mcp): make SSRF-guarded fetch structurally mandatory in OAuth auth() calls by waleedlatif1 · Pull Request #5419 · simstudioai/sim

X Title: fix(mcp): make SSRF-guarded fetch structurally mandatory in OAuth auth() calls by waleedlatif1 · Pull Request #5419 · simstudioai/sim

Description: Summary Follow-up to #5399, from a post-merge /cleanup + /simplify audit of that fix. #5399 fixed the callback route forgetting to pass fetchFn: createSsrfGuardedMcpFetch() into the MCP SDK's auth(), but every call site of auth() (start and callback routes) still imports the raw SDK function and has to remember to thread the guard through by hand — the exact same class of omission remains possible at any future call site. Adds mcpAuthGuarded() in apps/sim/lib/mcp/oauth/auth.ts: a thin wrapper around the SDK's auth() that always defaults fetchFn to the SSRF-guarded fetch (still overridable, e.g. in tests). Both routes now import mcpAuthGuarded from @/lib/mcp/oauth instead of auth as mcpAuth from the SDK directly, so the guard can no longer be omitted by forgetting a per-call-site argument. apps/sim/lib/mcp/oauth/revoke.ts and probe.ts are untouched — they call different SDK functions (discoverOAuthServerInfo) that already thread fetchFn through consistently and are out of scope for this wrapper. Test plan New unit test apps/sim/lib/mcp/oauth/auth.test.ts covers the wrapper's default fetchFn and override behavior Updated start/route.test.ts and callback/route.test.ts to assert the routes call mcpAuthGuarded (mocked via the shared @/lib/mcp/oauth barrel mock) instead of mocking the raw SDK auth() + pinned-fetch per test file Added mcpAuthGuarded mock function to the shared mcpOauthMock in packages/testing bunx vitest run apps/sim/app/api/mcp/oauth apps/sim/lib/mcp/oauth — 6 files, 36 tests, all pass Full-repo bun run type-check (tsc --noEmit) — clean, no errors bunx biome check on all changed files — clean

Open Graph Description: Summary Follow-up to #5399, from a post-merge /cleanup + /simplify audit of that fix. #5399 fixed the callback route forgetting to pass fetchFn: createSsrfGuardedMcpFetch() into the MCP SDK's ...

X Description: Summary Follow-up to #5399, from a post-merge /cleanup + /simplify audit of that fix. #5399 fixed the callback route forgetting to pass fetchFn: createSsrfGuardedMcpFetch() into the MCP SDK&#3...

Opengraph URL: https://github.com/simstudioai/sim/pull/5419

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b7ce2658-1d21-e175-b843-f04f40998430
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAD48:6449C:DF2D76:1335CA1:6AFB5EDA
html-safe-noncee71aa4bc58c73d9467e7219c133a80f654e5ced7fda338ad4975dfd9a9dad423
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRDQ4OjY0NDlDOkRGMkQ3NjoxMzM1Q0ExOjZBRkI1RURBIiwidmlzaXRvcl9pZCI6IjE0NDcxMjE0ODMzNjc5MzE2MTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac6978c1c9c250e408c0d160ae763635670d02e02de1a802102e1ac676aecc4267
hovercard-subject-tagpull_request:3991968031
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5419/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Follow-up to #5399, from a post-merge /cleanup + /simplify audit of that fix. #5399 fixed the callback route forgetting to pass fetchFn: createSsrfGuardedMcpFetch() into the MCP SDK's ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release59ef97164c52cf59bd10558ddec9c4f482763988
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5419/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5419%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5419%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5419/files
Reloadhttps://github.com/simstudioai/sim/pull/5419/files
Reloadhttps://github.com/simstudioai/sim/pull/5419/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/mcp-oauth-guarded-fetch-wrapperhttps://github.com/simstudioai/sim/tree/fix/mcp-oauth-guarded-fetch-wrapper
Conversation 5 https://github.com/simstudioai/sim/pull/5419
Commits 1 https://github.com/simstudioai/sim/pull/5419/commits
Checks 17 https://github.com/simstudioai/sim/pull/5419/checks
Files changed https://github.com/simstudioai/sim/pull/5419/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5419/files
fix(mcp): make SSRF-guarded fetch structurally mandatory in OAuth auth() calls https://github.com/simstudioai/sim/pull/5419/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5419/files
acb2b20 fix(mcp): make SSRF-guarded fetch structurally mandatory in OAuth aut… waleedlatif1 Jul 4, 2026 https://github.com/simstudioai/sim/pull/5419/commits/acb2b2074ca5453c2f7bdb56f574a709ec1f033d
Clear filters https://github.com/simstudioai/sim/pull/5419/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5419/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5419/files
route.test.ts https://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
route.ts https://github.com/simstudioai/sim/pull/5419/files#diff-fddc94965e6ed092dfac21e607fbef44888d286f2a177502cf531e9ca01bd1ce
route.test.ts https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
route.ts https://github.com/simstudioai/sim/pull/5419/files#diff-c39ea44b90f19a68eac78450a1dcd4c067a80c8639393cc2cb66f7566da41ba0
auth.test.ts https://github.com/simstudioai/sim/pull/5419/files#diff-77fa20f0a4e38a112e0caa9d65f6a557dd99ea1db5746b0071052cbdc2d88a7c
auth.ts https://github.com/simstudioai/sim/pull/5419/files#diff-14b21260362345c1622f6aa186e754511bc6b612b2f0d1b8873dda19747caddd
index.ts https://github.com/simstudioai/sim/pull/5419/files#diff-d2e4d903f1b93d0a715f00394271e6846b0262a7d0a3d305093d7646489b6c63
mcp-oauth.mock.ts https://github.com/simstudioai/sim/pull/5419/files#diff-71d4bbe5ae52b255722c49f2cc9ea5cc424016abbfc78e8395daca0ddafc5612
apps/sim/app/api/mcp/oauth/callback/route.test.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/app/api/mcp/oauth/callback/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
https://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
https://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
https://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
https://github.com/simstudioai/sim/pull/5419/files#diff-14986fb8f95dce9ca6cffd0e956ad3470520489d021931a937e1162e93610b1c
apps/sim/app/api/mcp/oauth/callback/route.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-fddc94965e6ed092dfac21e607fbef44888d286f2a177502cf531e9ca01bd1ce
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/app/api/mcp/oauth/callback/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5419/files#diff-fddc94965e6ed092dfac21e607fbef44888d286f2a177502cf531e9ca01bd1ce
https://github.com/simstudioai/sim/pull/5419/files#diff-fddc94965e6ed092dfac21e607fbef44888d286f2a177502cf531e9ca01bd1ce
https://github.com/simstudioai/sim/pull/5419/files#diff-fddc94965e6ed092dfac21e607fbef44888d286f2a177502cf531e9ca01bd1ce
https://github.com/simstudioai/sim/pull/5419/files#diff-fddc94965e6ed092dfac21e607fbef44888d286f2a177502cf531e9ca01bd1ce
apps/sim/app/api/mcp/oauth/start/route.test.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/app/api/mcp/oauth/start/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
https://github.com/simstudioai/sim/pull/5419/files#diff-463b39d876cd41f35548f691cfc783b9d86c5d9e558957d295ce0570f52c4cf5
apps/sim/app/api/mcp/oauth/start/route.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-c39ea44b90f19a68eac78450a1dcd4c067a80c8639393cc2cb66f7566da41ba0
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/app/api/mcp/oauth/start/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5419/files#diff-c39ea44b90f19a68eac78450a1dcd4c067a80c8639393cc2cb66f7566da41ba0
https://github.com/simstudioai/sim/pull/5419/files#diff-c39ea44b90f19a68eac78450a1dcd4c067a80c8639393cc2cb66f7566da41ba0
https://github.com/simstudioai/sim/pull/5419/files#diff-c39ea44b90f19a68eac78450a1dcd4c067a80c8639393cc2cb66f7566da41ba0
https://github.com/simstudioai/sim/pull/5419/files#diff-c39ea44b90f19a68eac78450a1dcd4c067a80c8639393cc2cb66f7566da41ba0
apps/sim/lib/mcp/oauth/auth.test.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-77fa20f0a4e38a112e0caa9d65f6a557dd99ea1db5746b0071052cbdc2d88a7c
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/lib/mcp/oauth/auth.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
apps/sim/lib/mcp/oauth/auth.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-14b21260362345c1622f6aa186e754511bc6b612b2f0d1b8873dda19747caddd
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/lib/mcp/oauth/auth.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
apps/sim/lib/mcp/oauth/index.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-d2e4d903f1b93d0a715f00394271e6846b0262a7d0a3d305093d7646489b6c63
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/apps/sim/lib/mcp/oauth/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5419/files#diff-d2e4d903f1b93d0a715f00394271e6846b0262a7d0a3d305093d7646489b6c63
packages/testing/src/mocks/mcp-oauth.mock.tshttps://github.com/simstudioai/sim/pull/5419/files#diff-71d4bbe5ae52b255722c49f2cc9ea5cc424016abbfc78e8395daca0ddafc5612
View file https://github.com/simstudioai/sim/blob/acb2b2074ca5453c2f7bdb56f574a709ec1f033d/packages/testing/src/mocks/mcp-oauth.mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5419/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5419/files#diff-71d4bbe5ae52b255722c49f2cc9ea5cc424016abbfc78e8395daca0ddafc5612
https://github.com/simstudioai/sim/pull/5419/files#diff-71d4bbe5ae52b255722c49f2cc9ea5cc424016abbfc78e8395daca0ddafc5612
https://github.com/simstudioai/sim/pull/5419/files#diff-71d4bbe5ae52b255722c49f2cc9ea5cc424016abbfc78e8395daca0ddafc5612
https://github.com/simstudioai/sim/pull/5419/files#diff-71d4bbe5ae52b255722c49f2cc9ea5cc424016abbfc78e8395daca0ddafc5612
Please reload this pagehttps://github.com/simstudioai/sim/pull/5419/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.