Title: fix(mothership): block subflow re-parenting in embedded workflow view by TheodoreSpeaks · Pull Request #5418 · simstudioai/sim · GitHub
Open Graph Title: fix(mothership): block subflow re-parenting in embedded workflow view by TheodoreSpeaks · Pull Request #5418 · simstudioai/sim
X Title: fix(mothership): block subflow re-parenting in embedded workflow view by TheodoreSpeaks · Pull Request #5418 · simstudioai/sim
Description: Summary In the mship chat panel's embedded workflow view, dragging a block over a loop/parallel highlighted it and dropped the block INTO the subflow as a persistent collaborative op — with no way to undo it from the panel. Dragging itself is fine; the insertion is the bug. Fix: in embedded mode, onNodeDrag skips container-intersection detection entirely, so a drag over a subflow never highlights it and never arms potentialParentId. Both drag-stop paths already bail when potentialParentId equals the drag-start parent, so block positions still move normally but a block can never be inserted into (or pulled out of) a subflow from the embedded view. Standalone editor untouched (the skip is embedded-only). Type of Change Bug fix Testing Tested manually in the embedded panel with a loop workflow: dragging a block still works, dragging it directly onto the loop shows no drop-target highlight, and after dropping on the loop the block's parentId is unchanged (verified via API). Standalone editor drag/reparent behavior unchanged. bun run lint, bun run check:api-validation:strict pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary In the mship chat panel's embedded workflow view, dragging a block over a loop/parallel highlighted it and dropped the block INTO the subflow as a persistent collaborative op — with no...
X Description: Summary In the mship chat panel's embedded workflow view, dragging a block over a loop/parallel highlighted it and dropped the block INTO the subflow as a persistent collaborative op — wit...
Opengraph URL: https://github.com/simstudioai/sim/pull/5418
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:62b056d8-380b-25ca-b624-7c2b7edc2bf9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CD78:3491F9:EDE0F3:1463C68:6AFB5EAA |
| html-safe-nonce | 6affd24831ce643625ce6ecd57668f15a9204e99072343dd6cadf43bce3e6085 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDc4OjM0OTFGOTpFREUwRjM6MTQ2M0M2ODo2QUZCNUVBQSIsInZpc2l0b3JfaWQiOiI1NTQ4NzI0OTE1MDAwNzk0Nzk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 31e55425ac7caada254900810d634721f08641d01f6fa19892393d5d45b978aa |
| hovercard-subject-tag | pull_request:3991772483 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5418/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary In the mship chat panel's embedded workflow view, dragging a block over a loop/parallel highlighted it and dropped the block INTO the subflow as a persistent collaborative op — with no... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | ea33d13c96d0ff66bd8fa906b193d2213536b78cb06b0c50a4632c58b1418f94 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 59ef97164c52cf59bd10558ddec9c4f482763988 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width