René's URL Explorer Experiment


Title: fix(files): require workspace write permission for execution-context uploads by waleedlatif1 · Pull Request #5402 · simstudioai/sim · GitHub

Open Graph Title: fix(files): require workspace write permission for execution-context uploads by waleedlatif1 · Pull Request #5402 · simstudioai/sim

X Title: fix(files): require workspace write permission for execution-context uploads by waleedlatif1 · Pull Request #5402 · simstudioai/sim

Description: Summary The execution-context branch of /api/files/upload only checked for a valid session — unlike the sibling knowledge-base/workspace/workspace-logos branches in the same file, and unlike the equivalent execution branch in /api/files/presigned, it never verified the caller has write/admin access to the target workspace Added the same getUserEntityPermissions write/admin gate already used by every other branch in this route workspaceId is now required for execution uploads instead of silently defaulting to an empty string when omitted Type of Change Bug fix Testing Added test coverage: caller without write/admin access is rejected (403) before upload proceeds, caller with write access succeeds, caller with admin access succeeds, request missing workspaceId is rejected (400) instead of defaulting bun run check:api-validation passes Full route test file passes (18/18) Typecheck and biome clean on touched files Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary The execution-context branch of /api/files/upload only checked for a valid session — unlike the sibling knowledge-base/workspace/workspace-logos branches in the same file, and unlike the e...

X Description: Summary The execution-context branch of /api/files/upload only checked for a valid session — unlike the sibling knowledge-base/workspace/workspace-logos branches in the same file, and unlike the e...

Opengraph URL: https://github.com/simstudioai/sim/pull/5402

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:2b97efe6-8296-0fa4-9654-f57e8d9a1598
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA630:32D628:B114FF:F2A845:6AFB5276
html-safe-noncebfd1a86e5c4e7290f6e0f6c3ecec3f384a80be105f4c3a4387abb7309a14fb5b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjMwOjMyRDYyODpCMTE0RkY6RjJBODQ1OjZBRkI1Mjc2IiwidmlzaXRvcl9pZCI6IjM5ODI5NjYyNzkxMTQ1NDM3MzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd683c24040ba0c36bc7be390400f1db9decbf52eb420b06a5e7a4f54af1d7784
hovercard-subject-tagpull_request:3988757131
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5402/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary The execution-context branch of /api/files/upload only checked for a valid session — unlike the sibling knowledge-base/workspace/workspace-logos branches in the same file, and unlike the e...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5402/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5402%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5402%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5402/files
Reloadhttps://github.com/simstudioai/sim/pull/5402/files
Reloadhttps://github.com/simstudioai/sim/pull/5402/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/execution-upload-workspace-permissionhttps://github.com/simstudioai/sim/tree/fix/execution-upload-workspace-permission
Conversation 4 https://github.com/simstudioai/sim/pull/5402
Commits 1 https://github.com/simstudioai/sim/pull/5402/commits
Checks 17 https://github.com/simstudioai/sim/pull/5402/checks
Files changed https://github.com/simstudioai/sim/pull/5402/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5402/files
fix(files): require workspace write permission for execution-context uploads https://github.com/simstudioai/sim/pull/5402/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5402/files
bc4d2d1 fix(files): require workspace write permission for execution-context … waleedlatif1 Jul 3, 2026 https://github.com/simstudioai/sim/pull/5402/commits/bc4d2d123cccfa839ecfc8c00ee2654e26a1e3e6
Clear filters https://github.com/simstudioai/sim/pull/5402/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5402/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5402/files
route.test.ts https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
route.ts https://github.com/simstudioai/sim/pull/5402/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
apps/sim/app/api/files/upload/route.test.tshttps://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
View file https://github.com/simstudioai/sim/blob/bc4d2d123cccfa839ecfc8c00ee2654e26a1e3e6/apps/sim/app/api/files/upload/route.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5402/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
https://github.com/simstudioai/sim/pull/5402/files#diff-06d9cc518713cb1b4e4d1b0e6c1a8fed2f1c8e05d91ca372b4913e2d14ada1bf
apps/sim/app/api/files/upload/route.tshttps://github.com/simstudioai/sim/pull/5402/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
View file https://github.com/simstudioai/sim/blob/bc4d2d123cccfa839ecfc8c00ee2654e26a1e3e6/apps/sim/app/api/files/upload/route.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5402/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5402/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
https://github.com/simstudioai/sim/pull/5402/files#diff-ce9d09ae154528087734e3e471bff2f2e1615d7924140fb91813b745e68e5f2c
Please reload this pagehttps://github.com/simstudioai/sim/pull/5402/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.