Title: fix(chat): fail-safe to noindex if the deployment lookup errors by waleedlatif1 · Pull Request #5396 · simstudioai/sim · GitHub
Open Graph Title: fix(chat): fail-safe to noindex if the deployment lookup errors by waleedlatif1 · Pull Request #5396 · simstudioai/sim
X Title: fix(chat): fail-safe to noindex if the deployment lookup errors by waleedlatif1 · Pull Request #5396 · simstudioai/sim
Description: Summary Cursor Bugbot flagged on #5388 (already merged): the chat page's generateMetadata DB lookup had no error handling, unlike the identical query in api/chat/[identifier]/route.ts which already wraps it in try/catch Verified this is real: there's no error.tsx under app/(interfaces)/chat/, and Next.js docs confirm generateMetadata resolves outside the rendered tree that route-segment error boundaries wrap — only the root global-error.tsx would catch a throw here, meaning a DB hiccup during this lookup would crash the whole page to a generic error page instead of degrading like the old static-metadata version did Fix: catch the error, log it, default isIndexable = false. This is also just the correct default independent of the bug — if we can't confirm a deployment is safely public, noindex is the right call, not a 500 Type of Change Bug fix Testing Tested manually — live dev server, confirmed the success path (noindex, nofollow for a nonexistent identifier) is unchanged. Typecheck and Biome lint pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Cursor Bugbot flagged on #5388 (already merged): the chat page's generateMetadata DB lookup had no error handling, unlike the identical query in api/chat/[identifier]/route.ts which al...
X Description: Summary Cursor Bugbot flagged on #5388 (already merged): the chat page's generateMetadata DB lookup had no error handling, unlike the identical query in api/chat/[identifier]/route.ts whic...
Opengraph URL: https://github.com/simstudioai/sim/pull/5396
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2275e4ea-79e4-7b96-0427-e8727e6b3717 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D26C:3491F9:8F63AE:C57D51:6AFB4926 |
| html-safe-nonce | 44386ce26efcf9ca501d04a2716f68c62693c52ef63bf32a37b498e1d7043c42 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMjZDOjM0OTFGOTo4RjYzQUU6QzU3RDUxOjZBRkI0OTI2IiwidmlzaXRvcl9pZCI6IjYzMzU0MjcyODQyNjU4MTQzMTAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 034bf603c75b5a21c6bcb9892f2868a159fb18cd85a90341be3fb6adb51c7aab |
| hovercard-subject-tag | pull_request:3988454070 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5396/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Cursor Bugbot flagged on #5388 (already merged): the chat page's generateMetadata DB lookup had no error handling, unlike the identical query in api/chat/[identifier]/route.ts which al... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | acf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 26504db649b58525278f77a52b80ba5f10d5f4de |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width