| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:e71a4255-b6d9-3954-5984-4d4ee194e4d9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8C2:3C556:B27527:F580A8:6AFB5243 |
| html-safe-nonce | 3a9b83a56d61c99f959f3fdcd1b796c217e66e41392cfcd39a102b39bed6d86c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOEMyOjNDNTU2OkIyNzUyNzpGNTgwQTg6NkFGQjUyNDMiLCJ2aXNpdG9yX2lkIjoiMTQzMzU4OTMyNTYxMzQ1Mzg5MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 49d38f885865b6ec53097d4c627a1cd5b89f89ba1088ca796568f01857811f44 |
| hovercard-subject-tag | pull_request:3974971541 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5349/files |
| twitter:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/19564703?s=400&v=4 |
| og:image:alt | Summary
Follow-up to #5347. Standardize both KB modals on a single error-surfacing mechanism: toast.
Create modal: validation errors already toast via onInvalid; removed the inline description/reg... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/simstudioai/sim/pull/5349/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5349%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5349%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim |
| Reload | https://github.com/simstudioai/sim/pull/5349/files |
| Reload | https://github.com/simstudioai/sim/pull/5349/files |
| Reload | https://github.com/simstudioai/sim/pull/5349/files |
| simstudioai | https://github.com/simstudioai |
| sim | https://github.com/simstudioai/sim |
| Code | https://github.com/simstudioai/sim |
| Issues129 (129) | https://github.com/simstudioai/sim/issues |
| Pull requests197 (197) | https://github.com/simstudioai/sim/pulls |
| Actions | https://github.com/simstudioai/sim/actions |
| Projects | https://github.com/simstudioai/sim/projects |
| Security and quality | https://github.com/simstudioai/sim/security |
| Insights | https://github.com/simstudioai/sim/pulse |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose |
| TheodoreSpeaks | https://github.com/TheodoreSpeaks |
| staging | https://github.com/simstudioai/sim/tree/staging |
| kb-modal-toast-errors | https://github.com/simstudioai/sim/tree/kb-modal-toast-errors |
|
Conversation
8
| https://github.com/simstudioai/sim/pull/5349 |
|
Commits
3
| https://github.com/simstudioai/sim/pull/5349/commits |
|
Checks
16
| https://github.com/simstudioai/sim/pull/5349/checks |
|
Files changed
| https://github.com/simstudioai/sim/pull/5349/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/5349/files |
|
improvement(knowledge): make KB modals toast-only for errors
| https://github.com/simstudioai/sim/pull/5349/files#top |
|
Show all changes
3 commits
| https://github.com/simstudioai/sim/pull/5349/files |
|
f530893
improvement(knowledge): make KB modals toast-only for errors
TheodoreSpeaks Jul 2, 2026
| https://github.com/simstudioai/sim/pull/5349/commits/f530893f2f435fd8fee0687852b4d9c44afa7593 |
|
815278f
improvement(knowledge): drop field highlighting for uniform toast-onl…
TheodoreSpeaks Jul 2, 2026
| https://github.com/simstudioai/sim/pull/5349/commits/815278f82f388fa4a5615631ff8888e6518d1509 |
|
5fe6348
improvement(knowledge): inline field validation, toast for server errors
TheodoreSpeaks Jul 3, 2026
| https://github.com/simstudioai/sim/pull/5349/commits/5fe6348d1330da9577e71a85104a91bee1fffecc |
|
Clear filters
| https://github.com/simstudioai/sim/pull/5349/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/5349/files |
| Please reload this page | https://github.com/simstudioai/sim/pull/5349/files |
|
create-base-modal.tsx
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
edit-knowledge-base-modal.tsx
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
knowledge.ts
| https://github.com/simstudioai/sim/pull/5349/files#diff-3567d290a76f48b2b0e1e0e1dc1f71033418f444dc6d1256a280c8e635036211 |
| .../app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsx | https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
View file
| https://github.com/simstudioai/sim/blob/5fe6348d1330da9577e71a85104a91bee1fffecc/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/components/create-base-modal/create-base-modal.tsx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/simstudioai/sim/pull/5349/{{ revealButtonHref }} |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246 |
| ...workspaceId]/knowledge/components/edit-knowledge-base-modal/edit-knowledge-base-modal.tsx | https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
View file
| https://github.com/simstudioai/sim/blob/5fe6348d1330da9577e71a85104a91bee1fffecc/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/components/edit-knowledge-base-modal/edit-knowledge-base-modal.tsx |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/simstudioai/sim/pull/5349/{{ revealButtonHref }} |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5349/files |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156 |
| apps/sim/hooks/queries/kb/knowledge.ts | https://github.com/simstudioai/sim/pull/5349/files#diff-3567d290a76f48b2b0e1e0e1dc1f71033418f444dc6d1256a280c8e635036211 |
|
View file
| https://github.com/simstudioai/sim/blob/5fe6348d1330da9577e71a85104a91bee1fffecc/apps/sim/hooks/queries/kb/knowledge.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/simstudioai/sim/pull/5349/{{ revealButtonHref }} |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-3567d290a76f48b2b0e1e0e1dc1f71033418f444dc6d1256a280c8e635036211 |
|
| https://github.com/simstudioai/sim/pull/5349/files#diff-3567d290a76f48b2b0e1e0e1dc1f71033418f444dc6d1256a280c8e635036211 |
| Please reload this page | https://github.com/simstudioai/sim/pull/5349/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |