René's URL Explorer Experiment


Title: fix(knowledge): surface KB description validation errors and raise limit to 10k by TheodoreSpeaks · Pull Request #5347 · simstudioai/sim · GitHub

Open Graph Title: fix(knowledge): surface KB description validation errors and raise limit to 10k by TheodoreSpeaks · Pull Request #5347 · simstudioai/sim

X Title: fix(knowledge): surface KB description validation errors and raise limit to 10k by TheodoreSpeaks · Pull Request #5347 · simstudioai/sim

Description: Summary Raise the knowledge base description limit to 10,000 chars via a shared KNOWLEDGE_BASE_DESCRIPTION_MAX_LENGTH constant, enforced consistently across the create/edit UI, the internal API contract, and the v1 API contract (previously 500 / 1000 / uncapped) Close the internal POST/PUT /api/knowledge gap that had no server-side description cap at all Fix the create-base modal silently blocking submit on validation errors (red field, no message) — now toasts the first error and shows the description error inline Edit modal now toasts on validation failure instead of returning silently Type of Change Bug fix Testing Tested manually. bun run lint, bun run check:api-validation:strict, and tsc --noEmit all pass. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA) 🤖 Generated with Claude Code

Open Graph Description: Summary Raise the knowledge base description limit to 10,000 chars via a shared KNOWLEDGE_BASE_DESCRIPTION_MAX_LENGTH constant, enforced consistently across the create/edit UI, the internal API co...

X Description: Summary Raise the knowledge base description limit to 10,000 chars via a shared KNOWLEDGE_BASE_DESCRIPTION_MAX_LENGTH constant, enforced consistently across the create/edit UI, the internal API co...

Opengraph URL: https://github.com/simstudioai/sim/pull/5347

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9b43a3e5-1975-5dc2-6fc5-506f652dfe17
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id950A:22FE8E:6D7944:9B9734:6AFB465F
html-safe-nonceac0ee097e89729d546494856ded581c86de335161ca064c9f38007d90ef75f7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NTBBOjIyRkU4RTo2RDc5NDQ6OUI5NzM0OjZBRkI0NjVGIiwidmlzaXRvcl9pZCI6IjMwODAzMjYwMTM2MzI4NTc2OTUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf9d31eda579c37189c3ab47bfd9676455fbc32438b2b07acf79cf25ef4742893
hovercard-subject-tagpull_request:3974879785
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5347/files
twitter:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19564703?s=400&v=4
og:image:altSummary Raise the knowledge base description limit to 10,000 chars via a shared KNOWLEDGE_BASE_DESCRIPTION_MAX_LENGTH constant, enforced consistently across the create/edit UI, the internal API co...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5347/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5347%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5347%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5347/files
Reloadhttps://github.com/simstudioai/sim/pull/5347/files
Reloadhttps://github.com/simstudioai/sim/pull/5347/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
debug-kb--descriptionhttps://github.com/simstudioai/sim/tree/debug-kb--description
Conversation 3 https://github.com/simstudioai/sim/pull/5347
Commits 1 https://github.com/simstudioai/sim/pull/5347/commits
Checks 16 https://github.com/simstudioai/sim/pull/5347/checks
Files changed https://github.com/simstudioai/sim/pull/5347/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5347/files
fix(knowledge): surface KB description validation errors and raise limit to 10k https://github.com/simstudioai/sim/pull/5347/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5347/files
50b1295 fix(knowledge): surface KB description validation errors and raise li… TheodoreSpeaks Jul 2, 2026 https://github.com/simstudioai/sim/pull/5347/commits/50b1295601ca59d650d7ae1f4c8c28ed270b06d9
Clear filters https://github.com/simstudioai/sim/pull/5347/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5347/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5347/files
create-base-modal.tsx https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
edit-knowledge-base-modal.tsx https://github.com/simstudioai/sim/pull/5347/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156
base.ts https://github.com/simstudioai/sim/pull/5347/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
index.ts https://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
constants.ts https://github.com/simstudioai/sim/pull/5347/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
.../app/workspace/[workspaceId]/knowledge/components/create-base-modal/create-base-modal.tsxhttps://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
View file https://github.com/simstudioai/sim/blob/50b1295601ca59d650d7ae1f4c8c28ed270b06d9/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/components/create-base-modal/create-base-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5347/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
https://github.com/simstudioai/sim/pull/5347/files#diff-6dc51f5a2de9f62757e4653bfaa1e26b6b869862d3085e2630c4ef7353c50246
...workspaceId]/knowledge/components/edit-knowledge-base-modal/edit-knowledge-base-modal.tsxhttps://github.com/simstudioai/sim/pull/5347/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156
View file https://github.com/simstudioai/sim/blob/50b1295601ca59d650d7ae1f4c8c28ed270b06d9/apps/sim/app/workspace/%5BworkspaceId%5D/knowledge/components/edit-knowledge-base-modal/edit-knowledge-base-modal.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5347/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5347/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156
https://github.com/simstudioai/sim/pull/5347/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156
https://github.com/simstudioai/sim/pull/5347/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156
https://github.com/simstudioai/sim/pull/5347/files#diff-6b174ff44206833636b8f9225946b96c63b72d481db531e98bf701b490436156
apps/sim/lib/api/contracts/knowledge/base.tshttps://github.com/simstudioai/sim/pull/5347/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
View file https://github.com/simstudioai/sim/blob/50b1295601ca59d650d7ae1f4c8c28ed270b06d9/apps/sim/lib/api/contracts/knowledge/base.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5347/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5347/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
https://github.com/simstudioai/sim/pull/5347/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
https://github.com/simstudioai/sim/pull/5347/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
https://github.com/simstudioai/sim/pull/5347/files#diff-af4bae723c3963d83aa7976287345a51652d8e76ae08ba51f65c5bfde501c1d8
apps/sim/lib/api/contracts/v1/knowledge/index.tshttps://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
View file https://github.com/simstudioai/sim/blob/50b1295601ca59d650d7ae1f4c8c28ed270b06d9/apps/sim/lib/api/contracts/v1/knowledge/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5347/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
https://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
https://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
https://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
https://github.com/simstudioai/sim/pull/5347/files#diff-0dfaf1e3e4491c3981527dc6bc9ca6c40944fe279a86c1850e44a55bd282a8ad
apps/sim/lib/knowledge/constants.tshttps://github.com/simstudioai/sim/pull/5347/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
View file https://github.com/simstudioai/sim/blob/50b1295601ca59d650d7ae1f4c8c28ed270b06d9/apps/sim/lib/knowledge/constants.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5347/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5347/files#diff-d0f66ec31a3b2ab7b1a24fb76cf2b0865b07be5abb97836403a2aab47784024a
Please reload this pagehttps://github.com/simstudioai/sim/pull/5347/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.