René's URL Explorer Experiment


Title: improvement(files): react-doctor performance pass on the files module by waleedlatif1 · Pull Request #5330 · simstudioai/sim · GitHub

Open Graph Title: improvement(files): react-doctor performance pass on the files module by waleedlatif1 · Pull Request #5330 · simstudioai/sim

X Title: improvement(files): react-doctor performance pass on the files module by waleedlatif1 · Pull Request #5330 · simstudioai/sim

Description: Summary Ran npx react-doctor on the files module and applied the safe, behavior-preserving performance wins Owner resolution in the file list was O(rows × members) — every row and every sort comparison did a linear members.find(...). Now builds a membersById map once and does O(1) lookups; ownerCell accepts either the array or a precomputed Map (backward compatible, no change for tables/knowledge callers) Replaced two redundant [...arr].sort() copies with non-mutating arr.toSorted() (apps/sim is on the ES2023 lib) Merged the selectedFileIds/selectedFolderIds memos into a single-pass partition instead of parsing every selected row id twice Documented the react-doctor best-practice patterns + known false-positive judgments in .claude/rules/sim-components.md so future agent passes apply them Type of Change Performance improvement Testing tsc clean (0 errors), Biome clean, bun run lint green Four independent audit passes confirmed identical observable behavior and zero regressions (owner column, sort order, filter labels, selection counts). Duplicate-userId edge is impossible given the permissions uniqueness constraint react-doctor Performance findings 25 → 19, total 122 → 116 Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Ran npx react-doctor on the files module and applied the safe, behavior-preserving performance wins Owner resolution in the file list was O(rows × members) — every row and every sort compa...

X Description: Summary Ran npx react-doctor on the files module and applied the safe, behavior-preserving performance wins Owner resolution in the file list was O(rows × members) — every row and every sort compa...

Opengraph URL: https://github.com/simstudioai/sim/pull/5330

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:95b56148-2c07-4c73-a05d-c349cd3a2d47
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEA8E:FB9FD:7AC67A:A9CEBA:6AFB4674
html-safe-nonce280c01a304d20166e636dd4874ef3c44a27d1c23fb3fd07da5a353345edee11e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQThFOkZCOUZEOjdBQzY3QTpBOUNFQkE6NkFGQjQ2NzQiLCJ2aXNpdG9yX2lkIjoiNzUzOTUxMjkwODkwODgwNzc5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0301ce218101a5245d5139fb406e8b123d39b8ec5560dfff6d94e33c58273083
hovercard-subject-tagpull_request:3973406259
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5330/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Ran npx react-doctor on the files module and applied the safe, behavior-preserving performance wins Owner resolution in the file list was O(rows × members) — every row and every sort compa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5330/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5330%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5330%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5330/files
Reloadhttps://github.com/simstudioai/sim/pull/5330/files
Reloadhttps://github.com/simstudioai/sim/pull/5330/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-files-react-doctorhttps://github.com/simstudioai/sim/tree/worktree-files-react-doctor
Conversation 7 https://github.com/simstudioai/sim/pull/5330
Commits 2 https://github.com/simstudioai/sim/pull/5330/commits
Checks 16 https://github.com/simstudioai/sim/pull/5330/checks
Files changed https://github.com/simstudioai/sim/pull/5330/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5330/files
improvement(files): react-doctor performance pass on the files module https://github.com/simstudioai/sim/pull/5330/files#top
Show all changes 2 commits https://github.com/simstudioai/sim/pull/5330/files
2bf35a9 improvement(files): react-doctor performance pass on the files module waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5330/commits/2bf35a991413e07e93b7b96ab927b86868c3bc3a
3c0b175 fix(files): use spread-sort not toSorted in client (Safari<16/iOS15 c… waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5330/commits/3c0b175067afb5fee302a3983472c66da0604ce9
Clear filters https://github.com/simstudioai/sim/pull/5330/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5330/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5330/files
sim-components.md https://github.com/simstudioai/sim/pull/5330/files#diff-ed2c66ecd6d03a35a37280c0c2a189db922fc83216e7911bace7bbd20d343128
owner-cell.tsx https://github.com/simstudioai/sim/pull/5330/files#diff-86dce588920fe4eefa7213ac0431f09f903172253697762a11dc682c22d16784
files.tsx https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
.claude/rules/sim-components.mdhttps://github.com/simstudioai/sim/pull/5330/files#diff-ed2c66ecd6d03a35a37280c0c2a189db922fc83216e7911bace7bbd20d343128
View file https://github.com/simstudioai/sim/blob/3c0b175067afb5fee302a3983472c66da0604ce9/.claude/rules/sim-components.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5330/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5330/files#diff-ed2c66ecd6d03a35a37280c0c2a189db922fc83216e7911bace7bbd20d343128
.../sim/app/workspace/[workspaceId]/components/resource/components/owner-cell/owner-cell.tsxhttps://github.com/simstudioai/sim/pull/5330/files#diff-86dce588920fe4eefa7213ac0431f09f903172253697762a11dc682c22d16784
View file https://github.com/simstudioai/sim/blob/3c0b175067afb5fee302a3983472c66da0604ce9/apps/sim/app/workspace/%5BworkspaceId%5D/components/resource/components/owner-cell/owner-cell.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5330/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5330/files#diff-86dce588920fe4eefa7213ac0431f09f903172253697762a11dc682c22d16784
https://github.com/simstudioai/sim/pull/5330/files#diff-86dce588920fe4eefa7213ac0431f09f903172253697762a11dc682c22d16784
apps/sim/app/workspace/[workspaceId]/files/files.tsxhttps://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
View file https://github.com/simstudioai/sim/blob/3c0b175067afb5fee302a3983472c66da0604ce9/apps/sim/app/workspace/%5BworkspaceId%5D/files/files.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5330/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
https://github.com/simstudioai/sim/pull/5330/files#diff-0284e2e46ba0636bd37fb01a0bee2a53844af9bbaf0a5879e3b182c0f34e67a9
Please reload this pagehttps://github.com/simstudioai/sim/pull/5330/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.