René's URL Explorer Experiment


Title: improvement(tables): react-doctor safe performance pass by waleedlatif1 · Pull Request #5329 · simstudioai/sim · GitHub

Open Graph Title: improvement(tables): react-doctor safe performance pass by waleedlatif1 · Pull Request #5329 · simstudioai/sim

X Title: improvement(tables): react-doctor safe performance pass by waleedlatif1 · Pull Request #5329 · simstudioai/sim

Description: What Installed and ran react-doctor@0.5.8 on the tables module (apps/sim/app/workspace/[workspaceId]/tables) and applied the high-confidence, behavior-preserving performance fixes it surfaced. This is a deliberately conservative pass — no core grid selection/effect logic was refactored. Changes Lazy ref init (use-workspace-imports.ts) — the import-status useRef(new Map()) allocated and threw away a fresh Map on every render; now lazily initialized once. Map lookup in render path (table-grid/utils.ts) — expandToDisplayColumns called group.outputs.find(...) once per column; now builds an outputs-by-column-name Map once per workflow group. toSorted() (tables.tsx) — replaced [...list].sort() with list.toSorted() (no throwaway copy; ES2023 lib is enabled for apps/sim). Module-scope hoisting — moved the static TITLE_BY_MODE map (workflow-sidebar.tsx) and the pure wheel handler (inline-editors.tsx) out of their components so they aren't rebuilt each render. Result: react-doctor issues 142 → 137 (Performance 42 → 39, Maintainability 18 → 16). Deliberately not changed "State synced to a prop inside an effect ×9" and the effect-chain findings in table-grid.tsx — these effects react to async-loaded rows (pagination remapping selection by row id, revealing a search match once its page loads). They are not the copy-a-prop-into-state anti-pattern, and can't move into an event handler since the data arrives from a query. Refactoring them needs live grid verification; the score stays at 37 because of these mostly-false-positive errors. no-barrel-import findings — false positives against this repo's mandated barrel-import convention (sim-imports.md). The setTimeout "needs cleanup" finding — an intentional 6s auto-dismiss that must survive tables re-renders; a naive cleanup would cancel legitimate pending dismissals. Verification tsc --noEmit clean (0 errors) biome check clean

Open Graph Description: What Installed and ran react-doctor@0.5.8 on the tables module (apps/sim/app/workspace/[workspaceId]/tables) and applied the high-confidence, behavior-preserving performance fixes it surfaced. This...

X Description: What Installed and ran react-doctor@0.5.8 on the tables module (apps/sim/app/workspace/[workspaceId]/tables) and applied the high-confidence, behavior-preserving performance fixes it surfaced. This...

Opengraph URL: https://github.com/simstudioai/sim/pull/5329

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:58165cfb-18c2-b58e-8029-a7f6d5b5a76b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE09A:2D7CAE:6852CD:943395:6AFB4670
html-safe-noncedf4a51d99a43eb78e22e21d28fb81486709b2ae6c00d7ce9c39282cbaeda230e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDlBOjJEN0NBRTo2ODUyQ0Q6OTQzMzk1OjZBRkI0NjcwIiwidmlzaXRvcl9pZCI6IjkyMDQwNzM3MDE1OTA0ODMwNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacec4f466cfe3063fcaf03cc53c20f943a9a71064c7e35780a029d6a857a50b4d7
hovercard-subject-tagpull_request:3973327118
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5329/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altWhat Installed and ran react-doctor@0.5.8 on the tables module (apps/sim/app/workspace/[workspaceId]/tables) and applied the high-confidence, behavior-preserving performance fixes it surfaced. This...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noned849b928f455c800985398e7f1b659425adb312a5fa14fba5d9a14e62e9fe5dd
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasea6c2f87cbcb6414452377b4967858ed6a66f1109
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5329/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5329%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5329%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5329/files
Reloadhttps://github.com/simstudioai/sim/pull/5329/files
Reloadhttps://github.com/simstudioai/sim/pull/5329/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests199 (199)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-tables-react-doctorhttps://github.com/simstudioai/sim/tree/worktree-tables-react-doctor
Conversation 11 https://github.com/simstudioai/sim/pull/5329
Commits 4 https://github.com/simstudioai/sim/pull/5329/commits
Checks 16 https://github.com/simstudioai/sim/pull/5329/checks
Files changed https://github.com/simstudioai/sim/pull/5329/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5329/files
improvement(tables): react-doctor safe performance pass https://github.com/simstudioai/sim/pull/5329/files#top
Show all changes 4 commits https://github.com/simstudioai/sim/pull/5329/files
1da718f improvement(tables): react-doctor safe performance pass waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5329/commits/1da718f1a82492fce55f1e54ab6124afbc308c4e
cd25b34 improvement(tables): preserve find() first-match semantics + document… waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5329/commits/cd25b344a09f5ae8a38df2e8ce695027f6573775
dc4510c fix(tables): revert toSorted to spread-sort for universal browser sup… waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5329/commits/dc4510c771a73124b5fcf133bc100579e2e77bce
ba2f6f1 refactor(tables): tidy lazy ref init and align perf-rule cross-reference waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5329/commits/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32
Clear filters https://github.com/simstudioai/sim/pull/5329/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5329/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5329/files
sim-react-performance.md https://github.com/simstudioai/sim/pull/5329/files#diff-0ca5b1478a6d336528738213be46900f5ab9859bedc1ebf07dfec69974f2caba
CLAUDE.md https://github.com/simstudioai/sim/pull/5329/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
inline-editors.tsx https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
utils.ts https://github.com/simstudioai/sim/pull/5329/files#diff-2f1c4e42cbe292c4f41a2c97863217a35116e736675e2ecaa72ef1e470c0804f
workflow-sidebar.tsx https://github.com/simstudioai/sim/pull/5329/files#diff-716ab01ef41745eef2389c30adcf1bc51d1e59a8a0d8edfe293ec279801de62e
use-workspace-imports.ts https://github.com/simstudioai/sim/pull/5329/files#diff-54ae41b890501a24f95f73bc373204dbfd3956b24c0a72293a64b386768aa35b
.claude/rules/sim-react-performance.mdhttps://github.com/simstudioai/sim/pull/5329/files#diff-0ca5b1478a6d336528738213be46900f5ab9859bedc1ebf07dfec69974f2caba
View file https://github.com/simstudioai/sim/blob/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32/.claude/rules/sim-react-performance.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5329/{{ revealButtonHref }}
CLAUDE.mdhttps://github.com/simstudioai/sim/pull/5329/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
View file https://github.com/simstudioai/sim/blob/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32/CLAUDE.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5329/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5329/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
https://github.com/simstudioai/sim/pull/5329/files#diff-6ebdb617a8104a7756d0cf36578ab01103dc9f07e4dc6feb751296b9c402faf7
...p/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/inline-editors.tsxhttps://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
View file https://github.com/simstudioai/sim/blob/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/table-grid/cells/inline-editors.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5329/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
https://github.com/simstudioai/sim/pull/5329/files#diff-71977816ed06f4cfda658b1747bf82f9524669ee7e3145b5d3945f651415f440
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/utils.tshttps://github.com/simstudioai/sim/pull/5329/files#diff-2f1c4e42cbe292c4f41a2c97863217a35116e736675e2ecaa72ef1e470c0804f
View file https://github.com/simstudioai/sim/blob/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/table-grid/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5329/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5329/files#diff-2f1c4e42cbe292c4f41a2c97863217a35116e736675e2ecaa72ef1e470c0804f
https://github.com/simstudioai/sim/pull/5329/files#diff-2f1c4e42cbe292c4f41a2c97863217a35116e736675e2ecaa72ef1e470c0804f
...workspace/[workspaceId]/tables/[tableId]/components/workflow-sidebar/workflow-sidebar.tsxhttps://github.com/simstudioai/sim/pull/5329/files#diff-716ab01ef41745eef2389c30adcf1bc51d1e59a8a0d8edfe293ec279801de62e
View file https://github.com/simstudioai/sim/blob/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32/apps/sim/app/workspace/%5BworkspaceId%5D/tables/%5BtableId%5D/components/workflow-sidebar/workflow-sidebar.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5329/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5329/files#diff-716ab01ef41745eef2389c30adcf1bc51d1e59a8a0d8edfe293ec279801de62e
https://github.com/simstudioai/sim/pull/5329/files#diff-716ab01ef41745eef2389c30adcf1bc51d1e59a8a0d8edfe293ec279801de62e
https://github.com/simstudioai/sim/pull/5329/files#diff-716ab01ef41745eef2389c30adcf1bc51d1e59a8a0d8edfe293ec279801de62e
https://github.com/simstudioai/sim/pull/5329/files#diff-716ab01ef41745eef2389c30adcf1bc51d1e59a8a0d8edfe293ec279801de62e
...p/workspace/[workspaceId]/tables/components/import-progress-menu/use-workspace-imports.tshttps://github.com/simstudioai/sim/pull/5329/files#diff-54ae41b890501a24f95f73bc373204dbfd3956b24c0a72293a64b386768aa35b
View file https://github.com/simstudioai/sim/blob/ba2f6f1fa77fdc1682d949c2dc6eaae9e291cb32/apps/sim/app/workspace/%5BworkspaceId%5D/tables/components/import-progress-menu/use-workspace-imports.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5329/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5329/files#diff-54ae41b890501a24f95f73bc373204dbfd3956b24c0a72293a64b386768aa35b
https://github.com/simstudioai/sim/pull/5329/files#diff-54ae41b890501a24f95f73bc373204dbfd3956b24c0a72293a64b386768aa35b
https://github.com/simstudioai/sim/pull/5329/files#diff-54ae41b890501a24f95f73bc373204dbfd3956b24c0a72293a64b386768aa35b
Please reload this pagehttps://github.com/simstudioai/sim/pull/5329/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.