René's URL Explorer Experiment


Title: improvement(settings): react-doctor perf & correctness pass by waleedlatif1 · Pull Request #5327 · simstudioai/sim · GitHub

Open Graph Title: improvement(settings): react-doctor perf & correctness pass by waleedlatif1 · Pull Request #5327 · simstudioai/sim

X Title: improvement(settings): react-doctor perf & correctness pass by waleedlatif1 · Pull Request #5327 · simstudioai/sim

Description: Summary Ran react-doctor on the settings surface and fixed the genuine, behavior-preserving findings (score 54 → 57; errors 4 → 2; diagnostics 117 → 72). No hacky/cargo-cult changes. Perf: combined multi-pass array iterations into single passes (api-keys, credential-sets, secrets-manager, team-management); cached/hoisted Intl formatters to module scope (billing); hoisted pure functions + inline-default constants; immutable in-place sort where the array is already a fresh copy Fewer re-renders: stabilized React-Query array fallbacks (?? EMPTY) so downstream useMemos stop recomputing while loading (api-keys, byok, workflow-mcp) Correctness: create-workflow-mcp modal now resets via a render-phase prevOpen compare instead of a state-adjusting effect (removes a stale-flash); genuine exhaustive-deps fixes (v5-stable mutateAsync) Accessibility: aria-labels on real inputs, aria-hidden on autofill decoys, native