René's URL Explorer Experiment


Title: fix(media-embed): remove ReDoS-prone regexes in host-gated providers by waleedlatif1 · Pull Request #5305 · simstudioai/sim · GitHub

Open Graph Title: fix(media-embed): remove ReDoS-prone regexes in host-gated providers by waleedlatif1 · Pull Request #5305 · simstudioai/sim

X Title: fix(media-embed): remove ReDoS-prone regexes in host-gated providers by waleedlatif1 · Pull Request #5305 · simstudioai/sim

Description: Summary Fixes 3 CodeQL High js/polynomial-redos alerts on packages/utils/src/media-embed.ts (introduced by #5290, now in staging) The YouTube, Facebook, and Giphy branches used unbounded .* inside unanchored regexes. Even with the hostname gate, a crafted valid-host URL with a long path/query (e.g. https://facebook.com/ + 100k junk chars, no /videos/) triggers O(n²) backtracking — a client-side hang since getEmbedInfo runs during note rendering + editor decoration (a crafted link in shared content could freeze other users' tabs) Replaced each with bounded extraction off the parsed URL (parsed.pathname / parsed.searchParams), so there is no .* left in these branches. No change to which links match Detail YouTube: youtu.be → first path segment; watch → searchParams.get('v'); embed → anchored /^\/embed\/([^/?]+)/; result validated with /^[a-zA-Z0-9_-]{11}$/ Facebook: detect video via /\/videos\/\d+/ on the pathname (fb.watch via anchored segment) instead of facebook.com/.*/videos/ Giphy: take the trailing hyphen token of the /gifs|embed/ path segment ([^/]+ + split('-').pop()), validated [a-zA-Z0-9]+ Type of Change Bug fix (security — ReDoS) Testing media-embed.test.ts: existing cases pass; added coverage for extra YouTube query params, Facebook/fb.watch, and Giphy slug extraction (10 tests). tsc clean. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary Fixes 3 CodeQL High js/polynomial-redos alerts on packages/utils/src/media-embed.ts (introduced by #5290, now in staging) The YouTube, Facebook, and Giphy branches used unbounded .* inside...

X Description: Summary Fixes 3 CodeQL High js/polynomial-redos alerts on packages/utils/src/media-embed.ts (introduced by #5290, now in staging) The YouTube, Facebook, and Giphy branches used unbounded .* inside...

Opengraph URL: https://github.com/simstudioai/sim/pull/5305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:128c16e9-3ff6-1ab8-e280-fb46b81613d9
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id95A2:3786FF:54CFF7:79BB80:6AFB3DDF
html-safe-noncec56b2c3c3aa25d90d71fd0f2f7ff81e445ef66e193afd8ef6e95d94fd16c3505
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NUEyOjM3ODZGRjo1NENGRjc6NzlCQjgwOjZBRkIzRERGIiwidmlzaXRvcl9pZCI6IjExNzU3NjAxOTY4NjE2NDAxNTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac9461f40293f12c63d550507309916c6158e021ab566c916d377047e69c97f017
hovercard-subject-tagpull_request:3967210923
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5305/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary Fixes 3 CodeQL High js/polynomial-redos alerts on packages/utils/src/media-embed.ts (introduced by #5290, now in staging) The YouTube, Facebook, and Giphy branches used unbounded .* inside...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None2169b0dfbef67ed6b128074a5ed45bb7d5d1859783b10178b09a7765ad5f3693
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b4fc8df5ef1c6757e733a23e6b81b6725021823
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5305/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5305%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5305%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5305/files
Reloadhttps://github.com/simstudioai/sim/pull/5305/files
Reloadhttps://github.com/simstudioai/sim/pull/5305/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests200 (200)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
media-embed-redos-fixhttps://github.com/simstudioai/sim/tree/media-embed-redos-fix
Conversation 13 https://github.com/simstudioai/sim/pull/5305
Commits 3 https://github.com/simstudioai/sim/pull/5305/commits
Checks 16 https://github.com/simstudioai/sim/pull/5305/checks
Files changed https://github.com/simstudioai/sim/pull/5305/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5305/files
fix(media-embed): remove ReDoS-prone regexes in host-gated providers https://github.com/simstudioai/sim/pull/5305/files#top
Show all changes 3 commits https://github.com/simstudioai/sim/pull/5305/files
922a274 fix(media-embed): remove ReDoS-prone regexes in host-gated providers waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5305/commits/922a274f6210fe032d478520e912e39d1e96eb3f
f3e4d4b test(media-embed): lock youtu.be trailing-slash + edge parity waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5305/commits/f3e4d4b12359c63bbc641ab9b0c36b9126314311
64df33e fix(media-embed): dispatch YouTube id by path shape; drop inline comm… waleedlatif1 Jul 1, 2026 https://github.com/simstudioai/sim/pull/5305/commits/64df33e4cb88611d35342c51106a563fb1d6d239
Clear filters https://github.com/simstudioai/sim/pull/5305/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5305/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5305/files
media-embed.test.ts https://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
media-embed.ts https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
packages/utils/src/media-embed.test.tshttps://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
View file https://github.com/simstudioai/sim/blob/64df33e4cb88611d35342c51106a563fb1d6d239/packages/utils/src/media-embed.test.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5305/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
https://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
https://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
https://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
https://github.com/simstudioai/sim/pull/5305/files#diff-67061f70abc9658a8a89aac709f19e292482a792d9233fa90b17e6daf05301db
packages/utils/src/media-embed.tshttps://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
View file https://github.com/simstudioai/sim/blob/64df33e4cb88611d35342c51106a563fb1d6d239/packages/utils/src/media-embed.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5305/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
Please reload this pagehttps://github.com/simstudioai/sim/pull/5305/files
https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
https://github.com/simstudioai/sim/pull/5305/files#diff-9a376d94465258d33a21c808d9b6def606a75f3efbed1808baa51b5c0a9e23b3
Please reload this pagehttps://github.com/simstudioai/sim/pull/5305/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.