René's URL Explorer Experiment


Title: improvement(settings): persistent layout + locked-down header API by waleedlatif1 · Pull Request #5278 · simstudioai/sim · GitHub

Open Graph Title: improvement(settings): persistent layout + locked-down header API by waleedlatif1 · Pull Request #5278 · simstudioai/sim

X Title: improvement(settings): persistent layout + locked-down header API by waleedlatif1 · Pull Request #5278 · simstudioai/sim

Description: What Mirror the Resource compound component's locked invariant for settings, per Emir's review ("ideally a Next.js layout … nobody can vibe-code a padding change"). Persistent chrome via a Next.js layout. All page chrome — header bar, title/description, scroll region, centered max-w-[48rem] column, spacing — moves into settings/[section]/layout.tsx (SettingsHeaderShell). It stays mounted across section navigation, so the header/description/spacing never re-render or re-lay-out. SettingsPanel becomes a thin registrar that feeds the shell its header data through a React context slot (stable setter + signature ref → no render loop, no flash, no stale handlers). Locked-down header API. actions is now SettingsAction[] (data only: text / icon / variant / active / onSelect / disabled, rendered as Chips) — no JSX, no

, no className, so a padding change is structurally impossible. Adds a left back slot for detail sub-views and an aside escape hatch for the rare non-chip widget. SaveDiscardActions component → saveDiscardActions() helper returning the dirty-gated SettingsAction[]. Migrated every panel page + the 5 in-section detail views (access-control group-detail, data-retention PolicyDetail, mcp, credential-sets, workflow-mcp) onto the layout/back-slot — none hand-roll their own shell anymore. Emir's chip rules: sentence-case labels (Add override, Create server, …); the action gap is owned once by the shell; zero action
s. The route-based credential detail (settings/secrets/[credentialId]) keeps its own CredentialDetailLayout (it lives outside [section]). Verification tsc clean, biome clean, check:api-validation passed. Foundation built by hand; the ~15 section migrations were fanned out across parallel subagents and verified together. Docs updated (sim-settings-pages.md + add-settings-page skill).

Open Graph Description: What Mirror the Resource compound component's locked invariant for settings, per Emir's review ("ideally a Next.js layout … nobody can vibe-code a padding change"). Persistent ch...

X Description: What Mirror the Resource compound component's locked invariant for settings, per Emir's review ("ideally a Next.js layout … nobody can vibe-code a padding change")...

Opengraph URL: https://github.com/simstudioai/sim/pull/5278

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:eeff2c6f-18c8-9195-76cd-c3b9db76d0a3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC8CC:29D5DB:A323EE:DFEF77:6AFB4F3F
html-safe-nonce88558f9842faaab950e5e6f2da52a237aacf5b00344e0e6877b21840fff44542
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOENDOjI5RDVEQjpBMzIzRUU6REZFRjc3OjZBRkI0RjNGIiwidmlzaXRvcl9pZCI6IjcxOTM4Mjg5Mzk5MjIxMDAwMzIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacf7a2bc3744351bc08305b26a87acc1f5b30604778ef5fc8d6abc560d06c96500
hovercard-subject-tagpull_request:3960105815
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5278/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altWhat Mirror the Resource compound component's locked invariant for settings, per Emir's review ("ideally a Next.js layout … nobody can vibe-code a padding change"). Persistent ch...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneacf7616d06cc051644705b379878c9bb13dc5e70ecf4ffd9b34140f8ac01d7e1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release26504db649b58525278f77a52b80ba5f10d5f4de
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5278/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5278%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5278%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5278/files
Reloadhttps://github.com/simstudioai/sim/pull/5278/files
Reloadhttps://github.com/simstudioai/sim/pull/5278/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
settings-page-layouthttps://github.com/simstudioai/sim/tree/settings-page-layout
Conversation 26 https://github.com/simstudioai/sim/pull/5278
Commits 6 https://github.com/simstudioai/sim/pull/5278/commits
Checks 15 https://github.com/simstudioai/sim/pull/5278/checks
Files changed https://github.com/simstudioai/sim/pull/5278/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
improvement(settings): persistent layout + locked-down header API https://github.com/simstudioai/sim/pull/5278/files#top
Show all changes 6 commits https://github.com/simstudioai/sim/pull/5278/files
cbfa379 improvement(settings): persistent layout + locked-down header API waleedlatif1 Jun 30, 2026 https://github.com/simstudioai/sim/pull/5278/commits/cbfa3792e93381b503b34ea0a0b6a1affd30df87
a61b2ec refactor(settings): cleanup pass — deref handlers, tooltip data field… waleedlatif1 Jun 30, 2026 https://github.com/simstudioai/sim/pull/5278/commits/a61b2ec071260af819807c876893da36e6256116
6b92938 docs(settings): document SettingsAction.tooltip in the settings rule waleedlatif1 Jun 30, 2026 https://github.com/simstudioai/sim/pull/5278/commits/6b929389c657665dc910e4fcd1bb446f96c89b57
8bb7f54 fix(settings): add key to header action chip (biome useJsxKeyInIterable) waleedlatif1 Jun 30, 2026 https://github.com/simstudioai/sim/pull/5278/commits/8bb7f5483523f45dc92cf8557bfa29c8718227b1
d56c0a2 fix(settings): address review — remove aside footgun, sticky tabs, re… waleedlatif1 Jun 30, 2026 https://github.com/simstudioai/sim/pull/5278/commits/d56c0a296374c7dbbbecca54f4565d39bb328760
f174569 refactor(settings): final audit pass — parity, sentence-case, import … waleedlatif1 Jun 30, 2026 https://github.com/simstudioai/sim/pull/5278/commits/f174569d988cccc8f9aef522d3574659680f9831
Clear filters https://github.com/simstudioai/sim/pull/5278/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
sim-settings-pages.md https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
layout.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-46791891f75330f89eb27e7ea33609c28ce724657d28cb3d38e6bb935d3088f4
settings.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
api-keys.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
copilot.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
credential-sets.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-005ccf1d4f8269ed850d2c20a5af7e838f7af2adb415a186565704fa00fc6a2d
custom-tools.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-3716dbdb44daa653e829caa644c29b1dc2ad568f2505c2298a73a730d9d7cb02
general.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-1399306bf79ad53ce246baccbfae7d3037e74a2b52fc447a212261f6d1940867
mcp.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-a4da5c277b6d754bb18bdf732cde648008b9624c1d73729926799e4a5c6a8fbc
save-discard-actions.ts https://github.com/simstudioai/sim/pull/5278/files#diff-0a7863548a6f419a7c8da169e69c32ccef333fe5b31fadecdef1a54ab06755b8
save-discard-actions.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-68108f359df4492e890efa71867b31b49db9216a57f5c29bf8a24bb441ea26e3
secrets-manager.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-2b2005db8b8d047cb3aba7c97de2978fe046a48ced2e80dd066bd341bc0d4c04
settings-header.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-1fb02ea56d034bb6bd6c5d27db4b316182723d58724e1939d17956052f9cfaa9
settings-panel.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-d1a46921810c73b4274ad09dfc674975f6ced9fd3349e6b208d2a02480109c8e
team-management.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-5004afb31e199f6192259c7c27765aa541f8d82bc8a07e08e94a7d448d71e234
teammates.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-6552de4cf6d80acc6c8dcc22e8fcfeb9c1c503a332b25cc33f6310c8aaced1b5
workflow-mcp-servers.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-837f49406d0f223c875fd1223cf42f35ad614c98e32feae2b37fc87192767919
access-control.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-db36827fe741a6dfa649c366a49b8f97ad423585d8769363ff998759e1563094
group-detail.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-21da9abd0aabdc46d5b40bb02d16aaab5be8123ad85290a5e43ebf707cb0d8b2
data-drains-settings.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-8ba1350398138eaea7d16fa20c71b2528e4cba6039cae8ebc55c8b6a58caf868
data-retention-settings.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-764e9cf912d26c066290a0b604241370dd169586b89737be53eb4827da0b53ee
sso-settings.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-ab0807277e5cd6d53813e9eb72605df2cf6737dc34e17903c162ff777f228ac9
whitelabeling-settings.tsx https://github.com/simstudioai/sim/pull/5278/files#diff-c2c6c93b98cc4b0aae84382ed1d8c5e5ae01276bc0cd8b62ae4d73400c196af5
.claude/rules/sim-settings-pages.mdhttps://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
View file https://github.com/simstudioai/sim/blob/f174569d988cccc8f9aef522d3574659680f9831/.claude/rules/sim-settings-pages.md
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5278/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
https://github.com/simstudioai/sim/pull/5278/files#diff-d24de0488488af163cadc98377f6ea8e4931df1d825b3fe636174b2cce792f1c
apps/sim/app/workspace/[workspaceId]/settings/[section]/layout.tsxhttps://github.com/simstudioai/sim/pull/5278/files#diff-46791891f75330f89eb27e7ea33609c28ce724657d28cb3d38e6bb935d3088f4
View file https://github.com/simstudioai/sim/blob/f174569d988cccc8f9aef522d3574659680f9831/apps/sim/app/workspace/%5BworkspaceId%5D/settings/%5Bsection%5D/layout.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5278/{{ revealButtonHref }}
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
apps/sim/app/workspace/[workspaceId]/settings/[section]/settings.tsxhttps://github.com/simstudioai/sim/pull/5278/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
View file https://github.com/simstudioai/sim/blob/f174569d988cccc8f9aef522d3574659680f9831/apps/sim/app/workspace/%5BworkspaceId%5D/settings/%5Bsection%5D/settings.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5278/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5278/files#diff-a82a043ca7a7736b97bf6a5385a54339c186c7a782a1bd4d3e61c87c6ac2975d
apps/sim/app/workspace/[workspaceId]/settings/components/api-keys/api-keys.tsxhttps://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
View file https://github.com/simstudioai/sim/blob/f174569d988cccc8f9aef522d3574659680f9831/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/api-keys/api-keys.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5278/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
https://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
https://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
https://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
https://github.com/simstudioai/sim/pull/5278/files#diff-ec7967ebcdce63118eeb33a59a35a2767b0fe41f36fa197553758ade73e761b3
apps/sim/app/workspace/[workspaceId]/settings/components/copilot/copilot.tsxhttps://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
View file https://github.com/simstudioai/sim/blob/f174569d988cccc8f9aef522d3574659680f9831/apps/sim/app/workspace/%5BworkspaceId%5D/settings/components/copilot/copilot.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5278/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
https://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
https://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
https://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
https://github.com/simstudioai/sim/pull/5278/files#diff-5e72035508aba47f403d7cf23de5300b4a22adbc0978deccd2018c720f6b67c2
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5278/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.