Title: feat(workflow-renderer): extract pure WorkflowBlockView + SubBlockRowView by waleedlatif1 · Pull Request #5267 · simstudioai/sim · GitHub
Open Graph Title: feat(workflow-renderer): extract pure WorkflowBlockView + SubBlockRowView by waleedlatif1 · Pull Request #5267 · simstudioai/sim
X Title: feat(workflow-renderer): extract pure WorkflowBlockView + SubBlockRowView by waleedlatif1 · Pull Request #5267 · simstudioai/sim
Description: Summary Completes the workflow renderer by extracting the canvas block node — the most complex one — into pure, props-driven Views in @sim/workflow-renderer, matching the edge/subflow/note pattern from #5263. SubBlockRowView — the collapsed block's subblock summary row ({ title, displayValue?, isMonospace? }). The ~9 selector-name hydration hooks (credentials, knowledge bases, tables, MCP servers/tools, sub-workflows, skills, variables) stay in the row container behind its memo comparator; the view receives only resolved strings. WorkflowBlockView — the block shell (header, icon, all badges, dynamic condition/router/error handles, ring). The editor node becomes a thin container that resolves stores/hooks/permissions, builds the subblock rows + actionBar slots, and binds wouldCreateConnectionCycle (reads the edge store fresh per call, preserving cycle-prevention for collaborators). config.icon/bgColor, the webhook provider name, and every visual flag cross as props. Container drops 1137 → 829 lines. Visual output and behavior are unchanged — verified by an independent adversarial byte-identical audit (every handle id/class/style/offset, all four badges with their guards, isValidConnection polarity, and the ring all confirmed identical). Type of Change Refactor (no functional/visual change) Testing apps/sim + @sim/workflow-renderer typecheck 0 errors; monorepo boundaries + biome clean. The View imports only react/@sim/emcn/reactflow/../dimensions/../types — nothing app-coupled. Independent byte-identical audit of the View + container vs the original render: zero behavior/visual differences. Checklist Code follows project style guidelines Self-reviewed my changes Tests added/updated and passing No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary Completes the workflow renderer by extracting the canvas block node — the most complex one — into pure, props-driven Views in @sim/workflow-renderer, matching the edge/subflow/note pattern ...
X Description: Summary Completes the workflow renderer by extracting the canvas block node — the most complex one — into pure, props-driven Views in @sim/workflow-renderer, matching the edge/subflow/note pattern ...
Opengraph URL: https://github.com/simstudioai/sim/pull/5267
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:20c72c1a-6e05-7f03-7b0d-85cb4b86ca4e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DB68:14C9D4:1E556B:2AA593:6AFB502A |
| html-safe-nonce | a525b8b2a3ec5546b5e6b77e15ff4d387b539811038d9e8fa81be4700ca6d937 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjY4OjE0QzlENDoxRTU1NkI6MkFBNTkzOjZBRkI1MDJBIiwidmlzaXRvcl9pZCI6IjI0MDIzMzEzNjI1NzM2MzU2MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d1a9279e2737f6c24cd7f4e0b6e65cf2b46d2dd45b6254de58fa14c744788408 |
| hovercard-subject-tag | pull_request:3958141059 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5267/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary Completes the workflow renderer by extracting the canvas block node — the most complex one — into pure, props-driven Views in @sim/workflow-renderer, matching the edge/subflow/note pattern ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width