Title: fix(webhooks): run inactive deployment-version cleanup inline on deploy by waleedlatif1 · Pull Request #5250 · simstudioai/sim · GitHub
Open Graph Title: fix(webhooks): run inactive deployment-version cleanup inline on deploy by waleedlatif1 · Pull Request #5250 · simstudioai/sim
X Title: fix(webhooks): run inactive deployment-version cleanup inline on deploy by waleedlatif1 · Pull Request #5250 · simstudioai/sim
Description: Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letters silently, old-version webhooks linger as is_active=true orphans that fetchActiveWebhooks skips (deployment-version mismatch) — so they silently stop polling. In prod this stranded ~515 webhooks across ~130 workflows. Fix: run the existing cleanupInactiveDeploymentVersions synchronously in the SYNC_ACTIVE handler, right after the active version's webhooks/schedules are registered — falling back to the deferred outbox event only if the inline pass throws. This reuses the existing guarded cleanup rather than introducing new deletion logic. That cleanup already re-checks each version is still inactive (isDeploymentVersionActive) before tearing anything down, and re-enqueues side-effects if a version became active — so it can never touch the active version. Why this layer (addressing the first review round) An earlier revision folded stale-webhook deletion into saveTriggerWebhooksForDeploy. Review correctly flagged two problems with that approach, both avoided here: Strict cleanup blocking registration (P1): the outbox path uses strictExternalCleanup: true, so tearing down a stale/missing external subscription before registration could abort the deploy and leave the active version unregistered. Here cleanup runs strictly after registration, and a failure is caught and deferred — it can never block registration. Active-version race (P2): deleting by snapshot could tear down a version that concurrently became active. The reused cleanupInactiveDeploymentVersions re-checks active-ness before each delete (the existing shouldDeleteWebhook guard), so it's race-safe. Scope Closes the leak going forward. Backfilling the ~515 already-stranded rows remains a separate ops pass (the "fully dead" subset needs external OAuth/polling subscriptions recreated via deploy side-effects). Type of Change Bug fix Testing tsc + biome clean. Full webhooks suite green. No new unit test: the change reuses the already-exercised cleanupInactiveDeploymentVersions unchanged; the only new code is an inline-with-deferred-fallback wrapper. An isolated test would require brittle deep-mocking of the cleanup's internal db-query ordering and would assert little, so it was deliberately omitted rather than added as a checkbox. Checklist Code follows project style guidelines Self-reviewed my changes No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)
Open Graph Description: Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letters si...
X Description: Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letter...
Opengraph URL: https://github.com/simstudioai/sim/pull/5250
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c97ff133-374f-3aff-1453-e7e8e05cc0c2 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DED8:186510:B0253F:F20A79:6AFB5172 |
| html-safe-nonce | 7480019e520fee9418afe6770e06a4619dd1813010e565e52c56c7a7467281e3 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUQ4OjE4NjUxMDpCMDI1M0Y6RjIwQTc5OjZBRkI1MTcyIiwidmlzaXRvcl9pZCI6IjQ0NzU5ODQzODk2MTE0MDk3NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 3d9db42e664747b0441c7ac2da6c8f020b3b91c67ef2fa5b382df6c02d9ec504 |
| hovercard-subject-tag | pull_request:3949443245 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5250/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letters si... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width