René's URL Explorer Experiment


Title: fix(webhooks): run inactive deployment-version cleanup inline on deploy by waleedlatif1 · Pull Request #5250 · simstudioai/sim · GitHub

Open Graph Title: fix(webhooks): run inactive deployment-version cleanup inline on deploy by waleedlatif1 · Pull Request #5250 · simstudioai/sim

X Title: fix(webhooks): run inactive deployment-version cleanup inline on deploy by waleedlatif1 · Pull Request #5250 · simstudioai/sim

Description: Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letters silently, old-version webhooks linger as is_active=true orphans that fetchActiveWebhooks skips (deployment-version mismatch) — so they silently stop polling. In prod this stranded ~515 webhooks across ~130 workflows. Fix: run the existing cleanupInactiveDeploymentVersions synchronously in the SYNC_ACTIVE handler, right after the active version's webhooks/schedules are registered — falling back to the deferred outbox event only if the inline pass throws. This reuses the existing guarded cleanup rather than introducing new deletion logic. That cleanup already re-checks each version is still inactive (isDeploymentVersionActive) before tearing anything down, and re-enqueues side-effects if a version became active — so it can never touch the active version. Why this layer (addressing the first review round) An earlier revision folded stale-webhook deletion into saveTriggerWebhooksForDeploy. Review correctly flagged two problems with that approach, both avoided here: Strict cleanup blocking registration (P1): the outbox path uses strictExternalCleanup: true, so tearing down a stale/missing external subscription before registration could abort the deploy and leave the active version unregistered. Here cleanup runs strictly after registration, and a failure is caught and deferred — it can never block registration. Active-version race (P2): deleting by snapshot could tear down a version that concurrently became active. The reused cleanupInactiveDeploymentVersions re-checks active-ness before each delete (the existing shouldDeleteWebhook guard), so it's race-safe. Scope Closes the leak going forward. Backfilling the ~515 already-stranded rows remains a separate ops pass (the "fully dead" subset needs external OAuth/polling subscriptions recreated via deploy side-effects). Type of Change Bug fix Testing tsc + biome clean. Full webhooks suite green. No new unit test: the change reuses the already-exercised cleanupInactiveDeploymentVersions unchanged; the only new code is an inline-with-deferred-fallback wrapper. An isolated test would require brittle deep-mocking of the cleanup's internal db-query ordering and would assert little, so it was deliberately omitted rather than added as a checkbox. Checklist Code follows project style guidelines Self-reviewed my changes No new warnings introduced I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

Open Graph Description: Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letters si...

X Description: Summary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letter...

Opengraph URL: https://github.com/simstudioai/sim/pull/5250

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:c97ff133-374f-3aff-1453-e7e8e05cc0c2
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDED8:186510:B0253F:F20A79:6AFB5172
html-safe-nonce7480019e520fee9418afe6770e06a4619dd1813010e565e52c56c7a7467281e3
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUQ4OjE4NjUxMDpCMDI1M0Y6RjIwQTc5OjZBRkI1MTcyIiwidmlzaXRvcl9pZCI6IjQ0NzU5ODQzODk2MTE0MDk3NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3d9db42e664747b0441c7ac2da6c8f020b3b91c67ef2fa5b382df6c02d9ec504
hovercard-subject-tagpull_request:3949443245
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5250/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altSummary When a deploy activates a new version, the superseded versions' webhooks are removed by a separate, best-effort CLEANUP_INACTIVE outbox event. When that event is lost / dead-letters si...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5250/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5250%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5250%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5250/files
Reloadhttps://github.com/simstudioai/sim/pull/5250/files
Reloadhttps://github.com/simstudioai/sim/pull/5250/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
worktree-webhook-version-strandinghttps://github.com/simstudioai/sim/tree/worktree-webhook-version-stranding
Conversation 9 https://github.com/simstudioai/sim/pull/5250
Commits 1 https://github.com/simstudioai/sim/pull/5250/commits
Checks 16 https://github.com/simstudioai/sim/pull/5250/checks
Files changed https://github.com/simstudioai/sim/pull/5250/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5250/files
fix(webhooks): run inactive deployment-version cleanup inline on deploy https://github.com/simstudioai/sim/pull/5250/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5250/files
4508552 fix(webhooks): run inactive deployment-version cleanup inline on deploy waleedlatif1 Jun 28, 2026 https://github.com/simstudioai/sim/pull/5250/commits/4508552bc63974112f35047163d3516f5d80259e
Clear filters https://github.com/simstudioai/sim/pull/5250/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5250/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5250/files
apps/sim/lib/workflows/deployment-outbox.tshttps://github.com/simstudioai/sim/pull/5250/files#diff-31b0b82ca5e72feea1bbcac6b4c21a2e4f9551a96dd0d52d8a178be5177e7164
View file https://github.com/simstudioai/sim/blob/4508552bc63974112f35047163d3516f5d80259e/apps/sim/lib/workflows/deployment-outbox.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5250/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5250/files#diff-31b0b82ca5e72feea1bbcac6b4c21a2e4f9551a96dd0d52d8a178be5177e7164
https://github.com/simstudioai/sim/pull/5250/files#diff-31b0b82ca5e72feea1bbcac6b4c21a2e4f9551a96dd0d52d8a178be5177e7164
https://github.com/simstudioai/sim/pull/5250/files#diff-31b0b82ca5e72feea1bbcac6b4c21a2e4f9551a96dd0d52d8a178be5177e7164
https://github.com/simstudioai/sim/pull/5250/files#diff-31b0b82ca5e72feea1bbcac6b4c21a2e4f9551a96dd0d52d8a178be5177e7164
Please reload this pagehttps://github.com/simstudioai/sim/pull/5250/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.