René's URL Explorer Experiment


Title: fix(sso): keep an exit affordance in edit mode when clean by waleedlatif1 · Pull Request #5247 · simstudioai/sim · GitHub

Open Graph Title: fix(sso): keep an exit affordance in edit mode when clean by waleedlatif1 · Pull Request #5247 · simstudioai/sim

X Title: fix(sso): keep an exit affordance in edit mode when clean by waleedlatif1 · Pull Request #5247 · simstudioai/sim

Description: Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicking Edit on an existing SSO provider (isEditing=true, no changes yet), there were no header actions — no way to leave edit mode back to the read-only summary without first changing a field (to summon Discard) or navigating away from the section. The pre-consolidation UI had an always-visible Cancel button in edit mode; the migration dropped it. (Flagged by Cursor on the v0.7.16 release PR #5245.) Fix Render a Cancel chip when isEditing && !hasChanges — when there are changes, the dirty-gated SaveDiscardActions Discard already exits. The two are mutually exclusive, so exactly one exit affordance is always present in edit mode: edit + clean → Cancel (exits to summary) edit + dirty → Discard (exits) + Update create mode / read-only summary → unchanged Audit Audited every SaveDiscardActions consumer for the same trap-class: the two detail sub-views (data-retention, access-control group-detail) keep an always-rendered back chip, and the top-level pages (whitelabeling, secrets) exit via the settings nav — none are trapped. tsc + biome clean.

Open Graph Description: Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicking E...

X Description: Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicki...

Opengraph URL: https://github.com/simstudioai/sim/pull/5247

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b0f6ea1b-7149-f1b3-af2e-9bfb432e3585
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB1A6:FD97C:22D488:30C199:6AFB514B
html-safe-noncebf42ac5ad02810f5d48bbe6206b79a53c5f20840767262a24bf2bf62caa9dd10
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUE2OkZEOTdDOjIyRDQ4ODozMEMxOTk6NkFGQjUxNEIiLCJ2aXNpdG9yX2lkIjoiMzE2ODI3OTgyNzA5NDEzMTAxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8eafe8d1cfa8d1e1d8e1a9ff45bf45bb4b3951853a51c787675515d316f6fee8
hovercard-subject-tagpull_request:3949057719
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5247/files
twitter:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/40672544?s=400&v=4
og:image:altProblem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicking E...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/simstudioai/sim git https://github.com/simstudioai/sim.git
octolytics-dimension-user_id199344406
octolytics-dimension-user_loginsimstudioai
octolytics-dimension-repository_id912559512
octolytics-dimension-repository_nwosimstudioai/sim
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id912559512
octolytics-dimension-repository_network_root_nwosimstudioai/sim
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasecbf66c024bb6d10e6955baa7413c54cf13a201bb
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/simstudioai/sim/pull/5247/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5247%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fsimstudioai%2Fsim%2Fpull%2F5247%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=simstudioai%2Fsim
Reloadhttps://github.com/simstudioai/sim/pull/5247/files
Reloadhttps://github.com/simstudioai/sim/pull/5247/files
Reloadhttps://github.com/simstudioai/sim/pull/5247/files
simstudioaihttps://github.com/simstudioai
simhttps://github.com/simstudioai/sim
Codehttps://github.com/simstudioai/sim
Issues129 (129)https://github.com/simstudioai/sim/issues
Pull requests197 (197)https://github.com/simstudioai/sim/pulls
Actionshttps://github.com/simstudioai/sim/actions
Projectshttps://github.com/simstudioai/sim/projects
Security and qualityhttps://github.com/simstudioai/sim/security
Insightshttps://github.com/simstudioai/sim/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fsimstudioai%2Fsim%2Fissues%2Fnew%2Fchoose
waleedlatif1https://github.com/waleedlatif1
staginghttps://github.com/simstudioai/sim/tree/staging
fix/sso-edit-mode-exithttps://github.com/simstudioai/sim/tree/fix/sso-edit-mode-exit
Conversation 5 https://github.com/simstudioai/sim/pull/5247
Commits 1 https://github.com/simstudioai/sim/pull/5247/commits
Checks 16 https://github.com/simstudioai/sim/pull/5247/checks
Files changed https://github.com/simstudioai/sim/pull/5247/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5247/files
fix(sso): keep an exit affordance in edit mode when clean https://github.com/simstudioai/sim/pull/5247/files#top
Show all changes 1 commit https://github.com/simstudioai/sim/pull/5247/files
3858fcd fix(sso): keep an exit affordance in edit mode when clean waleedlatif1 Jun 27, 2026 https://github.com/simstudioai/sim/pull/5247/commits/3858fcd377e33bfa752e3a0e4fe703c4f6676309
Clear filters https://github.com/simstudioai/sim/pull/5247/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5247/files
Please reload this pagehttps://github.com/simstudioai/sim/pull/5247/files
apps/sim/ee/sso/components/sso-settings.tsxhttps://github.com/simstudioai/sim/pull/5247/files#diff-ab0807277e5cd6d53813e9eb72605df2cf6737dc34e17903c162ff777f228ac9
View file https://github.com/simstudioai/sim/blob/3858fcd377e33bfa752e3a0e4fe703c4f6676309/apps/sim/ee/sso/components/sso-settings.tsx
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/simstudioai/sim/pull/5247/{{ revealButtonHref }}
https://github.com/simstudioai/sim/pull/5247/files#diff-ab0807277e5cd6d53813e9eb72605df2cf6737dc34e17903c162ff777f228ac9
https://github.com/simstudioai/sim/pull/5247/files#diff-ab0807277e5cd6d53813e9eb72605df2cf6737dc34e17903c162ff777f228ac9
https://github.com/simstudioai/sim/pull/5247/files#diff-ab0807277e5cd6d53813e9eb72605df2cf6737dc34e17903c162ff777f228ac9
https://github.com/simstudioai/sim/pull/5247/files#diff-ab0807277e5cd6d53813e9eb72605df2cf6737dc34e17903c162ff777f228ac9
Please reload this pagehttps://github.com/simstudioai/sim/pull/5247/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.