Title: fix(sso): keep an exit affordance in edit mode when clean by waleedlatif1 · Pull Request #5247 · simstudioai/sim · GitHub
Open Graph Title: fix(sso): keep an exit affordance in edit mode when clean by waleedlatif1 · Pull Request #5247 · simstudioai/sim
X Title: fix(sso): keep an exit affordance in edit mode when clean by waleedlatif1 · Pull Request #5247 · simstudioai/sim
Description: Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicking Edit on an existing SSO provider (isEditing=true, no changes yet), there were no header actions — no way to leave edit mode back to the read-only summary without first changing a field (to summon Discard) or navigating away from the section. The pre-consolidation UI had an always-visible Cancel button in edit mode; the migration dropped it. (Flagged by Cursor on the v0.7.16 release PR #5245.) Fix Render a Cancel chip when isEditing && !hasChanges — when there are changes, the dirty-gated SaveDiscardActions Discard already exits. The two are mutually exclusive, so exactly one exit affordance is always present in edit mode: edit + clean → Cancel (exits to summary) edit + dirty → Discard (exits) + Update create mode / read-only summary → unchanged Audit Audited every SaveDiscardActions consumer for the same trap-class: the two detail sub-views (data-retention, access-control group-detail) keep an always-rendered back chip, and the top-level pages (whitelabeling, secrets) exit via the settings nav — none are trapped. tsc + biome clean.
Open Graph Description: Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicking E...
X Description: Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicki...
Opengraph URL: https://github.com/simstudioai/sim/pull/5247
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react-reconciler,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@d5750093facf |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b0f6ea1b-7149-f1b3-af2e-9bfb432e3585 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B1A6:FD97C:22D488:30C199:6AFB514B |
| html-safe-nonce | bf42ac5ad02810f5d48bbe6206b79a53c5f20840767262a24bf2bf62caa9dd10 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMUE2OkZEOTdDOjIyRDQ4ODozMEMxOTk6NkFGQjUxNEIiLCJ2aXNpdG9yX2lkIjoiMzE2ODI3OTgyNzA5NDEzMTAxOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8eafe8d1cfa8d1e1d8e1a9ff45bf45bb4b3951853a51c787675515d316f6fee8 |
| hovercard-subject-tag | pull_request:3949057719 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/simstudioai/sim/pull/5247/files |
| twitter:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/40672544?s=400&v=4 |
| og:image:alt | Problem After the settings save/discard consolidation, the SSO edit form's only header action is the shared SaveDiscardActions, which renders nothing when the form is clean. So after clicking E... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 7122bb414b542dba14d71a3f0b9f6fd2abce715b9f5912d082800563e6c806d1 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/simstudioai/sim git https://github.com/simstudioai/sim.git |
| octolytics-dimension-user_id | 199344406 |
| octolytics-dimension-user_login | simstudioai |
| octolytics-dimension-repository_id | 912559512 |
| octolytics-dimension-repository_nwo | simstudioai/sim |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 912559512 |
| octolytics-dimension-repository_network_root_nwo | simstudioai/sim |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | cbf66c024bb6d10e6955baa7413c54cf13a201bb |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width